poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46859] [Patch] rename org.apache.poi.openxml4j.opc.Package
Date Mon, 16 Mar 2009 06:44:55 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46859





--- Comment #1 from Josh Micich <josh@gildedtree.com>  2009-03-15 23:44:53 PST ---
Created an attachment (id=23386)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23386)
svn diff

Please consider this patch and give feedback.

In this patch I have created a new base class called "OPCPackage".  The
existing Package class has been deprecated and now extends OPCPackage. The rest
of POI code has been changed to use the new non-deprecated class.

The new name 'OPCPackage' is negotiable.  Other names I considered were
'OpenPackage', 'OpenPackageContainer', 'XMLPackage' and 'PackageBase'.

If maintaining binary compatibility with previous poi-ooxml versions is
important, we will need to re-add deprecated versions of many methods which
take OPCPackage as a parameter.  Most of the usage of Package was internal,
however there are some notable public methods/constructors, like
XSSFWorkbook(Package).


An unrelated change was to restrict the class hierarchy of Package to only POI
subclasses (i.e. ZipPackage).  This was done because POI discourages client
classes from inheriting from POI classes.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message