poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 41933] PicturesTable#getAlllPictures() sometimes loses images
Date Thu, 12 Mar 2009 05:20:01 GMT

--- Comment #8 from Trejkaz <trejkaz@trypticon.org>  2009-03-11 22:20:00 PST ---
Looking at the current trunk version (and the slightly older version we're
running) it seems that half of my workaround (rewritten) ended up becoming the
current version of getAllPictures().

The only inconsistency is that the rewrite in the POI version results in it
returning the same image multiple times (as it's no longer building the map to
keep track of this.)

I'm not sure whether I should (a) modify POI so that it removes the duplicates
and submit that up, or (b) add some method to Picture so that I can
de-duplicate myself from the outside, and then submit that smaller modification

Obviously I'm leaning toward (a) but since it seems like the duplicate removal
was intentionally removed from the code, perhaps (b) is the better option?

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

View raw message