Mailing-List: contact dev-help@poi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "POI Developers List" <dev@poi.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <49A3D751.2010504@dinom.ru>
Date: Tue, 24 Feb 2009 14:17:37 +0300
From: Yegor Kozlov <yegor@dinom.ru>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: POI Developers List <dev@poi.apache.org>
CC: POI Developers List <poi-dev@jakarta.apache.org>
Subject: Re: [VOTE] Release of POI 3.5-beta5
References: <49901438.5050604@dinom.ru>
 <510143ac0902190453y37ed56acm8defd0780dd39187@mail.gmail.com>
 <AAF2E534-3226-46C7-9705-B2BCA09B3AF6@jmlafferty.com>
 <a644352c0902192004g6c9721bcn89545a3ae3d0d8f7@mail.gmail.com>
 <AE328210-6250-4E4D-B49D-310139CB20B9@jmlafferty.com>
 <499E6B0A.4060908@dinom.ru>
 <D9E8E9E1-9660-42C8-8CF0-5E17621A15E9@jmlafferty.com>
In-Reply-To: <D9E8E9E1-9660-42C8-8CF0-5E17621A15E9@jmlafferty.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Dave,
> I had to ask. I've seen a Jakarta beta do it differently, but we are a 
> huge project compared to that.
>
> So, OK. Let's make sure that we get these issues resolved next week - 
> then at least the nightly builds will have all the details properly 
> marked.
>
> (1) A really, really proper NOTICE and LICENSE.
> (2) All copyright statements in the project properly checked and 
> adjusted.
Should be fixed in r747303.

> (3) All source files with the proper license statement in them.
>

We had files with a non-standard ASF2 licence header:

Compare two versions:

/* ====================================================================
   Copyright 2002-2004   Apache Software Foundation

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
   You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
==================================================================== */

and

/* ====================================================================
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
   this work for additional information regarding copyright ownership.
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at

       http://www.apache.org/licenses/LICENSE-2.0

   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
==================================================================== */

The files are:

trunk\src\java\org\apache\poi\hssf\record\DVALRecord.java
trunk\src\java\org\apache\poi\hssf\record\DVRecord.java
trunk\src\java\org\apache\poi\hssf\usermodel\DVConstraint.java
trunk\src\java\org\apache\poi\hssf\usermodel\HSSFDataValidation.java
trunk\src\java\org\apache\poi\hssf\usermodel\HSSFObjectData.java
trunk\src\java\org\apache\poi\hssf\usermodel\HSSFOptimiser.java
trunk\src\java\org\apache\poi\hssf\usermodel\HSSFPictureData.java
trunk\src\java\org\apache\poi\hssf\util\CellRangeAddress.java
trunk\src\java\org\apache\poi\hssf\util\CellRangeAddress8Bit.java
trunk\src\java\org\apache\poi\hssf\util\CellRangeAddressList.java
trunk\src\java\org\apache\poi\ss\util\CellRangeAddress.java
trunk\src\java\org\apache\poi\ss\util\CellRangeAddressBase.java
trunk\src\java\org\apache\poi\ss\util\CellRangeAddressList.java
trunk\src\testcases\org\apache\poi\hssf\usermodel\TestDataValidation.java
trunk\src\testcases\org\apache\poi\hssf\usermodel\TestHSSFOptimiser.java
trunk\src\testcases\org\apache\poi\hssf\usermodel\TestRowStyle.java

I changed all of them to have the standard header just to be on the safe 
side :)
> Do we have any other copyrights in the code other than one we had the 
> author re-license?
> ./resources/scratchpad/org/apache/poi/hdgf/chunks_parse_cmds.tbl
> 3:# Copyright (C) 2006-2007     Valek Filippov (frob@df.ru)
>
No, I think it was the only case.  I searched and didn't find any other 
copyrights .

Another potential issue are our test files. Many of them were uploaded 
in Bugzilla and then included in svn.
A way to identify ownership of a MS Office file is via its OLE 
properties. Currently  the test files are distributed "as is" and there 
is no indication that these files are a part of POI. That means if a 
user examines them, he sees the Author, Company and other properties in 
the original form, as they were submitted to Bugzilla.

Do we have to care about them? If yes,  I see two potential improvements:

 - include an entry in the NOTICE covering the test files.
 - programmatically insert the ASF license, for example, in the Comments 
OLE property. Create an utility to audit test files before release.


Regards,
Yegor

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org