poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46548] HSSFPrintSetup throws NPE when accessing print settings of existing XLS
Date Sat, 17 Jan 2009 03:18:17 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46548


Josh Micich <josh@gildedtree.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Josh Micich <josh@gildedtree.com>  2009-01-16 19:18:16 PST ---
Fixed in svn r735179 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=735179 )
Part of this change-list was the supplied patch (support for continued PLS
records).  The rest was additional fixes for other ways of getting multiple
PageSettingsBlocks.

I added the comments to Sheet.java in svn r683871 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=683871
)because I did not understand
why sheets sometimes appeared to have more than one PageSettingsBlock.  Further
investigation (of the test sample files) now, suggests that there are two
situations where this occurs: with nested chart sub-streams and nested 'Custom
View Settings' sub-streams each of which can contain its own PageSettingsBlock.
 Prior to this fix POI handled PSBs in nested charts OK, but not within the
'Custom View Settings'.

There were also two circumstances in which POI would incorrectly create two
PageSettingsBlocks where one was needed.  The first was in the case of a
continued PLS record (fixed by the patch provided).  The other situation
occurred when a WSBOOL record appears among the PSB records.  According to the
OOO docs WSBOOL is not part of the PSB; it should occur before the PSB.  All
but two of the junit test files agree with this.

The 'Custom View Settings' fix and the misplaced WSBOOL fix resulted in changes
to the code near the comments you pointed out.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message