poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46479] [PATCH] evaluateInCell fails if the formula was previously invalid
Date Mon, 05 Jan 2009 21:12:21 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46479


Josh Micich <josh@gildedtree.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Josh Micich <josh@gildedtree.com>  2009-01-05 13:12:20 PST ---
Thanks for the patch.  There is some ambiguity in original design as to whether
setCellType() should be called before or after setCellValue().  The methods
overlap in behaviour:  setCellValue() may change the cell type, and
setCellType() converts the old cell value to the new type and sets the new
value in the cell.
The new ordering of these calls (setCellValue before setCellType) actually
causes other junits to fail, but your fix still seems correct to me.

Three other related bugs were found and fixed, and junits added for all of
them. 

svn r731715 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=731715 )

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message