poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44417] - [patch] CellReference.getSheetName() returns a String which HSSFSheet.getSheet() does not find
Date Thu, 14 Feb 2008 06:35:31 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44417>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44417


josh@gildedtree.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CellReference.getSheetName()|[patch]
                   |returns a String which      |CellReference.getSheetName()
                   |HSSFSheet.getSheet() does   |returns a String which
                   |not find                    |HSSFSheet.getSheet() does
                   |                            |not find




------- Additional Comments From josh@gildedtree.com  2008-02-13 22:35 -------
Added patch to fix this bug.

The example provided was not explicit, but it is assumed that the sheet name 
had special characters in it (probably a space).  There has been a recent 
change (44336) that causes "name.getReference()" in the example to return 
quoted sheet names if any special characters are present.  The required fix is 
to make AreaReference and CellReference handle sheet names with special 
characters.


Fixed AreaReference.separateAreaRefs() to only consider cell delimiters (:) 
outside quoted sheet names.
Fixed CellReference.separateRefParts() to handle sheet names with special 
characters (assuming properly delimited).
Made sure CellReference.getSheetName() returns a raw sheet name.


Changed AreaReference to model its 2 CellReference components as first class 
fields 'firstCell' and 'lastCell' instead of an array.

Created new methods "formatAsString()" on AreaReference and CellReference and 
moved important logic out of toString().  Added javadoc.
Replaced all references to AreaReference.toString() and CellReference.toString
() with calls to formatAsString().

Added test cases to existing junits TestAreaReference and TestCellReference.  
Added test suite for org.apache.poi.hssf.util package.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message