poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44050] - [PATCH] Trim function in formula cell
Date Tue, 11 Dec 2007 18:21:29 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44050>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44050





------- Additional Comments From wilson@cbio.mskcc.org  2007-12-11 10:21 -------
Thanks Nick.  Actually, I was wondering about the testing.  Trim was being tested in:

src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java

Which appears to set up a new GenericFormulaTestCase for every function listed in 
FormulaEvalTestData.xls between rows 80 and 1481.  Row 80 marks the beginning of the Excel

functions section.

I know it was testing trim successfully because while developing I kept running:

ant -Dtestcase=org.apache.poi.hssf.record.formula.functions.TestEverything single-scratchpad-test

Which was failing on trim for a while.

I was wondering why some functions are listed explicitly in the file you mentioned, 
src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java, when
the 
same test is run in 
src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java.
 So far 
the only overlaps are concatenate, int, trim and upper.  I suspect that TestEverything.java
in the eval 
package was meant only to test things like "=B7<B8" and not in fact the excel functions.

(In reply to comment #3)
> Thanks, committed
> 
> One thing to note is that not all of the contents of FormulaEvalTestData.xls
> isn't checked automatically. Once your function is working, you need to list the
> row number in
> src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
> , and then it'll get tested for you (I've added the Trim row number)




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


Mime
View raw message