Mailing-List: contact poi-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "POI Developers List" <poi-dev@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <20050614000252.nbb8pfwnk84gk4kk@203.145.183.216>
Date: Tue, 14 Jun 2005 00:02:52 +0530
From: Avik.sengupta@itellix.com
To: poi-dev@jakarta.apache.org
Subject: RE: FormulaRecord getValue &setVal ue enhancement
References: <20050613123842.51565.qmail@web32005.mail.mud.yahoo.com>
In-Reply-To: <20050613123842.51565.qmail@web32005.mail.mud.yahoo.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Mobile Internet Messaging Program (MIMP) 0.1-cvs

Can you put in the changes to the record and the aggregate ? I think your mail brings out an important point... Of how to provide high level access to formulas. Something i've put some thought to recently... But its the subject of another mail, and much debate.

Sorry he you received an empty mail earlier.Quoting Amol Deshmukh <amolweb@yahoo.com>:

>
>
> --- avik.sengupta@itellix.com wrote:
>> This will break existing code. Very Bad Thing! Also,
>> with my Alan Cooper fanboy
>> hat on, I think recommending to /prefer/ calling
>> setCellType() is in itself a Bad Thing.
>
> It wouldnt break existing code since existing code
> would be throwing CastClassException anyway :) But I
> get your point and am glad we had this discussion.
>
>
>>
>> I would say, add a method called
>> setCellFormulaResult() overloaded for
>> string/num etc.
>
> Yeah, probably a better option! Although maybe, I can
> do something like:
>   Create inner nested class Formula which has the
> overloaded setCellFormulaResult(..) methods (& a
> constructor that takes in the formula string)... and
> add setCellValue(HSSFCell.Formula f) to HSSFCell. This
> will keep the HSSFCell api clean since it will just
> add two methods (getFormulaValue/setCellValue(Formula
> f) - and I can make the javadocs very clear about
> how/when to use these method :)
>
>
>> I am sure we can fix the class cast exception on
>> calling setCellFormula
>> followed
>>   setCellValue independently.
>
> True. I should have thought of that! :) So now in
> setCellValue(..) methods we can change:
> if ((cellType != CELL_TYPE_STRING )
>  && (cellType != CELL_TYPE_FORMULA))
> {
>   setCellType(CELL_TYPE_STRING, false);
> }
>
>  --TO--
> if ((cellType != CELL_TYPE_STRING ))
> {
>   setCellType(CELL_TYPE_STRING, false);
> }
>
> [Since we will have a setCellValue(Formula f) that
> will take care of the formula with initial value]
>
> Regards,
> ~ amol
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
Mailing List:    http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/