Return-Path: Delivered-To: apmail-jakarta-poi-dev-archive@www.apache.org Received: (qmail 22240 invoked from network); 10 May 2005 19:43:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 May 2005 19:43:28 -0000 Received: (qmail 90837 invoked by uid 500); 10 May 2005 19:47:00 -0000 Delivered-To: apmail-jakarta-poi-dev-archive@jakarta.apache.org Received: (qmail 90818 invoked by uid 500); 10 May 2005 19:47:00 -0000 Mailing-List: contact poi-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "POI Developers List" Reply-To: "POI Developers List" Delivered-To: mailing list poi-dev@jakarta.apache.org Received: (qmail 90801 invoked by uid 99); 10 May 2005 19:47:00 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from arnie1.collegeview.com (HELO arnie1.collegeview.com) (207.0.184.5) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 10 May 2005 12:46:59 -0700 Received: by arnie.collegeview.com with Internet Mail Service (5.5.2658.27) id ; Tue, 10 May 2005 15:38:24 -0400 Message-ID: From: Amol Deshmukh To: 'POI Developers List' Subject: RE: FormulaEvaluator Partial Implementation Date: Tue, 10 May 2005 15:38:20 -0400 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2658.27) Content-Type: text/plain; charset="iso-8859-1" X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N > That's ok. For the initial bit, can you just zip/tgz the > directory. Provide patches after the initial additions > have been comitted. I am waiting to commit > till the dummy method javadocs are removed (maybe an awk > script might be quick?) done. but where do i send the zip? Or did you mean just attach it to the bug? > > Please try and remove the extraneous comments, i dont want to > put that in CVS. > I'll commit it as soon as that's done, I'm happy with everything else. > done. > Yeah, sure, thats understood, and no issues. But your 'empty cell' > comment made > me think, the function implementations should probably follow Excel > semantics.. > for eg, in the average function, empty cells do not add to > the number of > elements (ie, the denominator). Also, these semantics might > be different for > different versions of excel. How do we handle that. Exactly. Thats what made me think about having a BlankEval. Currently though, its not a /big/ problem because for most numerical formulas where blanks are ignored, even strings are ignored. So that is taken care of (but will change when I introduce BlankEval) > > A final thoguht on error handling. Your error handling is > modelled after OO.o. > In excel however, errors are a more limited set.. #REF, > #VALUE, etc. Do > we need > to think about how to handle/map those. Maybe it doesnt matter? > The idea was that since Oo errors are better documented, and this is a functionality that will be used in code, it should be helpful to give more information (Oo way) than less (excel way). Then again, apart from error handling, there are cases where excel and Oo behave differently - generally I have given preference to excel impl over Oo. Also, currently I am documenting these in code as I detect them, but any suggestions to better handle/document such cases are welcome. --------------------------------------------------------------------- To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/