poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glen Stampoultzis <gst...@iinet.net.au>
Subject Re: Bad code snippets?
Date Fri, 18 Jul 2003 00:14:11 GMT

Looks valid.  I've gone through and cleaned it up.  There were a number of 
oddities in HSSF that are now gone.

Will commit some time soon.

Regards,

Glen


At 11:37 AM 17/07/2003, you wrote:
>I've been using Eclipse while working on a patch.  It has a habit of
>complaining about a variety of things.  A couple I thought I'd ask whether I
>should bother reporting in Bugzilla or submitting patches.  The first two
>seem to be more likely to be an real problem.
>
>1) The UnknownRecord constructor "public UnknownRecord(short id, short size,
>byte [] data)" has an assignment statement that does nothing.  It should
>probably read "this.size = size" rather than "size = size".
>
>2) Likewise in UnknownRecord, the "protected void fillFields(byte [] data,
>short sid)" method should probably have "this.sid = sid" rather than "sid =
>sid".
>
>3) The first statement in the HSSF constructor "public HSSF(String infile,
>String outfile, boolean write)" contains an assignment of this.filename =
>filename.  Since filename is not an argument to the constructor there is no
>point to the statement.
>
>Comments?
>Rick
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: poi-dev-help@jakarta.apache.org


Glen Stampoultzis
gstamp@iinet.net.au
http://members.iinet.net.au/~gstamp/glen/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message