poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew C. Oliver" <acoli...@apache.org>
Subject Re: Getting patches accepted
Date Thu, 08 May 2003 18:59:40 GMT
Generally the #1 criteria is "following directions":-p


If you look down this list:

You'll find we're pretty reliable.  Notice if you don't put [PATCH] it
doesn't show up on the list (see rule #1) :-)

#2 criteria: 

Unit tests.  The POI committership is almost entirely test-infected.  We
think your patch is probably not very good unless there is a unit test.

#3 criteria:

All unit tests pass

#4 criteria: 

Easy of application (see rule #1) -- basically if I have to manually apply
the patch and can't just use the patch command, it will take FOREVER before
I get around to it.

Anyhow, I'm betting that if you put the [PATCH] preface these get applied
pretty quickly.  :-)


On 5/8/03 1:32 PM, "Chris Nokleberg" <chris@sixlegs.com> wrote:

> I see that a new release is imminent, so I'd like to ask what it takes
> to get bugs in the database closed out and the patches merged. In
> particular I'm concerned about the two bugs which I have created patches
> for:
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13478
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15062
> BTW, http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15807 is a
> duplicate of 13478.
> Together these three bugs have a total of 9 votes, so I'm sure other
> users would appreciate their resolution.
> Can I call a vote? If so, vote! :-)
> Thanks,
> Chris
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: poi-dev-help@jakarta.apache.org

Andrew C. Oliver
Custom enhancements and Commercial Implementation for Jakarta POI

For Java and Excel, Got POI?

View raw message