poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elvira Gurevich" <Elvira_Gurev...@ibi.com>
Subject RE: sheet names and string format read garbled on EBCDIC machine
Date Wed, 09 Apr 2003 14:12:17 GMT
Please don't forget org.apache.poi.hssf.record.BoundSheetRecord, around
line 143, and org.apache.poi.hssf.record.FormatRecord around line 133.
Changed sources are attached here. Is this the right procedure for
submitting changes? 

If Toshiaki also could send me a test excel file created on a Shift_JIS
machine, I'll put it through my appl on OS/390 (EBCDIC) and en_us
version of Windows...


-----Original Message-----
From: Andrew C. Oliver [mailto:acoliver@apache.org] 
Sent: Wednesday, April 09, 2003 8:28 AM
To: POI Developers List
Subject: Re: sheet names and string format read garbled on EBCDIC
machine

Toshiaki Kamoshida wrote:

>If you can,there is a way to avoid to be worried about the problem,
>
>1.Serach all phrases
>  "new String(byte[])"or
>  "new String(byte[],int offset,int size)"
>
>2.Replace thease phrases to "new String(args,"ISO-8859-1")"
>  
>
yes.  This is what I did before everywhere that I found it.  If you find

other places that it should be done, please submit patches/unit
tests/etc.

>I feel,the place using phrases like 1,you expect that byte array
>contains "ISO-8859-1"(1 char always consumes only 1byte and the 
>charset is Latin-1),and if you must parse byte array as 16Bit 
>Unicode,always you must use StringUtil.
>And I feel,if the changes like this causes some problems,it is
>the bug"the place doesn't support i18n" from the beginning.
>  
>
yes/no  we should support i18n. 

>But,can you change sources without appearing sickness?
>Is the way "too rough"?
>  
>
This is opensource.  We can always patch.  I don't worry about
appearences.

-Andy

>On Tue, 08 Apr 2003 11:23:29 -0400
>"Andrew C. Oliver" <acoliver@apache.org> wrote:
>
>  
>
>>I think our main problem is on machines with a different default
>>encoding. Like mainframes for instance or some UNIX boxes (though
UTF-8
>>works). This is symptomatic of none of the core committers being
>>mainframers (volunteers are WELCOME!). There is a work around by
passing
>>-Dfile.encoding=ISO-8859-1 or what have you, but it would be nice to
not
>>need to do that.
>>
>>-Andy
>>
>>    
>>
>(omit)
>
>--------------------------------
>
>Toshiaki Kamoshida
>kamoshida.toshiaki@future.co.jp
>
>--------------------------------
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: poi-dev-help@jakarta.apache.org
>
>
>  
>



---------------------------------------------------------------------
To unsubscribe, e-mail: poi-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: poi-dev-help@jakarta.apache.org

Mime
  • Unnamed multipart/mixed (inline, None, 0 bytes)
View raw message