poi-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avik Sengupta <a...@apache.org>
Subject Re: Record Reordering - Print Areas
Date Sat, 14 Dec 2002 05:37:36 GMT
Yep, the there are many range utils within HSSF , with a lot of overlap. Also,
many of the methods in the Range utils arent used at all. All this is indeed a
prime area for refactoring. 

Quoting Danny Mui <danny@muibros.com>:

> I agree with your assessment, I looked at the Range utilities and that 
> drove me batty.  I plan to add more unit tests and make it more reusable 
> (addresses more cleanly written).  The only risks I see with names can 
> be isolated in sheet indexing (afaik), so keeping that shielded should 
> alleviate that concern.  I guess that's a start.
> 
> Andrew C. Oliver wrote:
> 
> > No I just meant that the name code seems brittle and is not IMHO 
> > particularly well written.  I'd like to see it with unit tests, cleanly
> > written, less brittle, etc..  Which I suppose means rewritting it. 
> > -Andy
> >
> > Danny Mui wrote:
> >
> >> I had thoughts of adding name creation methods to the sheets for 
> >> sheet specific regions and restricting the workbook level names to 
> >> global named regions to simplify the API some (and not having to 
> >> write those pesky external reference formulas).
> >>
> >> But these thoughts don't constitute a rewrite.  What did you have in 
> >> mind?
> >>
> >>
> >> Andrew C. Oliver wrote:
> >>
> >>> Sounds reasonable.  I'd like to see names completely rewritten.
> >>>
> >>
> >>
> >>
> >> -- 
> >> To unsubscribe, e-mail:   
> >> <mailto:poi-dev-unsubscribe@jakarta.apache.org>
> >> For additional commands, e-mail: 
> >> <mailto:poi-dev-help@jakarta.apache.org>
> >>
> >>
> >
> >
> >
> >
> > -- 
> > To unsubscribe, e-mail:   <mailto:poi-dev-unsubscribe@jakarta.apache.org>
> > For additional commands, e-mail: <mailto:poi-dev-help@jakarta.apache.org>
> >
> 
> 
> 
> --
> To unsubscribe, e-mail:   <mailto:poi-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:poi-dev-help@jakarta.apache.org>
> 
> 



Mime
View raw message