From commits-return-13598-archive-asf-public=cust-asf.ponee.io@poi.apache.org Fri Jan 8 23:50:13 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 616E5180676 for ; Sat, 9 Jan 2021 00:50:13 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 66374653B2 for ; Fri, 8 Jan 2021 23:50:12 +0000 (UTC) Received: (qmail 84276 invoked by uid 500); 8 Jan 2021 23:50:11 -0000 Mailing-List: contact commits-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@poi.apache.org Delivered-To: mailing list commits@poi.apache.org Received: (qmail 84066 invoked by uid 99); 8 Jan 2021 23:50:10 -0000 Received: from Unknown (HELO svn01-us-east.apache.org) (13.90.137.153) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2021 23:50:10 +0000 Received: from svn01-us-east.apache.org (svn01-us-east.apache.org [127.0.0.1]) by svn01-us-east.apache.org (ASF Mail Server at svn01-us-east.apache.org) with ESMTP id B5AC017D815 for ; Fri, 8 Jan 2021 23:50:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1885281 [4/11] - in /poi/trunk/src: multimodule/poi/test9/ ooxml/testcases/org/apache/poi/xssf/streaming/ ooxml/testcases/org/apache/poi/xssf/usermodel/ testcases/org/apache/poi/ testcases/org/apache/poi/ddf/ testcases/org/apache/poi/hpsf/... Date: Fri, 08 Jan 2021 23:50:06 -0000 To: commits@poi.apache.org From: kiwiwings@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20210108235010.B5AC017D815@svn01-us-east.apache.org> Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestColumnInfoRecordsAggregate.java Fri Jan 8 23:50:02 2021 @@ -30,7 +30,7 @@ import org.junit.jupiter.api.Test; public final class TestColumnInfoRecordsAggregate { @Test - public void testGetRecordSize() { + void testGetRecordSize() { ColumnInfoRecordsAggregate agg = new ColumnInfoRecordsAggregate(); agg.insertColumn(createColInfo(1, 3)); agg.insertColumn(createColInfo(4, 7)); @@ -60,7 +60,7 @@ public final class TestColumnInfoRecords } @Test - public void testGroupColumns_bug45639() { + void testGroupColumns_bug45639() { ColumnInfoRecordsAggregate agg = new ColumnInfoRecordsAggregate(); agg.groupColumnRange( 7, 9, true); agg.groupColumnRange( 4, 12, true); @@ -83,7 +83,7 @@ public final class TestColumnInfoRecords * Check that an inner group remains hidden */ @Test - public void testHiddenAfterExpanding() { + void testHiddenAfterExpanding() { ColumnInfoRecordsAggregate agg = new ColumnInfoRecordsAggregate(); agg.groupColumnRange(1, 15, true); agg.groupColumnRange(4, 12, true); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestFormulaRecordAggregate.java Fri Jan 8 23:50:02 2021 @@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test; public final class TestFormulaRecordAggregate { @Test - public void testBasic() { + void testBasic() { FormulaRecord f = new FormulaRecord(); f.setCachedResultTypeString(); StringRecord s = new StringRecord(); @@ -56,7 +56,7 @@ public final class TestFormulaRecordAggr * the extra record. POI should do the same. */ @Test - public void testExtraStringRecord_bug46213() { + void testExtraStringRecord_bug46213() { FormulaRecord fr = new FormulaRecord(); fr.setValue(2.0); StringRecord sr = new StringRecord(); @@ -71,7 +71,7 @@ public final class TestFormulaRecordAggr } @Test - public void testArrayFormulas() { + void testArrayFormulas() { int rownum = 4; int colnum = 4; Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestPageSettingsBlock.java Fri Jan 8 23:50:02 2021 @@ -62,7 +62,7 @@ import org.junit.jupiter.api.Test; */ public final class TestPageSettingsBlock { @Test - public void testPrintSetup_bug46548() { + void testPrintSetup_bug46548() { // PageSettingBlock in this file contains PLS (sid=x004D) record // followed by ContinueRecord (sid=x003C) HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("ex46548-23133.xls"); @@ -78,7 +78,7 @@ public final class TestPageSettingsBlock * {@link PageSettingsBlock}. */ @Test - public void testHeaderFooter_bug46840() { + void testHeaderFooter_bug46840() { int rowIx = 5; int colIx = 6; @@ -115,7 +115,7 @@ public final class TestPageSettingsBlock * Bug 46953 occurred because POI didn't handle late PSB records properly. */ @Test - public void testLateHeaderFooter_bug46953() { + void testLateHeaderFooter_bug46953() { int rowIx = 5; int colIx = 6; @@ -160,7 +160,7 @@ public final class TestPageSettingsBlock * */ @Test - public void testLateMargins_bug47199() { + void testLateMargins_bug47199() { BottomMarginRecord bottomMargin = new BottomMarginRecord(); bottomMargin.setMargin(0.787F); @@ -194,7 +194,7 @@ public final class TestPageSettingsBlock * was added while fixing bug 47199. All existing POI test samples comply with this requirement. */ @Test - public void testDuplicatePSBRecord_bug47199() { + void testDuplicatePSBRecord_bug47199() { // Hypothetical setup of PSB records which should cause POI to crash org.apache.poi.hssf.record.Record[] recs = { new HeaderRecord("&LSales Figures"), @@ -215,7 +215,7 @@ public final class TestPageSettingsBlock * Excel in this regard. */ @Test - public void testMissingHeaderFooter() { + void testMissingHeaderFooter() { // initialise PSB with some records, but not the header / footer org.apache.poi.hssf.record.Record[] recs = { new HCenterRecord(), @@ -251,7 +251,7 @@ public final class TestPageSettingsBlock * As of June 2009, PLS is still uninterpreted by POI */ @Test - public void testDuplicatePLS_bug47415() { + void testDuplicatePLS_bug47415() { Record plsA = new UnknownRecord(UnknownRecord.PLS_004D, HexRead.readFromString("BA AD F0 0D")); Record plsB = new UnknownRecord(UnknownRecord.PLS_004D, HexRead.readFromString("DE AD BE EF")); Record contB1 = new ContinueRecord(HexRead.readFromString("FE ED")); @@ -277,7 +277,7 @@ public final class TestPageSettingsBlock } @Test - public void testDuplicateHeaderFooter_bug48026() { + void testDuplicateHeaderFooter_bug48026() { org.apache.poi.hssf.record.Record[] recs = { BOFRecord.createSheetBOF(), @@ -349,7 +349,7 @@ public final class TestPageSettingsBlock } @Test - public void testDuplicateHeaderFooterInside_bug48026() { + void testDuplicateHeaderFooterInside_bug48026() { Record[] recs = { BOFRecord.createSheetBOF(), Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestRowRecordsAggregate.java Fri Jan 8 23:50:02 2021 @@ -50,7 +50,7 @@ import org.junit.jupiter.api.Test; public final class TestRowRecordsAggregate { @Test - public void testRowGet() { + void testRowGet() { RowRecordsAggregate rra = new RowRecordsAggregate(); RowRecord rr = new RowRecord(4); rra.insertRow(rr); @@ -70,7 +70,7 @@ public final class TestRowRecordsAggrega * {@link FormulaRecord}s that they apply to (and only once).
*/ @Test - public void testArraysAndTables() throws Exception { + void testArraysAndTables() throws Exception { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("testArraysAndTables.xls")) { final List sheetRecs = new ArrayList<>(); wb.getSheetAt(0).getSheet().visitContainedRecords(sheetRecs::add, 0); @@ -134,7 +134,7 @@ public final class TestRowRecordsAggrega * UnknownRecord} has the potential of being 'continued'. */ @Test - public void testUnknownContinue_bug46280() { + void testUnknownContinue_bug46280() { org.apache.poi.hssf.record.Record[] inRecs = { new RowRecord(0), new NumberRecord(), Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestSharedValueManager.java Fri Jan 8 23:50:02 2021 @@ -63,7 +63,7 @@ public final class TestSharedValueManage * would sometimes associate formulas in the overlapping region with the wrong shared formula */ @Test - public void testPartiallyOverlappingRanges() { + void testPartiallyOverlappingRanges() { for (int attempt=1; attempt < MAX_ATTEMPTS; attempt++) { @@ -87,7 +87,7 @@ public final class TestSharedValueManage * but the symptoms are much uglier - serialization fails with {@link NullPointerException}.
*/ @Test - public void testCompletelyOverlappedRanges() { + void testCompletelyOverlappedRanges() { for (int attempt=1; attempt < MAX_ATTEMPTS; attempt++) { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook(SAMPLE_FILE_NAME); @@ -112,7 +112,7 @@ public final class TestSharedValueManage * These were not explored fully, but seem to be fixed now. */ @Test - public void testRecalculateFormulas47747() { + void testRecalculateFormulas47747() { /* * ex47747-sharedFormula.xls is a heavily cut-down version of the spreadsheet from @@ -141,7 +141,7 @@ public final class TestSharedValueManage } @Test - public void testBug52527() { + void testBug52527() { HSSFWorkbook wb1 = HSSFTestDataSamples.openSampleWorkbook("52527.xls"); HSSFWorkbook wb2 = HSSFTestDataSamples.writeOutAndReadBack(wb1); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/aggregates/TestValueRecordsAggregate.java Fri Jan 8 23:50:02 2021 @@ -69,7 +69,7 @@ public final class TestValueRecordsAggre * as part of the value records */ @Test - public void testSharedFormula() { + void testSharedFormula() { List records = new ArrayList<>(); records.add(new FormulaRecord()); records.add(new SharedFormulaRecord()); @@ -110,7 +110,7 @@ public final class TestValueRecordsAggre } @Test - public void testInsertCell() { + void testInsertCell() { assertEquals(0, getValueRecords().size()); BlankRecord blankRecord = newBlankRecord(); @@ -119,7 +119,7 @@ public final class TestValueRecordsAggre } @Test - public void testRemoveCell() { + void testRemoveCell() { BlankRecord blankRecord1 = newBlankRecord(); valueRecord.insertCell( blankRecord1 ); BlankRecord blankRecord2 = newBlankRecord(); @@ -131,7 +131,7 @@ public final class TestValueRecordsAggre } @Test - public void testGetPhysicalNumberOfCells() { + void testGetPhysicalNumberOfCells() { assertEquals(0, valueRecord.getPhysicalNumberOfCells()); BlankRecord blankRecord1 = newBlankRecord(); valueRecord.insertCell( blankRecord1 ); @@ -141,7 +141,7 @@ public final class TestValueRecordsAggre } @Test - public void testGetFirstCellNum() { + void testGetFirstCellNum() { assertEquals( -1, valueRecord.getFirstCellNum() ); valueRecord.insertCell( newBlankRecord( 2, 2 ) ); assertEquals( 2, valueRecord.getFirstCellNum() ); @@ -154,7 +154,7 @@ public final class TestValueRecordsAggre } @Test - public void testGetLastCellNum() { + void testGetLastCellNum() { assertEquals( -1, valueRecord.getLastCellNum() ); valueRecord.insertCell( newBlankRecord( 2, 2 ) ); assertEquals( 2, valueRecord.getLastCellNum() ); @@ -187,7 +187,7 @@ public final class TestValueRecordsAggre } @Test - public void testSerialize() { + void testSerialize() { byte[] expectedArray = HexRead.readFromString("" + "06 00 16 00 " // Formula + "01 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 " @@ -246,7 +246,7 @@ public final class TestValueRecordsAggre * */ @Test - public void testSpuriousSharedFormulaFlag() throws Exception { + void testSpuriousSharedFormulaFlag() throws Exception { long actualCRC = getFileCRC(HSSFTestDataSamples.openSampleFileStream(ABNORMAL_SHARED_FORMULA_FLAG_TEST_FILE)); long expectedCRC = 2277445406L; @@ -317,7 +317,7 @@ public final class TestValueRecordsAggre } @Test - public void testRemoveNewRow_bug46312() throws IOException { + void testRemoveNewRow_bug46312() throws IOException { // To make bug occur, rowIndex needs to be >= ValueRecordsAggregate.records.length int rowIndex = 30; @@ -341,7 +341,7 @@ public final class TestValueRecordsAggre * are use appropriately */ @Test - public void testMultipleBlanks() { + void testMultipleBlanks() { BlankRecord brA2 = newBlankRecord(0, 1); BlankRecord brB2 = newBlankRecord(1, 1); BlankRecord brC2 = newBlankRecord(2, 1); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/cf/TestCellRange.java Fri Jan 8 23:50:02 2021 @@ -70,7 +70,7 @@ public final class TestCellRange { } @Test - public void testContainsMethod() + void testContainsMethod() { CellRangeAddress [] ranges = sampleRanges; for(int i=0; i!=ranges.length;i++) @@ -96,7 +96,7 @@ public final class TestCellRange { private static final CellRangeAddress box5 = createCR( 1, 3, 1,3); @Test - public void testHasSharedBorderMethod() { + void testHasSharedBorderMethod() { assertFalse(CellRangeUtil.hasExactSharedBorder(col1, col1)); assertFalse(CellRangeUtil.hasExactSharedBorder(col2, col2)); assertTrue(CellRangeUtil.hasExactSharedBorder(col1, col2)); @@ -139,7 +139,7 @@ public final class TestCellRange { } @Test - public void testIntersectMethod() { + void testIntersectMethod() { assertEquals(CellRangeUtil.OVERLAP, CellRangeUtil.intersect(box0, box5)); assertEquals(CellRangeUtil.OVERLAP, CellRangeUtil.intersect(box5, box0)); assertEquals(CellRangeUtil.NO_INTERSECTION, CellRangeUtil.intersect(box1, box4)); @@ -166,7 +166,7 @@ public final class TestCellRange { * =$C:$IV,$B$1:$B$8,$B$10:$B$65536,$A:$A */ @Test - public void testCreate() { + void testCreate() { CellRangeAddress cr = createCR(0, -1, 2, 255); // $C:$IV assertFalse(cr.isFullRowRange(), "isFullRowRange"); @@ -181,7 +181,7 @@ public final class TestCellRange { } @Test - public void testNumberOfCells() { + void testNumberOfCells() { assertEquals(1, oneCell.getNumberOfCells()); assertEquals(100, box9x9.getNumberOfCells()); assertEquals(121, box10to20c.getNumberOfCells()); @@ -189,7 +189,7 @@ public final class TestCellRange { @SuppressWarnings("RedundantArrayCreation") @Test - public void testMergeCellRanges() { + void testMergeCellRanges() { // no result on empty cellRangeTest(new String[]{ }); @@ -222,13 +222,13 @@ public final class TestCellRange { @SuppressWarnings("RedundantArrayCreation") @Test - public void testMergeCellRanges55380() { + void testMergeCellRanges55380() { cellRangeTest(new String[]{"C1:D2", "C2:C3"}, new String[] {"C1:D2", "C2:C3"}); cellRangeTest(new String[]{"A1:C3", "B2:D2"}, new String[] {"A1:C3", "B2:D2"}); cellRangeTest(new String[]{"C9:D30", "C7:C31"}, new String[] {"C9:D30", "C7:C31"}); } -// public void testResolveRangeOverlap() { +// void testResolveRangeOverlap() { // resolveRangeOverlapTest("C1:D2", "C2:C3"); // } @@ -258,7 +258,7 @@ public final class TestCellRange { } @Test - public void testValueOf() { + void testValueOf() { CellRangeAddress cr1 = CellRangeAddress.valueOf("A1:B1"); assertEquals(0, cr1.getFirstColumn()); assertEquals(0, cr1.getFirstRow()); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaFormatRecord.java Fri Jan 8 23:50:02 2021 @@ -43,7 +43,7 @@ public final class TestAreaFormatRecord }; @Test - public void testLoad() { + void testLoad() { AreaFormatRecord record = new AreaFormatRecord(TestcaseRecordInputStream.create(0x100a, data)); assertEquals( 0xFFFFFF, record.getForegroundColor()); assertEquals( 0x000000, record.getBackgroundColor()); @@ -60,7 +60,7 @@ public final class TestAreaFormatRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { AreaFormatRecord record = new AreaFormatRecord(); record.setForegroundColor( 0xFFFFFF ); record.setBackgroundColor( 0x000000 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAreaRecord.java Fri Jan 8 23:50:02 2021 @@ -37,7 +37,7 @@ public final class TestAreaRecord { }; @Test - public void testLoad() { + void testLoad() { AreaRecord record = new AreaRecord(TestcaseRecordInputStream.create(0x101A, data)); assertEquals( 2, record.getFormatFlags()); @@ -50,7 +50,7 @@ public final class TestAreaRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { AreaRecord record = new AreaRecord(); record.setStacked( false ); record.setDisplayAsPercentage( true ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisLineFormatRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestAxisLineFormatRec }; @Test - public void testLoad() { + void testLoad() { AxisLineFormatRecord record = new AxisLineFormatRecord(TestcaseRecordInputStream.create(0x1021, data)); assertEquals( AxisLineFormatRecord.AXIS_TYPE_MAJOR_GRID_LINE, record.getAxisType()); @@ -44,7 +44,7 @@ public final class TestAxisLineFormatRec @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { AxisLineFormatRecord record = new AxisLineFormatRecord(); record.setAxisType( AxisLineFormatRecord.AXIS_TYPE_MAJOR_GRID_LINE ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisOptionsRecord.java Fri Jan 8 23:50:02 2021 @@ -40,7 +40,7 @@ public final class TestAxisOptionsRecord }; @Test - public void testLoad() { + void testLoad() { AxisOptionsRecord record = new AxisOptionsRecord(TestcaseRecordInputStream.create(0x1062, data)); assertEquals( 0, record.getMinimumCategory()); assertEquals( 0, record.getMaximumCategory()); @@ -65,7 +65,7 @@ public final class TestAxisOptionsRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { AxisOptionsRecord record = new AxisOptionsRecord(); record.setMinimumCategory( (short)0 ); record.setMaximumCategory( (short)0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisParentRecord.java Fri Jan 8 23:50:02 2021 @@ -39,7 +39,7 @@ public final class TestAxisParentRecord }; @Test - public void testLoad() { + void testLoad() { AxisParentRecord record = new AxisParentRecord(TestcaseRecordInputStream.create(0x1041, data)); assertEquals( AxisParentRecord.AXIS_TYPE_MAIN, record.getAxisType()); assertEquals( 0x021d, record.getX()); @@ -52,7 +52,7 @@ public final class TestAxisParentRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { AxisParentRecord record = new AxisParentRecord(); record.setAxisType( AxisParentRecord.AXIS_TYPE_MAIN ); record.setX( 0x021d ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisRecord.java Fri Jan 8 23:50:02 2021 @@ -39,7 +39,7 @@ public final class TestAxisRecord { }; @Test - public void testLoad() { + void testLoad() { AxisRecord record = new AxisRecord(TestcaseRecordInputStream.create(0x101d, data)); assertEquals( AxisRecord.AXIS_TYPE_CATEGORY_OR_X_AXIS, record.getAxisType()); assertEquals( 0, record.getReserved1()); @@ -52,7 +52,7 @@ public final class TestAxisRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { AxisRecord record = new AxisRecord(); record.setAxisType( AxisRecord.AXIS_TYPE_CATEGORY_OR_X_AXIS ); record.setReserved1( 0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestAxisUsedRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestAxisUsedRecord { }; @Test - public void testLoad() { + void testLoad() { AxisUsedRecord record = new AxisUsedRecord(TestcaseRecordInputStream.create(0x1046, data)); assertEquals( 1, record.getNumAxis()); @@ -44,7 +44,7 @@ public final class TestAxisUsedRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { AxisUsedRecord record = new AxisUsedRecord(); record.setNumAxis( (short)1 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestBarRecord.java Fri Jan 8 23:50:02 2021 @@ -38,7 +38,7 @@ public final class TestBarRecord { }; @Test - public void testLoad() { + void testLoad() { BarRecord record = new BarRecord(TestcaseRecordInputStream.create(0x1017, data)); assertEquals( 0, record.getBarSpace()); assertEquals( 0x96, record.getCategorySpace()); @@ -53,7 +53,7 @@ public final class TestBarRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { BarRecord record = new BarRecord(); record.setBarSpace( (short)0 ); record.setCategorySpace( (short)0x96 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestCategorySeriesAxisRecord.java Fri Jan 8 23:50:02 2021 @@ -40,7 +40,7 @@ public final class TestCategorySeriesAxi }; @Test - public void testLoad() { + void testLoad() { CategorySeriesAxisRecord record = new CategorySeriesAxisRecord(TestcaseRecordInputStream.create(0x1020, data)); assertEquals( 1, record.getCrossingPoint()); assertEquals( 1, record.getLabelFrequency()); @@ -55,7 +55,7 @@ public final class TestCategorySeriesAxi @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { CategorySeriesAxisRecord record = new CategorySeriesAxisRecord(); record.setCrossingPoint( (short)1 ); record.setLabelFrequency( (short)1 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartFormatRecord.java Fri Jan 8 23:50:02 2021 @@ -45,7 +45,7 @@ public final class TestChartFormatRecord * The correct size of a {@link ChartFormatRecord} is 20 bytes (not including header). */ @Test - public void testLoad() { + void testLoad() { RecordInputStream in = TestcaseRecordInputStream.create(data); ChartFormatRecord record = new ChartFormatRecord(in); assertNotEquals(2, in.remaining(), "Identified bug 44693d"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartRecord.java Fri Jan 8 23:50:02 2021 @@ -38,7 +38,7 @@ public final class TestChartRecord { }; @Test - public void testLoad() { + void testLoad() { ChartRecord record = new ChartRecord(TestcaseRecordInputStream.create(0x1002, data)); assertEquals( 0, record.getX()); assertEquals( 0, record.getY()); @@ -50,7 +50,7 @@ public final class TestChartRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { ChartRecord record = new ChartRecord(); record.setX( 0 ); record.setY( 0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestChartTitleFormatRecord.java Fri Jan 8 23:50:02 2021 @@ -34,7 +34,7 @@ import org.junit.jupiter.api.Test; public final class TestChartTitleFormatRecord { @Test - public void testRecord() throws Exception { + void testRecord() throws Exception { POIFSFileSystem fs = new POIFSFileSystem( HSSFTestDataSamples.getSampleFile("WithFormattedGraphTitle.xls")); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDatRecord.java Fri Jan 8 23:50:02 2021 @@ -37,7 +37,7 @@ public final class TestDatRecord { }; @Test - public void testLoad() { + void testLoad() { DatRecord record = new DatRecord(TestcaseRecordInputStream.create(0x1063, data)); assertEquals( 0xD, record.getOptions()); assertTrue(record.isHorizontalBorder()); @@ -50,7 +50,7 @@ public final class TestDatRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { DatRecord record = new DatRecord(); record.setHorizontalBorder( true ); record.setVerticalBorder( false ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDataFormatRecord.java Fri Jan 8 23:50:02 2021 @@ -39,7 +39,7 @@ public final class TestDataFormatRecord }; @Test - public void testLoad() { + void testLoad() { DataFormatRecord record = new DataFormatRecord(TestcaseRecordInputStream.create(0x1006, data)); assertEquals( (short)0xFFFF, record.getPointNumber()); assertEquals( 0, record.getSeriesIndex()); @@ -52,7 +52,7 @@ public final class TestDataFormatRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { DataFormatRecord record = new DataFormatRecord(); record.setPointNumber( (short)0xFFFF ); record.setSeriesIndex( (short)0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestDefaultDataLabelTextPropertiesRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestDefaultDataLabelT }; @Test - public void testLoad() { + void testLoad() { DefaultDataLabelTextPropertiesRecord record = new DefaultDataLabelTextPropertiesRecord(TestcaseRecordInputStream.create(0x1024, data)); assertEquals( 2, record.getCategoryDataType()); @@ -45,7 +45,7 @@ public final class TestDefaultDataLabelT @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { DefaultDataLabelTextPropertiesRecord record = new DefaultDataLabelTextPropertiesRecord(); record.setCategoryDataType( (short)2 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontBasisRecord.java Fri Jan 8 23:50:02 2021 @@ -39,7 +39,7 @@ public final class TestFontBasisRecord { }; @Test - public void testLoad() { + void testLoad() { FontBasisRecord record = new FontBasisRecord(TestcaseRecordInputStream.create(0x1060, data)); assertEquals( 0x1a28, record.getXBasis()); assertEquals( 0x0f9c, record.getYBasis()); @@ -52,7 +52,7 @@ public final class TestFontBasisRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { FontBasisRecord record = new FontBasisRecord(); record.setXBasis( (short)0x1a28 ); record.setYBasis( (short)0x0f9c ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFontIndexRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestFontIndexRecord { }; @Test - public void testLoad() { + void testLoad() { FontIndexRecord record = new FontIndexRecord(TestcaseRecordInputStream.create(0x1026, data)); assertEquals( 5, record.getFontIndex()); @@ -45,7 +45,7 @@ public final class TestFontIndexRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { FontIndexRecord record = new FontIndexRecord(); record.setFontIndex( (short)5 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestFrameRecord.java Fri Jan 8 23:50:02 2021 @@ -38,7 +38,7 @@ public final class TestFrameRecord { }; @Test - public void testLoad() { + void testLoad() { FrameRecord record = new FrameRecord(TestcaseRecordInputStream.create(0x1032, data)); assertEquals( FrameRecord.BORDER_TYPE_REGULAR, record.getBorderType()); assertEquals( 2, record.getOptions()); @@ -50,7 +50,7 @@ public final class TestFrameRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { FrameRecord record = new FrameRecord(); record.setBorderType( FrameRecord.BORDER_TYPE_REGULAR ); record.setOptions( (short)2 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLegendRecord.java Fri Jan 8 23:50:02 2021 @@ -36,7 +36,7 @@ public final class TestLegendRecord { (byte) 0x01, (byte) 0x1F, (byte) 0x00 }; @Test - public void testLoad() { + void testLoad() { LegendRecord record = new LegendRecord(TestcaseRecordInputStream.create(0x1015, data)); assertEquals(0xe76, record.getXAxisUpperLeft()); @@ -64,7 +64,7 @@ public final class TestLegendRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { LegendRecord record = new LegendRecord(); record.setXAxisUpperLeft(0xe76); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLineFormatRecord.java Fri Jan 8 23:50:02 2021 @@ -41,7 +41,7 @@ public final class TestLineFormatRecord }; @Test - public void testLoad() { + void testLoad() { LineFormatRecord record = new LineFormatRecord(TestcaseRecordInputStream.create(0x1007, data)); assertEquals( 0, record.getLineColor()); assertEquals( 0, record.getLinePattern()); @@ -56,7 +56,7 @@ public final class TestLineFormatRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { LineFormatRecord record = new LineFormatRecord(); record.setLineColor( 0 ); record.setLinePattern( (short)0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestLinkedDataRecord.java Fri Jan 8 23:50:02 2021 @@ -158,7 +158,7 @@ recordid = 0x1051, size =8 }; @Test - public void testLoad() { + void testLoad() { LinkedDataRecord record = new LinkedDataRecord(TestcaseRecordInputStream.create(0x1051, data)); assertEquals( LinkedDataRecord.LINK_TYPE_VALUES, record.getLinkType()); assertEquals( LinkedDataRecord.REFERENCE_TYPE_WORKSHEET, record.getReferenceType()); @@ -177,7 +177,7 @@ recordid = 0x1051, size =8 @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { LinkedDataRecord record = new LinkedDataRecord(); record.setLinkType( LinkedDataRecord.LINK_TYPE_VALUES ); record.setReferenceType( LinkedDataRecord.REFERENCE_TYPE_WORKSHEET ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestNumberFormatIndexRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestNumberFormatIndex }; @Test - public void testLoad() { + void testLoad() { NumberFormatIndexRecord record = new NumberFormatIndexRecord(TestcaseRecordInputStream.create(0x104e, data)); assertEquals( 5, record.getFormatIndex()); @@ -44,7 +44,7 @@ public final class TestNumberFormatIndex @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { NumberFormatIndexRecord record = new NumberFormatIndexRecord(); record.setFormatIndex( (short)5 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestObjectLinkRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestObjectLinkRecord }; @Test - public void testLoad() { + void testLoad() { ObjectLinkRecord record = new ObjectLinkRecord(TestcaseRecordInputStream.create(0x1027, data)); assertEquals( (short)3, record.getAnchorId()); @@ -47,7 +47,7 @@ public final class TestObjectLinkRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { ObjectLinkRecord record = new ObjectLinkRecord(); record.setAnchorId( (short)3 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotAreaRecord.java Fri Jan 8 23:50:02 2021 @@ -34,14 +34,14 @@ public final class TestPlotAreaRecord { }; @Test - public void testLoad() { + void testLoad() { PlotAreaRecord record = new PlotAreaRecord(TestcaseRecordInputStream.create(0x1035, data)); assertEquals( 4, record.getRecordSize() ); } @Test - public void testStore() { + void testStore() { PlotAreaRecord record = new PlotAreaRecord(); byte [] recordBytes = record.serialize(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestPlotGrowthRecord.java Fri Jan 8 23:50:02 2021 @@ -36,7 +36,7 @@ public final class TestPlotGrowthRecord }; @Test - public void testLoad() { + void testLoad() { PlotGrowthRecord record = new PlotGrowthRecord(TestcaseRecordInputStream.create(0x1064, data)); assertEquals( 65536, record.getHorizontalScale()); @@ -47,7 +47,7 @@ public final class TestPlotGrowthRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { PlotGrowthRecord record = new PlotGrowthRecord(); record.setHorizontalScale( 65536 ); record.setVerticalScale( 65536 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesChartGroupIndexRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestSeriesChartGroupI }; @Test - public void testLoad() { + void testLoad() { SeriesChartGroupIndexRecord record = new SeriesChartGroupIndexRecord(TestcaseRecordInputStream.create(0x1045, data)); assertEquals( 0, record.getChartGroupIndex()); @@ -44,7 +44,7 @@ public final class TestSeriesChartGroupI @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { SeriesChartGroupIndexRecord record = new SeriesChartGroupIndexRecord(); record.setChartGroupIndex( (short)0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesIndexRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestSeriesIndexRecord }; @Test - public void testLoad() { + void testLoad() { SeriesIndexRecord record = new SeriesIndexRecord(TestcaseRecordInputStream.create(0x1065, data)); assertEquals( (short)3, record.getIndex()); @@ -44,7 +44,7 @@ public final class TestSeriesIndexRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { SeriesIndexRecord record = new SeriesIndexRecord(); record.setIndex( (short)3 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesLabelsRecord.java Fri Jan 8 23:50:02 2021 @@ -37,7 +37,7 @@ public final class TestSeriesLabelsRecor }; @Test - public void testLoad() { + void testLoad() { SeriesLabelsRecord record = new SeriesLabelsRecord(TestcaseRecordInputStream.create(0x100c, data)); assertEquals( 3, record.getFormatFlags()); assertTrue(record.isShowActual()); @@ -52,7 +52,7 @@ public final class TestSeriesLabelsRecor @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { SeriesLabelsRecord record = new SeriesLabelsRecord(); record.setShowActual( true ); record.setShowPercent( true ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesListRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestSeriesListRecord }; @Test - public void testLoad() { + void testLoad() { SeriesListRecord record = new SeriesListRecord(TestcaseRecordInputStream.create(0x1016, data)); assertEquals( (short)0x2001, record.getSeriesNumbers()[0]); @@ -47,7 +47,7 @@ public final class TestSeriesListRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { SeriesListRecord record = new SeriesListRecord(new short[] { (short)0x2001, (short)0xf0ff } ); byte [] recordBytes = record.serialize(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesRecord.java Fri Jan 8 23:50:02 2021 @@ -40,7 +40,7 @@ public final class TestSeriesRecord { }; @Test - public void testLoad() { + void testLoad() { SeriesRecord record = new SeriesRecord(TestcaseRecordInputStream.create(0x1003, data)); assertEquals( SeriesRecord.CATEGORY_DATA_TYPE_NUMERIC, record.getCategoryDataType()); assertEquals( SeriesRecord.VALUES_DATA_TYPE_NUMERIC, record.getValuesDataType()); @@ -55,7 +55,7 @@ public final class TestSeriesRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { SeriesRecord record = new SeriesRecord(); record.setCategoryDataType( SeriesRecord.CATEGORY_DATA_TYPE_NUMERIC ); record.setValuesDataType( SeriesRecord.VALUES_DATA_TYPE_NUMERIC ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSeriesTextRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestSeriesTextRecord .readFromString("00 00 0C 00 56 61 6C 75 65 20 4E 75 6D 62 65 72"); @Test - public void testLoad() { + void testLoad() { SeriesTextRecord record = new SeriesTextRecord(TestcaseRecordInputStream.create(0x100d, SIMPLE_DATA)); assertEquals((short) 0, record.getId()); @@ -46,7 +46,7 @@ public final class TestSeriesTextRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { SeriesTextRecord record = new SeriesTextRecord(); record.setId(0); @@ -57,7 +57,7 @@ public final class TestSeriesTextRecord } @Test - public void testReserializeLongTitle() { + void testReserializeLongTitle() { // Hex dump from bug 45784 attachment 22560 streamOffset=0x0CD1 byte[] data = HexRead.readFromString( "00 00, " Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestSheetPropertiesRecord.java Fri Jan 8 23:50:02 2021 @@ -40,7 +40,7 @@ public final class TestSheetPropertiesRe }; @Test - public void testLoad() { + void testLoad() { RecordInputStream in = TestcaseRecordInputStream.create(0x1044, data); SheetPropertiesRecord record = new SheetPropertiesRecord(in); assertNotEquals(1, in.remaining(), "Identified bug 44693c"); @@ -58,7 +58,7 @@ public final class TestSheetPropertiesRe @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { SheetPropertiesRecord record = new SheetPropertiesRecord(); record.setChartTypeManuallyFormatted( false ); record.setPlotVisibleOnly( true ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTextRecord.java Fri Jan 8 23:50:02 2021 @@ -48,7 +48,7 @@ public final class TestTextRecord { }; @Test - public void testLoad() { + void testLoad() { TextRecord record = new TextRecord(TestcaseRecordInputStream.create(0x1025, data)); assertEquals( TextRecord.HORIZONTAL_ALIGNMENT_CENTER, record.getHorizontalAlignment()); assertEquals( TextRecord.VERTICAL_ALIGNMENT_CENTER, record.getVerticalAlignment()); @@ -83,7 +83,7 @@ public final class TestTextRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { TextRecord record = new TextRecord(); record.setHorizontalAlignment( TextRecord.HORIZONTAL_ALIGNMENT_CENTER ); record.setVerticalAlignment( TextRecord.VERTICAL_ALIGNMENT_CENTER ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestTickRecord.java Fri Jan 8 23:50:02 2021 @@ -42,7 +42,7 @@ public final class TestTickRecord { }; @Test - public void testLoad() { + void testLoad() { TickRecord record = new TickRecord(TestcaseRecordInputStream.create(0x101e, data)); assertEquals( (byte)2, record.getMajorTickType()); assertEquals( (byte)0, record.getMinorTickType()); @@ -65,7 +65,7 @@ public final class TestTickRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { TickRecord record = new TickRecord(); record.setMajorTickType( (byte)2 ); record.setMinorTickType( (byte)0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestUnitsRecord.java Fri Jan 8 23:50:02 2021 @@ -35,7 +35,7 @@ public final class TestUnitsRecord { }; @Test - public void testLoad() { + void testLoad() { UnitsRecord record = new UnitsRecord(TestcaseRecordInputStream.create(0x1001, data)); assertEquals( 0, record.getUnits()); @@ -45,7 +45,7 @@ public final class TestUnitsRecord { @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { UnitsRecord record = new UnitsRecord(); record.setUnits( (short)0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/chart/TestValueRangeRecord.java Fri Jan 8 23:50:02 2021 @@ -42,7 +42,7 @@ public final class TestValueRangeRecord }; @Test - public void testLoad() { + void testLoad() { ValueRangeRecord record = new ValueRangeRecord(TestcaseRecordInputStream.create(0x101f, data)); assertEquals( 0.0, record.getMinimumAxisValue(), 0.001); @@ -66,7 +66,7 @@ public final class TestValueRangeRecord @SuppressWarnings("squid:S2699") @Test - public void testStore() { + void testStore() { ValueRangeRecord record = new ValueRangeRecord(); record.setMinimumAxisValue( 0 ); record.setMaximumAxisValue( 0 ); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestExtendedPivotTableViewFieldsRecord.java Fri Jan 8 23:50:02 2021 @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; public final class TestExtendedPivotTableViewFieldsRecord { @Test - public void testSubNameNotPresent_bug46693() { + void testSubNameNotPresent_bug46693() { // This data came from attachment 23347 of bug 46693 at offset 0xAA43 byte[] data = HexRead.readFromString( "00 01 14 00" + // BIFF header @@ -46,7 +46,7 @@ public final class TestExtendedPivotTabl @SuppressWarnings("squid:S2699") @Test - public void testOlderFormat_bug46918() { + void testOlderFormat_bug46918() { // There are 10 SXVDEX records in the file (not uploaded) that originated bugzilla 46918 // They all had the following hex encoding: byte[] data = HexRead.readFromString("00 01 0A 00 1E 14 00 0A FF FF FF FF 00 00"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestPageItemRecord.java Fri Jan 8 23:50:02 2021 @@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test; */ public final class TestPageItemRecord { @Test - public void testMoreThanOneInfoItem_bug46917() { + void testMoreThanOneInfoItem_bug46917() { byte[] data = HexRead.readFromString("01 02 03 04 05 06 07 08 09 0A 0B 0C"); RecordInputStream in = TestcaseRecordInputStream.create(PageItemRecord.sid, data); PageItemRecord rec = new PageItemRecord(in); @@ -43,7 +43,7 @@ public final class TestPageItemRecord { } @Test - public void testSerialize() { + void testSerialize() { confirmSerialize("01 02 03 04 05 06"); confirmSerialize("01 02 03 04 05 06 07 08 09 0A 0B 0C"); confirmSerialize("01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F 10 11 12"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/record/pivot/TestViewFieldsRecord.java Fri Jan 8 23:50:02 2021 @@ -33,7 +33,7 @@ import org.junit.jupiter.api.Test; public final class TestViewFieldsRecord { @Test - public void testUnicodeFlag_bug46693() { + void testUnicodeFlag_bug46693() { byte[] data = HexRead.readFromString("01 00 01 00 01 00 04 00 05 00 00 6D 61 72 63 6F"); RecordInputStream in = TestcaseRecordInputStream.create(ViewFieldsRecord.sid, data); ViewFieldsRecord rec = new ViewFieldsRecord(in); @@ -43,7 +43,7 @@ public final class TestViewFieldsRecord } @Test - public void testSerialize() { + void testSerialize() { // This hex data was produced by changing the 'Custom Name' property, // available under 'Field Settings' from the 'PivotTable Field List' (Excel 2007) confirmSerialize("00 00 01 00 01 00 00 00 FF FF"); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBug42464.java Fri Jan 8 23:50:02 2021 @@ -37,14 +37,14 @@ import org.junit.jupiter.api.Test; public final class TestBug42464 { @Test - public void testOKFile() throws Exception { + void testOKFile() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("42464-ExpPtg-ok.xls"); process(wb); wb.close(); } @Test - public void testExpSharedBadFile() throws Exception { + void testExpSharedBadFile() throws Exception { HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("42464-ExpPtg-bad.xls"); process(wb); wb.close(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java Fri Jan 8 23:50:02 2021 @@ -798,7 +798,7 @@ public final class TestBugs extends Base */ @Disabled("For now, blows up with an exception from ExtPtg") @Test - public void test43623() throws Exception { + void test43623() throws Exception { try (HSSFWorkbook wb1 = openSampleWorkbook("43623.xls")) { assertEquals(1, wb1.getNumberOfSheets()); @@ -1855,7 +1855,7 @@ public final class TestBugs extends Base * eg =SUM($Sheet2.A1:$Sheet3.A1) */ @Test - public void test48703() throws Exception { + void test48703() throws Exception { try (HSSFWorkbook wb = openSampleWorkbook("48703.xls")) { assertEquals(3, wb.getNumberOfSheets()); @@ -2266,7 +2266,7 @@ public final class TestBugs extends Base } @Test - public void test57163() throws IOException { + void test57163() throws IOException { simpleTest("57163.xls", wb -> { while (wb.getNumberOfSheets() > 1) { wb.removeSheetAt(1); @@ -2275,7 +2275,7 @@ public final class TestBugs extends Base } @Test - public void test48043() throws IOException { + void test48043() throws IOException { try (HSSFWorkbook wb = openSampleWorkbook("56325a.xls")) { wb.removeSheetAt(2); @@ -2301,7 +2301,7 @@ public final class TestBugs extends Base } @Test - public void test57925() throws IOException { + void test57925() throws IOException { try (Workbook wb = openSampleWorkbook("57925.xls")) { wb.getCreationHelper().createFormulaEvaluator().evaluateAll(); DataFormatter df = new DataFormatter(); @@ -2316,7 +2316,7 @@ public final class TestBugs extends Base } @Test - public void test46515() throws IOException { + void test46515() throws IOException { try (Workbook wb = openSampleWorkbook("46515.xls")) { // Get structure from webservice @@ -2349,7 +2349,7 @@ public final class TestBugs extends Base } @Test - public void test55668() throws IOException { + void test55668() throws IOException { try (Workbook wb = openSampleWorkbook("55668.xls")) { Sheet sheet = wb.getSheetAt(0); @@ -2369,7 +2369,7 @@ public final class TestBugs extends Base } @Test - public void test55982() throws IOException { + void test55982() throws IOException { simpleTest("55982.xls", wb -> assertNotNull(wb.cloneSheet(1))); } @@ -2377,7 +2377,7 @@ public final class TestBugs extends Base * Test generator of ids for the CommonObjectDataSubRecord record. */ @Test - public void test51332() { + void test51332() { HSSFClientAnchor anchor = new HSSFClientAnchor(); HSSFSimpleShape shape; CommonObjectDataSubRecord cmo; @@ -2401,7 +2401,7 @@ public final class TestBugs extends Base // As of POI 3.15 beta 2, LibreOffice does not display the diagonal border while it does display the bottom border // I have not checked Excel to know if this is a LibreOffice or a POI problem. @Test - public void test53564() throws IOException { + void test53564() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet("Page 1"); final short BLUE = 30; @@ -2438,7 +2438,7 @@ public final class TestBugs extends Base } @Test - public void test61287() throws IOException { + void test61287() throws IOException { try (HSSFWorkbook wb = openSampleWorkbook("61287.xls"); ExcelExtractor ex = new ExcelExtractor(wb)) { String text = ex.getText(); @@ -2447,7 +2447,7 @@ public final class TestBugs extends Base } @Test - public void test61300() throws Exception { + void test61300() throws Exception { try (POIFSFileSystem poifs = new POIFSFileSystem(HSSFTestDataSamples.openSampleFileStream("61300.xls"))) { DocumentEntry entry = @@ -2462,7 +2462,7 @@ public final class TestBugs extends Base } @Test - public void test51262() throws IOException { + void test51262() throws IOException { try (HSSFWorkbook wb = openSampleWorkbook("51262.xls")) { Sheet sheet = wb.getSheetAt(0); Row row = sheet.getRow(2); @@ -2490,7 +2490,7 @@ public final class TestBugs extends Base } @Test - public void test60460() throws IOException { + void test60460() throws IOException { try (final Workbook wb = openSampleWorkbook("60460.xls")) { assertEquals(2, wb.getAllNames().size()); @@ -2507,7 +2507,7 @@ public final class TestBugs extends Base } @Test - public void test63819() throws IOException { + void test63819() throws IOException { LocaleUtil.setUserLocale(Locale.UK); try { simpleTest("63819.xls", null); @@ -2520,7 +2520,7 @@ public final class TestBugs extends Base * Test that VALUE behaves properly as array function and its result is handled by aggregate function */ @Test - public void testValueAsArrayFunction() throws IOException { + void testValueAsArrayFunction() throws IOException { try (final Workbook wb = openSampleWorkbook("TestValueAsArrayFunction.xls")) { wb.getCreationHelper().createFormulaEvaluator().evaluateAll(); Sheet sheet = wb.getSheetAt(0); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java Fri Jan 8 23:50:02 2021 @@ -72,7 +72,7 @@ public final class TestCellStyle { * */ @Test - public void testWriteSheetFont() throws IOException{ + void testWriteSheetFont() throws IOException{ File file = TempFile.createTempFile("testWriteSheetFont", ".xls"); try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); @@ -112,7 +112,7 @@ public final class TestCellStyle { * Tests that is creating a file with a date or an calendar works correctly. */ @Test - public void testDataStyle() throws IOException { + void testDataStyle() throws IOException { File file = TempFile.createTempFile("testWriteSheetStyleDate", ".xls"); try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); @@ -144,7 +144,7 @@ public final class TestCellStyle { } @Test - public void testHashEquals() throws IOException { + void testHashEquals() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); HSSFCellStyle cs1 = wb.createCellStyle(); @@ -185,7 +185,7 @@ public final class TestCellStyle { * */ @Test - public void testWriteSheetStyle() throws IOException { + void testWriteSheetStyle() throws IOException { File file = TempFile.createTempFile("testWriteSheetStyle", ".xls"); try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet s = wb.createSheet(); @@ -233,7 +233,7 @@ public final class TestCellStyle { * HSSFWorkbook */ @Test - public void testCloneStyleSameWB() throws IOException { + void testCloneStyleSameWB() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFFont fnt = wb.createFont(); fnt.setFontName("TestingFont"); @@ -266,7 +266,7 @@ public final class TestCellStyle { * two different HSSFWorkbooks */ @Test - public void testCloneStyleDiffWB() throws IOException { + void testCloneStyleDiffWB() throws IOException { try (HSSFWorkbook wbOrig = new HSSFWorkbook()) { HSSFFont fnt = wbOrig.createFont(); @@ -308,7 +308,7 @@ public final class TestCellStyle { } @Test - public void testStyleNames() throws IOException { + void testStyleNames() throws IOException { try (HSSFWorkbook wb = openSample("WithExtendedStyles.xls")) { HSSFSheet s = wb.getSheetAt(0); HSSFCell c1 = s.getRow(0).getCell(0); @@ -362,7 +362,7 @@ public final class TestCellStyle { } @Test - public void testGetSetBorderHair() throws IOException { + void testGetSetBorderHair() throws IOException { BorderStyle[] bs = { HAIR, DOTTED, DASH_DOT_DOT, DASHED, THIN, MEDIUM_DASH_DOT_DOT, SLANTED_DASH_DOT, MEDIUM_DASH_DOT, MEDIUM_DASHED, MEDIUM, THICK, DOUBLE @@ -378,7 +378,7 @@ public final class TestCellStyle { } @Test - public void testShrinkToFit() throws IOException { + void testShrinkToFit() throws IOException { // Existing file try (HSSFWorkbook wb1 = openSample("ShrinkToFit.xls")) { HSSFSheet s = wb1.getSheetAt(0); @@ -412,7 +412,7 @@ public final class TestCellStyle { } @Test - public void test56563() { + void test56563() { Stream.of("56563a.xls", "56563b.xls").parallel().forEach(fileName -> assertDoesNotThrow(() -> { Random rand = new Random(); for(int i=0; i<10; i++) { @@ -434,7 +434,7 @@ public final class TestCellStyle { } @Test - public void test56959() throws IOException { + void test56959() throws IOException { try (Workbook wb = new HSSFWorkbook()) { Sheet sheet = wb.createSheet("somesheet"); @@ -469,7 +469,7 @@ public final class TestCellStyle { @Test - public void test58043() throws IOException { + void test58043() throws IOException { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFCellStyle cellStyle = wb.createCellStyle(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCloneSheet.java Fri Jan 8 23:50:02 2021 @@ -45,7 +45,7 @@ public final class TestCloneSheet extend } @Test - public void testCloneSheetWithoutDrawings(){ + void testCloneSheetWithoutDrawings(){ HSSFWorkbook b = new HSSFWorkbook(); HSSFSheet s = b.createSheet("Test"); HSSFSheet s2 = s.cloneSheet(b); @@ -56,7 +56,7 @@ public final class TestCloneSheet extend } @Test - public void testCloneSheetWithEmptyDrawingAggregate(){ + void testCloneSheetWithEmptyDrawingAggregate(){ HSSFWorkbook b = new HSSFWorkbook(); HSSFSheet s = b.createSheet("Test"); HSSFPatriarch patriarch = s.createDrawingPatriarch(); @@ -92,7 +92,7 @@ public final class TestCloneSheet extend } @Test - public void testCloneComment() throws IOException { + void testCloneComment() throws IOException { HSSFWorkbook wb = new HSSFWorkbook(); HSSFSheet sh = wb.createSheet(); HSSFPatriarch p = sh.createDrawingPatriarch(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestDataValidation.java Fri Jan 8 23:50:02 2021 @@ -114,7 +114,7 @@ public final class TestDataValidation ex } @Test - public void testAddToExistingSheet() throws Exception { + void testAddToExistingSheet() throws Exception { // dvEmpty.xls is a simple one sheet workbook. With a DataValidations header record but no // DataValidations. It's important that the example has one SHEETPROTECTION record. @@ -191,7 +191,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsAny() throws Exception { + void testGetDataValidationsAny() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); @@ -236,7 +236,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsIntegerFormula() throws Exception { + void testGetDataValidationsIntegerFormula() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); @@ -263,7 +263,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsIntegerValue() throws Exception { + void testGetDataValidationsIntegerValue() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); @@ -290,7 +290,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsDecimal() throws Exception { + void testGetDataValidationsDecimal() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); @@ -317,7 +317,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsDate() throws Exception { + void testGetDataValidationsDate() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); @@ -344,7 +344,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsListExplicit() throws Exception { + void testGetDataValidationsListExplicit() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); @@ -378,7 +378,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsListFormula() throws Exception { + void testGetDataValidationsListFormula() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); @@ -407,7 +407,7 @@ public final class TestDataValidation ex } @Test - public void testGetDataValidationsFormula() throws Exception { + void testGetDataValidationsFormula() throws Exception { try (HSSFWorkbook wb = new HSSFWorkbook()) { HSSFSheet sheet = wb.createSheet(); List list = sheet.getDataValidations(); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEmbeddedObjects.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEmbeddedObjects.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEmbeddedObjects.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEmbeddedObjects.java Fri Jan 8 23:50:02 2021 @@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test; */ public class TestEmbeddedObjects { @Test - public void testReadExistingObject() throws IOException { + void testReadExistingObject() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("drawings.xls")) { List list = wb.getAllEmbeddedObjects(); assertEquals(list.size(), 1); @@ -47,7 +47,7 @@ public class TestEmbeddedObjects { * See https://github.com/apache/poi/pull/2 */ @Test - public void testReadNestedObject() throws IOException { + void testReadNestedObject() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("WithCheckBoxes.xls")) { List list = wb.getAllEmbeddedObjects(); assertEquals(list.size(), 1); @@ -62,7 +62,7 @@ public class TestEmbeddedObjects { * See https://github.com/apache/poi/pull/2 */ @Test - public void testReadManyNestedObjects() throws IOException { + void testReadManyNestedObjects() throws IOException { try (HSSFWorkbook wb = HSSFTestDataSamples.openSampleWorkbook("45538_form_Header.xls")) { List list = wb.getAllEmbeddedObjects(); assertEquals(list.size(), 40); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics.java Fri Jan 8 23:50:02 2021 @@ -62,7 +62,7 @@ public final class TestEscherGraphics { } @Test - public void testGetFont() { + void testGetFont() { Font f = graphics.getFont(); if (! f.toString().contains("dialog") && ! f.toString().contains("Dialog")) { assertEquals("java.awt.Font[family=Arial,name=Arial,style=plain,size=10]", f.toString()); @@ -70,7 +70,7 @@ public final class TestEscherGraphics { } @Test - public void testGetFontMetrics() { + void testGetFontMetrics() { Font f = graphics.getFont(); if (f.toString().contains("dialog") || f.toString().contains("Dialog")) { return; @@ -81,20 +81,20 @@ public final class TestEscherGraphics { } @Test - public void testSetFont() { + void testSetFont() { Font f = new Font("Helvetica", 0, 12); graphics.setFont(f); assertEquals(f, graphics.getFont()); } @Test - public void testSetColor() { + void testSetColor() { graphics.setColor(Color.red); assertEquals(Color.red, graphics.getColor()); } @Test - public void testFillRect() { + void testFillRect() { graphics.fillRect( 10, 10, 20, 20 ); HSSFSimpleShape s = (HSSFSimpleShape) escherGroupA.getChildren().get(0); assertEquals(HSSFSimpleShape.OBJECT_TYPE_RECTANGLE, s.getShapeType()); @@ -105,14 +105,14 @@ public final class TestEscherGraphics { } @Test - public void testDrawString() { + void testDrawString() { graphics.drawString("This is a test", 10, 10); HSSFTextbox t = (HSSFTextbox) escherGroupA.getChildren().get(0); assertEquals("This is a test", t.getString().getString()); } @Test - public void testGetDataBackAgain() throws Exception { + void testGetDataBackAgain() throws Exception { HSSFSheet s; HSSFShapeGroup s1; HSSFShapeGroup s2; Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestEscherGraphics2d.java Fri Jan 8 23:50:02 2021 @@ -54,7 +54,7 @@ public final class TestEscherGraphics2d } @Test - public void testDrawString() { + void testDrawString() { graphics.drawString("This is a test", 10, 10); HSSFTextbox t = (HSSFTextbox) escherGroup.getChildren().get(0); assertEquals("This is a test", t.getString().getString()); @@ -80,7 +80,7 @@ public final class TestEscherGraphics2d } @Test - public void testFillRect() { + void testFillRect() { graphics.fillRect( 10, 10, 20, 20 ); HSSFSimpleShape s = (HSSFSimpleShape) escherGroup.getChildren().get(0); assertEquals(HSSFSimpleShape.OBJECT_TYPE_RECTANGLE, s.getShapeType()); @@ -91,7 +91,7 @@ public final class TestEscherGraphics2d } @Test - public void testGetFontMetrics() { + void testGetFontMetrics() { FontMetrics fontMetrics = graphics.getFontMetrics(graphics.getFont()); if (isDialogPresent()) { // if dialog is returned we can't run the test properly. @@ -102,20 +102,20 @@ public final class TestEscherGraphics2d } @Test - public void testSetFont() { + void testSetFont() { Font f = new Font("Helvetica", Font.PLAIN, 12); graphics.setFont(f); assertEquals(f, graphics.getFont()); } @Test - public void testSetColor() { + void testSetColor() { graphics.setColor(Color.red); assertEquals(Color.red, graphics.getColor()); } @Test - public void testGetFont() { + void testGetFont() { Font f = graphics.getFont(); if (isDialogPresent()) { // if dialog is returned we can't run the test properly. @@ -131,7 +131,7 @@ public final class TestEscherGraphics2d } @Test - public void testDraw() { + void testDraw() { graphics.draw(new Line2D.Double(10,10,20,20)); HSSFSimpleShape s = (HSSFSimpleShape) escherGroup.getChildren().get(0); assertEquals(s.getShapeType(), HSSFSimpleShape.OBJECT_TYPE_LINE); Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestExternalReferenceChange.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestExternalReferenceChange.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestExternalReferenceChange.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestExternalReferenceChange.java Fri Jan 8 23:50:02 2021 @@ -34,7 +34,7 @@ public class TestExternalReferenceChange private static final String SOURCE_WORKBOOK_FILENAME = "52575_source.xls"; @Test - public void testDummyToSource() throws IOException { + void testDummyToSource() throws IOException { try (HSSFWorkbook mainWorkbook = HSSFTestDataSamples.openSampleWorkbook(MAIN_WORKBOOK_FILENAME); HSSFWorkbook sourceWorkbook = HSSFTestDataSamples.openSampleWorkbook(SOURCE_WORKBOOK_FILENAME)) { Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java?rev=1885281&r1=1885280&r2=1885281&view=diff ============================================================================== --- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java (original) +++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFontDetails.java Fri Jan 8 23:50:02 2021 @@ -40,19 +40,19 @@ public final class TestFontDetails { } @Test - public void testCreate() { + void testCreate() { assertEquals(13, fontDetails.getHeight()); assertEquals(6, fontDetails.getCharWidth('a')); assertEquals(3, fontDetails.getCharWidth('f')); } @Test - public void testGetStringWidth() { + void testGetStringWidth() { assertEquals(9, fontDetails.getStringWidth("af")); } @Test - public void testGetCharWidth() { + void testGetCharWidth() { assertEquals(6, fontDetails.getCharWidth('a')); assertEquals(9, fontDetails.getCharWidth('=')); } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org For additional commands, e-mail: commits-help@poi.apache.org