poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiwiwi...@apache.org
Subject svn commit: r1885281 [6/11] - in /poi/trunk/src: multimodule/poi/test9/ ooxml/testcases/org/apache/poi/xssf/streaming/ ooxml/testcases/org/apache/poi/xssf/usermodel/ testcases/org/apache/poi/ testcases/org/apache/poi/ddf/ testcases/org/apache/poi/hpsf/...
Date Fri, 08 Jan 2021 23:50:06 GMT
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestWorkbook.java Fri Jan  8 23:50:02 2021
@@ -60,7 +60,7 @@ public final class TestWorkbook {
      *             HSSFSheet last row or first row is incorrect.             <P>
      */
     @Test
-    public void testWriteSheetSimple() throws IOException {
+    void testWriteSheetSimple() throws IOException {
         try (HSSFWorkbook wb1  = new HSSFWorkbook()) {
             HSSFSheet s = wb1.createSheet();
 
@@ -89,7 +89,7 @@ public final class TestWorkbook {
      *             HSSFSheet last row or first row is incorrect.             <P>
      */
     @Test
-    public void testWriteModifySheetSimple() throws IOException {
+    void testWriteModifySheetSimple() throws IOException {
         HSSFWorkbook wb1 = new HSSFWorkbook();
         HSSFSheet s = wb1.createSheet();
 
@@ -127,7 +127,7 @@ public final class TestWorkbook {
      *             in the sheet in their known positions.<P>
      */
     @Test
-    public void testReadSimple() throws IOException {
+    void testReadSimple() throws IOException {
         HSSFWorkbook wb = openSample("Simple.xls");
         HSSFSheet sheet = wb.getSheetAt(0);
 
@@ -144,7 +144,7 @@ public final class TestWorkbook {
      *             in the sheet in their known positions.<P>
      */
     @Test
-    public void testReadSimpleWithDataFormat() throws IOException {
+    void testReadSimpleWithDataFormat() throws IOException {
         HSSFWorkbook wb = openSample("SimpleWithDataFormat.xls");
         HSSFSheet       sheet    = wb.getSheetAt(0);
         HSSFDataFormat  format   = wb.createDataFormat();
@@ -165,7 +165,7 @@ public final class TestWorkbook {
      *             in the sheet in their known positions.<P>
      */
     @Test
-    public void testWriteDataFormat() throws IOException {
+    void testWriteDataFormat() throws IOException {
         HSSFWorkbook wb1 = new HSSFWorkbook();
         HSSFSheet s1 = wb1.createSheet();
         HSSFDataFormat format = wb1.createDataFormat();
@@ -204,7 +204,7 @@ public final class TestWorkbook {
      *
      */
     @Test
-    public void testReadEmployeeSimple() throws IOException {
+    void testReadEmployeeSimple() throws IOException {
         HSSFWorkbook wb = openSample("Employee.xls");
         HSSFSheet sheet = wb.getSheetAt(0);
 
@@ -228,7 +228,7 @@ public final class TestWorkbook {
      *             is incorrect or has not been replaced. <P>
      */
     @Test
-    public void testModifySimple() throws IOException {
+    void testModifySimple() throws IOException {
         HSSFWorkbook wb1 = openSample("Simple.xls");
         HSSFSheet sheet = wb1.getSheetAt(0);
         HSSFCell cell = sheet.getRow(0).getCell(0);
@@ -257,7 +257,7 @@ public final class TestWorkbook {
      *             or is incorrect. <P>
      */
     @Test
-    public void testModifySimpleWithSkip() throws IOException {
+    void testModifySimpleWithSkip() throws IOException {
         HSSFWorkbook wb1 = openSample("SimpleWithSkip.xls");
         HSSFSheet sheet = wb1.getSheetAt(0);
         HSSFCell cell = sheet.getRow(0).getCell(1);
@@ -295,7 +295,7 @@ public final class TestWorkbook {
      *             is incorrect or has not been replaced. <P>
      */
     @Test
-    public void testModifySimpleWithStyling() throws IOException {
+    void testModifySimpleWithStyling() throws IOException {
         HSSFWorkbook wb1 = openSample("SimpleWithStyling.xls");
         HSSFSheet  sheet = wb1.getSheetAt(0);
 
@@ -328,7 +328,7 @@ public final class TestWorkbook {
      *             is incorrect or has not been replaced. <P>
      */
     @Test
-    public void testModifyEmployee() throws IOException {
+    void testModifyEmployee() throws IOException {
         HSSFWorkbook wb1 = openSample("Employee.xls");
         HSSFSheet  sheet = wb1.getSheetAt(0);
         HSSFCell    cell = sheet.getRow(3).getCell(2);
@@ -358,7 +358,7 @@ public final class TestWorkbook {
      * FAILURE:    HSSF does not read a sheet or excepts.  HSSF incorrectly identifies the cell<P>
      */
     @Test
-    public void testReadSheetWithRK() throws IOException {
+    void testReadSheetWithRK() throws IOException {
         HSSFWorkbook wb = openSample("rk.xls");
         HSSFSheet    s  = wb.getSheetAt(0);
         HSSFCell     c  = s.getRow(0).getCell(0);
@@ -378,7 +378,7 @@ public final class TestWorkbook {
      *             HSSFSheet last row or first row is incorrect.             <P>
      */
     @Test
-    public void testWriteModifySheetMerged() throws IOException {
+    void testWriteModifySheetMerged() throws IOException {
         HSSFWorkbook wb1 = new HSSFWorkbook();
         HSSFSheet    s   = wb1.createSheet();
 
@@ -426,7 +426,7 @@ public final class TestWorkbook {
      * Test the backup field gets set as expected.
      */
     @Test
-    public void testBackupRecord() throws IOException {
+    void testBackupRecord() throws IOException {
         HSSFWorkbook wb = new HSSFWorkbook();
 		wb.createSheet();
 		InternalWorkbook workbook = wb.getWorkbook();
@@ -467,7 +467,7 @@ public final class TestWorkbook {
      * We need to make sure only one LabelSSTRecord is produced.
      */
     @Test
-    public void testRepeatingBug() throws IOException {
+    void testRepeatingBug() throws IOException {
         HSSFWorkbook workbook = new HSSFWorkbook();
         HSSFSheet    sheet    = workbook.createSheet("Design Variants");
         HSSFRow      row      = sheet.createRow(2);
@@ -490,7 +490,7 @@ public final class TestWorkbook {
      * This bug was first fixed in svn r352609.
      */
     @Test
-    public void testRowIndexesBeyond32768() throws IOException {
+    void testRowIndexesBeyond32768() throws IOException {
         HSSFWorkbook wb1 = new HSSFWorkbook();
         HSSFSheet sheet = wb1.createSheet();
         HSSFRow row;
@@ -520,7 +520,7 @@ public final class TestWorkbook {
      * Generate a file to verify repeating rows and cols made it
      */
     @Test
-    public void testRepeatingColsRows() throws IOException {
+    void testRepeatingColsRows() throws IOException {
         HSSFWorkbook wb1 = new HSSFWorkbook();
         HSSFSheet sheet = wb1.createSheet("Test Print Titles");
 
@@ -546,7 +546,7 @@ public final class TestWorkbook {
      * Test setRepeatingRowsAndColumns when startRow and startColumn are -1.
      */
     @Test
-    public void testRepeatingColsRowsMinusOne() throws IOException
+    void testRepeatingColsRowsMinusOne() throws IOException
     {
         HSSFWorkbook workbook = new HSSFWorkbook();
         HSSFSheet sheet = workbook.createSheet("Test Print Titles");
@@ -568,7 +568,7 @@ public final class TestWorkbook {
     }
 
     @Test
-    public void testBug58085RemoveSheetWithNames() throws Exception {
+    void testBug58085RemoveSheetWithNames() throws Exception {
         HSSFWorkbook wb1 = new HSSFWorkbook();
         Sheet sheet1 = wb1.createSheet("sheet1");
         Sheet sheet2 = wb1.createSheet("sheet2");

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java Fri Jan  8 23:50:02 2021
@@ -49,7 +49,7 @@ import org.junit.jupiter.api.Test;
 public final class TestAreaReference {
 
     @Test
-    public void testAreaRef1() {
+    void testAreaRef1() {
         AreaReference ar = new AreaReference("$A$1:$B$2", SpreadsheetVersion.EXCEL97);
         assertFalse(ar.isSingleCell(), "Two cells expected");
         CellReference cf = ar.getFirstCell();
@@ -91,7 +91,7 @@ public final class TestAreaReference {
      * Arne.Clauss@gedas.de
      */
     @Test
-    public void testReferenceWithSheet() {
+    void testReferenceWithSheet() {
         AreaReference ar;
 
         ar = new AreaReference("Tabelle1!B5:B5", SpreadsheetVersion.EXCEL97);
@@ -115,7 +115,7 @@ public final class TestAreaReference {
     }
 
     @Test
-    public void testContiguousReferences() {
+    void testContiguousReferences() {
         String refSimple = "$C$10:$C$10";
         String ref2D = "$C$10:$D$11";
         String refDCSimple = "$C$10:$C$10,$D$12:$D$12,$E$14:$E$14";
@@ -199,7 +199,7 @@ public final class TestAreaReference {
     }
 
     @Test
-    public void testDiscontinousReference() throws Exception {
+    void testDiscontinousReference() throws Exception {
         try (InputStream is = HSSFTestDataSamples.openSampleFileStream("44167.xls");
              HSSFWorkbook wb = new HSSFWorkbook(is)) {
             InternalWorkbook workbook = TestHSSFWorkbook.getInternalWorkbook(wb);
@@ -263,7 +263,7 @@ public final class TestAreaReference {
     }
 
     @Test
-    public void testSpecialSheetNames() {
+    void testSpecialSheetNames() {
         AreaReference ar;
         ar = new AreaReference("'Sheet A'!A1:A1", SpreadsheetVersion.EXCEL97);
         confirmAreaSheetName(ar, "Sheet A", "'Sheet A'!A1");
@@ -288,7 +288,7 @@ public final class TestAreaReference {
     }
 
     @Test
-    public void testWholeColumnRefs() {
+    void testWholeColumnRefs() {
         confirmWholeColumnRef("A:A", 0, 0, false, false);
         confirmWholeColumnRef("$C:D", 2, 3, true, false);
         confirmWholeColumnRef("AD:$AE", 29, 30, false, true);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/util/TestCellReference.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/util/TestCellReference.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/util/TestCellReference.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/util/TestCellReference.java Fri Jan  8 23:50:02 2021
@@ -31,7 +31,7 @@ import org.junit.jupiter.api.Test;
  */
 public final class TestCellReference {
     @Test
-    public void testColNumConversion() {
+    void testColNumConversion() {
         assertEquals(0, CellReference.convertColStringToIndex("A"));
         assertEquals(1, CellReference.convertColStringToIndex("B"));
         assertEquals(25, CellReference.convertColStringToIndex("Z"));
@@ -61,7 +61,7 @@ public final class TestCellReference {
     }
 
     @Test
-    public void testAbsRef1(){
+    void testAbsRef1(){
         CellReference cf = new CellReference("$B$5");
         confirmCell(cf, null, 4, 1, true, true, "$B$5");
     }
@@ -109,7 +109,7 @@ public final class TestCellReference {
     }
 
     @Test
-    public void testSpecialSheetNames() {
+    void testSpecialSheetNames() {
         CellReference cf;
         cf = new CellReference("'profit + loss'!A1");
         confirmCell(cf, "profit + loss", 0, 0, false, false, "'profit + loss'!A1");
@@ -133,7 +133,7 @@ public final class TestCellReference {
     }
 
     @Test
-    public void testClassifyCellReference() {
+    void testClassifyCellReference() {
         confirmNameType("a1", NameType.CELL);
         confirmNameType("pfy1", NameType.NAMED_RANGE);
         confirmNameType("pf1", NameType.NAMED_RANGE); // (col) out of cell range
@@ -148,7 +148,7 @@ public final class TestCellReference {
     }
 
     @Test
-    public void testClassificationOfRowReferences(){
+    void testClassificationOfRowReferences(){
         confirmNameType("10", NameType.ROW);
         confirmNameType("$10", NameType.ROW);
         confirmNameType("65536", NameType.ROW);

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/util/TestHSSFColor.java Fri Jan  8 23:50:02 2021
@@ -27,13 +27,13 @@ import org.junit.jupiter.api.Test;
 
 public final class TestHSSFColor {
     @Test
-    public void testBasics() {
+    void testBasics() {
 		assertTrue(HSSFColorPredefined.YELLOW.getIndex() > 0);
 		assertTrue(HSSFColorPredefined.YELLOW.getIndex2() > 0);
 	}
 
     @Test
-	public void testContents() {
+	void testContents() {
 	    short[] triplet = HSSFColorPredefined.YELLOW.getTriplet();
 		assertEquals(3, triplet.length);
 		assertEquals(255, triplet[0]);
@@ -44,7 +44,7 @@ public final class TestHSSFColor {
 	}
 
     @Test
-	public void testTripletHash() {
+	void testTripletHash() {
 		Map<String, HSSFColor> triplets = HSSFColor.getTripletHash();
 
 		assertEquals(

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/util/TestRKUtil.java Fri Jan  8 23:50:02 2021
@@ -30,7 +30,7 @@ public final class TestRKUtil {
 	 * Check we can decode correctly.
 	 */
 	@Test
-	public void testDecode() {
+	void testDecode() {
 
 		int[] values = { 1074266112, 1081384961, 1081397249,
 				0x3FF00000, 0x405EC001, 0x02F1853A, 0x02F1853B, 0xFCDD699A,

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/crypt/TestXorEncryption.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/crypt/TestXorEncryption.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/crypt/TestXorEncryption.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/crypt/TestXorEncryption.java Fri Jan  8 23:50:02 2021
@@ -41,7 +41,7 @@ public class TestXorEncryption {
     private static final HSSFTestDataSamples samples = new HSSFTestDataSamples();
 
     @Test
-    public void testXorEncryption() {
+    void testXorEncryption() {
         // Xor-Password: abc
         // 2.5.343 XORObfuscation
         // key = 20810
@@ -58,7 +58,7 @@ public class TestXorEncryption {
 
     @SuppressWarnings("static-access")
     @Test
-    public void testUserFile() throws IOException {
+    void testUserFile() throws IOException {
         File f = samples.getSampleFile("xor-encryption-abc.xls");
         Biff8EncryptionKey.setCurrentUserPassword("abc");
         try (POIFSFileSystem fs = new POIFSFileSystem(f, true);

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/crypt/binaryrc4/TestBinaryRC4.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/crypt/binaryrc4/TestBinaryRC4.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/crypt/binaryrc4/TestBinaryRC4.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/crypt/binaryrc4/TestBinaryRC4.java Fri Jan  8 23:50:02 2021
@@ -45,7 +45,7 @@ public class TestBinaryRC4 {
     }
 
     @Test
-    public void testValidateWithDefaultPassword() throws GeneralSecurityException {
+    void testValidateWithDefaultPassword() throws GeneralSecurityException {
 
         String docIdSuffixA = "F 35 52 38 0D 75 4A E6 85 C2 FD 78 CE 3D D1 B6"; // valid prefix is 'D'
         String saltHashA = "30 38 BE 5E 93 C5 7E B4 5F 52 CD A1 C6 8F B6 2A";
@@ -62,7 +62,7 @@ public class TestBinaryRC4 {
     }
 
     @Test
-    public void testValidateWithSuppliedPassword() throws GeneralSecurityException {
+    void testValidateWithSuppliedPassword() throws GeneralSecurityException {
 
         String docId = "DF 35 52 38 0D 75 4A E6 85 C2 FD 78 CE 3D D1 B6";
         String saltData = "D4 04 43 EC B7 A7 6F 6A D2 68 C7 DF CF A8 80 68";

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/dev/TestPOIFSDump.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/dev/TestPOIFSDump.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/dev/TestPOIFSDump.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/dev/TestPOIFSDump.java Fri Jan  8 23:50:02 2021
@@ -136,7 +136,7 @@ public class TestPOIFSDump {
     }
 
     @Test
-    public void testMain() throws Exception {
+    void testMain() throws Exception {
         POIFSDump.main(new String[] {
                 TEST_FILE
         });
@@ -149,7 +149,7 @@ public class TestPOIFSDump {
         }
     }
     @Test
-    public void testInvalidFile() {
+    void testInvalidFile() {
         assertThrows(NotOLE2FileException.class, () -> POIFSDump.main(new String[]{INVALID_FILE}));
         assertThrows(OfficeXmlFileException.class, () -> POIFSDump.main(new String[]{INVALID_XLSX_FILE}));
 
@@ -161,12 +161,12 @@ public class TestPOIFSDump {
 
     @Disabled("Calls System.exit()")
     @Test
-    public void testMainNoArgs() throws Exception {
+    void testMainNoArgs() throws Exception {
         POIFSDump.main(new String[] {});
     }
 
     @Test
-    public void testFailToWrite() throws IOException {
+    void testFailToWrite() throws IOException {
         File dir = TempFile.createTempFile("TestPOIFSDump", ".tst");
         assertTrue(dir.exists(), "Had: " + dir);
         assertTrue(dir.delete(), "Had: " + dir);

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/eventfilesystem/TestPOIFSReaderRegistry.java Fri Jan  8 23:50:02 2021
@@ -60,7 +60,7 @@ public final class TestPOIFSReaderRegist
      * Test empty registry
      */
     @Test
-    public void testEmptyRegistry() {
+    void testEmptyRegistry() {
         POIFSReaderRegistry registry = new POIFSReaderRegistry();
 
         for (POIFSDocumentPath path : paths) {
@@ -77,7 +77,7 @@ public final class TestPOIFSReaderRegist
      * Test mixed registration operations
      */
     @Test
-    public void testMixedRegistrationOperations() {
+    void testMixedRegistrationOperations() {
         POIFSReaderRegistry registry = new POIFSReaderRegistry();
 
         for (int j = 0; j < listeners.length; j++)

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDirectoryNode.java Fri Jan  8 23:50:02 2021
@@ -42,7 +42,7 @@ public final class TestDirectoryNode {
      * test trivial constructor (a DirectoryNode with no children)
      */
     @Test
-    public void testEmptyConstructor() throws IOException {
+    void testEmptyConstructor() throws IOException {
         try (POIFSFileSystem fs = new POIFSFileSystem()) {
             DirectoryProperty property1 = new DirectoryProperty("parent");
             DirectoryProperty property2 = new DirectoryProperty("child");
@@ -90,7 +90,7 @@ public final class TestDirectoryNode {
      * test non-trivial constructor (a DirectoryNode with children)
      */
     @Test
-    public void testNonEmptyConstructor() throws IOException {
+    void testNonEmptyConstructor() throws IOException {
         DirectoryProperty property1 = new DirectoryProperty("parent");
         DirectoryProperty property2 = new DirectoryProperty("child1");
 
@@ -142,7 +142,7 @@ public final class TestDirectoryNode {
      * test deletion methods
      */
     @Test
-    public void testDeletion() throws IOException {
+    void testDeletion() throws IOException {
         try (POIFSFileSystem fs   = new POIFSFileSystem()) {
             DirectoryEntry root = fs.getRoot();
 
@@ -186,7 +186,7 @@ public final class TestDirectoryNode {
      * test change name methods
      */
     @Test
-    public void testRename() throws IOException {
+    void testRename() throws IOException {
         try (POIFSFileSystem fs   = new POIFSFileSystem()) {
             DirectoryEntry root = fs.getRoot();
 

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocument.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocument.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocument.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocument.java Fri Jan  8 23:50:02 2021
@@ -43,7 +43,7 @@ public class TestDocument {
      * Integration test -- really about all we can do
      */
     @Test
-    public void testPOIFSDocument() throws IOException {
+    void testPOIFSDocument() throws IOException {
 
         try (POIFSFileSystem poifs = new POIFSFileSystem()) {
 

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentDescriptor.java Fri Jan  8 23:50:02 2021
@@ -31,7 +31,7 @@ public final class TestDocumentDescripto
      * test equality
      */
     @Test
-    public void testEquality() {
+    void testEquality() {
         String[] names = { "c1", "c2", "c3", "c4", "c5" };
         POIFSDocumentPath   a1    = new POIFSDocumentPath();
         POIFSDocumentPath   a2    = new POIFSDocumentPath(null);

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentInputStream.java Fri Jan  8 23:50:02 2021
@@ -77,7 +77,7 @@ public final class TestDocumentInputStre
      * test constructor
      */
     @Test
-    public void testConstructor() throws IOException {
+    void testConstructor() throws IOException {
         try (DocumentInputStream nstream = new DocumentInputStream(_workbook_n)) {
             assertEquals(_workbook_size, _workbook_n.getSize());
             assertEquals(_workbook_size, available(nstream));
@@ -88,7 +88,7 @@ public final class TestDocumentInputStre
      * test available() behavior
      */
     @Test
-    public void testAvailable() throws IOException {
+    void testAvailable() throws IOException {
         DocumentInputStream nstream = new DocumentInputStream(_workbook_n);
         assertEquals(_workbook_size, available(nstream));
         nstream.close();
@@ -101,7 +101,7 @@ public final class TestDocumentInputStre
      */
     @SuppressWarnings("ResultOfMethodCallIgnored")
     @Test
-    public void testMarkFunctions() throws IOException {
+    void testMarkFunctions() throws IOException {
         byte[] buffer = new byte[_workbook_size / 5];
         byte[] small_buffer = new byte[212];
 
@@ -215,7 +215,7 @@ public final class TestDocumentInputStre
      */
     @SuppressWarnings("ResultOfMethodCallIgnored")
     @Test
-    public void testReadSingleByte() throws IOException {
+    void testReadSingleByte() throws IOException {
         DocumentInputStream stream = new DocumentInputStream(_workbook_n);
         int remaining = _workbook_size;
 
@@ -241,7 +241,7 @@ public final class TestDocumentInputStre
      */
     @SuppressWarnings("ResultOfMethodCallIgnored")
     @Test
-    public void testBufferRead() throws IOException {
+    void testBufferRead() throws IOException {
         DocumentInputStream stream = new DocumentInputStream(_workbook_n);
         // Need to give a byte array to read
         assertThrows(NullPointerException.class, () -> stream.read(null));
@@ -284,7 +284,7 @@ public final class TestDocumentInputStre
      */
     @SuppressWarnings("ResultOfMethodCallIgnored")
     @Test
-    public void testComplexBufferRead() throws IOException {
+    void testComplexBufferRead() throws IOException {
         DocumentInputStream stream = new DocumentInputStream(_workbook_n);
         assertThrows(IllegalArgumentException.class, () -> stream.read(null, 0, 1));
 
@@ -340,7 +340,7 @@ public final class TestDocumentInputStre
      * Tests that we can skip within the stream
      */
     @Test
-    public void testSkip() throws IOException {
+    void testSkip() throws IOException {
         DocumentInputStream stream = new DocumentInputStream(_workbook_n);
         assertEquals(_workbook_size, available(stream));
         int count = available(stream);
@@ -368,7 +368,7 @@ public final class TestDocumentInputStre
      * Test that we can read files at multiple levels down the tree
      */
     @Test
-    public void testReadMultipleTreeLevels() throws Exception {
+    void testReadMultipleTreeLevels() throws Exception {
         final POIDataSamples _samples = POIDataSamples.getPublisherInstance();
         File sample = _samples.getFile("Sample.pub");
 

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestDocumentOutputStream.java Fri Jan  8 23:50:02 2021
@@ -38,7 +38,7 @@ public final class TestDocumentOutputStr
      * test write(int) behavior
      */
     @Test
-    public void testWrite1() throws IOException {
+    void testWrite1() throws IOException {
         final byte[] expected = data(25);
 
         POIFSWriterListener l = (event) -> {
@@ -62,7 +62,7 @@ public final class TestDocumentOutputStr
      * test write(byte[]) behavior
      */
     @Test
-    public void testWrite2() throws IOException {
+    void testWrite2() throws IOException {
         final byte[] expected = data(24);
 
         POIFSWriterListener l = (event) -> {
@@ -84,7 +84,7 @@ public final class TestDocumentOutputStr
      * test write(byte[], int, int) behavior
      */
     @Test
-    public void testWrite3() throws IOException {
+    void testWrite3() throws IOException {
         byte[] input = data(50);
         byte[] expected = Arrays.copyOfRange(input, 1, 1+25);
 

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEmptyDocument.java Fri Jan  8 23:50:02 2021
@@ -33,7 +33,7 @@ public final class TestEmptyDocument {
     private static final POILogger LOG = POILogFactory.getLogger(TestEmptyDocument.class);
 
     @Test
-	public void testSingleEmptyDocument() throws IOException {
+	void testSingleEmptyDocument() throws IOException {
 		POIFSFileSystem fs = new POIFSFileSystem();
 		DirectoryEntry dir = fs.getRoot();
 		dir.createDocument("Foo", new ByteArrayInputStream(new byte[] {}));
@@ -45,7 +45,7 @@ public final class TestEmptyDocument {
 	}
 
     @Test
-	public void testSingleEmptyDocumentEvent() throws IOException {
+	void testSingleEmptyDocumentEvent() throws IOException {
 		POIFSFileSystem fs = new POIFSFileSystem();
 		DirectoryEntry dir = fs.getRoot();
 		dir.createDocument("Foo", 0, event -> LOG.log(POILogger.WARN, "written"));
@@ -57,7 +57,7 @@ public final class TestEmptyDocument {
 	}
 
     @Test
-	public void testEmptyDocumentWithFriend() throws IOException {
+	void testEmptyDocumentWithFriend() throws IOException {
 		POIFSFileSystem fs = new POIFSFileSystem();
 		DirectoryEntry dir = fs.getRoot();
 		dir.createDocument("Bar", new ByteArrayInputStream(new byte[] { 0 }));
@@ -70,7 +70,7 @@ public final class TestEmptyDocument {
 	}
 
     @Test
-	public void testEmptyDocumentEventWithFriend() throws IOException {
+	void testEmptyDocumentEventWithFriend() throws IOException {
 		POIFSFileSystem fs = new POIFSFileSystem();
 		DirectoryEntry dir = fs.getRoot();
 		dir.createDocument("Bar", 1, event -> {
@@ -89,7 +89,7 @@ public final class TestEmptyDocument {
 	}
 
     @Test
-	public void testEmptyDocumentBug11744() throws Exception {
+	void testEmptyDocumentBug11744() throws Exception {
 		byte[] testData = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 };
 
 		POIFSFileSystem fs = new POIFSFileSystem();

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEntryUtils.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEntryUtils.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEntryUtils.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestEntryUtils.java Fri Jan  8 23:50:02 2021
@@ -37,7 +37,7 @@ public class TestEntryUtils {
     private static final byte[] dataSmallB = new byte[] { 11, 73, 21, -92, -103 };
 
     @Test
-    public void testCopyRecursively() throws IOException {
+    void testCopyRecursively() throws IOException {
        POIFSFileSystem fsD = new POIFSFileSystem();
        POIFSFileSystem fs = new POIFSFileSystem();
        DirectoryEntry dirA = fs.createDirectory("DirA");
@@ -100,7 +100,7 @@ public class TestEntryUtils {
     }
 
     @Test
-    public void testAreDocumentsIdentical() throws IOException {
+    void testAreDocumentsIdentical() throws IOException {
        POIFSFileSystem fs = new POIFSFileSystem();
        DirectoryEntry dirA = fs.createDirectory("DirA");
        DirectoryEntry dirB = fs.createDirectory("DirB");
@@ -149,7 +149,7 @@ public class TestEntryUtils {
     }
 
     @Test
-    public void testAreDirectoriesIdentical() throws IOException {
+    void testAreDirectoriesIdentical() throws IOException {
        POIFSFileSystem fs = new POIFSFileSystem();
        DirectoryEntry dirA = fs.createDirectory("DirA");
        DirectoryEntry dirB = fs.createDirectory("DirB");

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileMagic.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileMagic.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileMagic.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileMagic.java Fri Jan  8 23:50:02 2021
@@ -41,7 +41,7 @@ import org.junit.jupiter.api.Test;
 
 public class TestFileMagic {
     @Test
-    public void testFileMagic() {
+    void testFileMagic() {
         assertEquals(FileMagic.XML, FileMagic.valueOf("XML"));
         assertEquals(FileMagic.XML, FileMagic.valueOf("<?xml".getBytes(StandardCharsets.UTF_8)));
 
@@ -66,13 +66,13 @@ public class TestFileMagic {
     }
 
     @Test
-    public void testFileMagicFile() throws IOException {
+    void testFileMagicFile() throws IOException {
         assertEquals(FileMagic.OLE2, FileMagic.valueOf(POIDataSamples.getSpreadSheetInstance().getFile("SampleSS.xls")));
         assertEquals(FileMagic.OOXML, FileMagic.valueOf(POIDataSamples.getSpreadSheetInstance().getFile("SampleSS.xlsx")));
     }
 
     @Test
-    public void testFileMagicStream() throws IOException {
+    void testFileMagicStream() throws IOException {
         try (InputStream stream = new BufferedInputStream(new FileInputStream(POIDataSamples.getSpreadSheetInstance().getFile("SampleSS.xls")))) {
             assertEquals(FileMagic.OLE2, FileMagic.valueOf(stream));
         }
@@ -82,7 +82,7 @@ public class TestFileMagic {
     }
 
     @Test
-    public void testPrepare() throws IOException {
+    void testPrepare() throws IOException {
         try (InputStream stream = new BufferedInputStream(new FileInputStream(POIDataSamples.getSpreadSheetInstance().getFile("SampleSS.xlsx")))) {
             assertSame(stream, FileMagic.prepareToCheckMagic(stream));
         }
@@ -98,7 +98,7 @@ public class TestFileMagic {
     }
 
     @Test
-    public void testMatchingButTooLessData() {
+    void testMatchingButTooLessData() {
         // this matches JPG, but is not long enough, previously this caused an Exception
         byte[] data = new byte[] { -1, -40, -1, -32, 0, 16, 74, 70 };
 
@@ -106,7 +106,7 @@ public class TestFileMagic {
     }
 
     @Test
-    public void testShortFile() throws IOException {
+    void testShortFile() throws IOException {
         // having a file shorter than 8 bytes previously caused an exception
         fetchMagicFromData(new byte[] { -1, -40, -1, -32, 0 });
         fetchMagicFromData(new byte[] { -1, -40, -1, -32 });
@@ -130,7 +130,7 @@ public class TestFileMagic {
     }
 
     @Test
-    public void testMarkRequired() throws IOException {
+    void testMarkRequired() throws IOException {
         byte[] data = new byte[] { -1, -40, -1, -32, 0 };
 
         File file = TempFile.createTempFile("TestFileMagic", ".bin");
@@ -151,7 +151,7 @@ public class TestFileMagic {
     }
 
     @Test
-    public void testPatterns() {
+    void testPatterns() {
         // just try to trash the functionality with some byte-patterns
         for(int i = 0; i < 256;i++) {
             final byte[] data = new byte[12];
@@ -164,7 +164,7 @@ public class TestFileMagic {
     }
 
     @Test
-    public void testRandomPatterns() {
+    void testRandomPatterns() {
         Random random = new Random();
 
         // just try to trash the functionality with some byte-patterns

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFileSystemBugs.java Fri Jan  8 23:50:02 2021
@@ -84,7 +84,7 @@ public final class TestFileSystemBugs {
      * These have a top level directory without a name....
      */
     @Test
-    public void testNotesOLE2Files() throws Exception {
+    void testNotesOLE2Files() throws Exception {
         // Check the contents
         DirectoryNode root = openSample("Notes.ole2");
         assertEquals(1, root.getEntryCount());
@@ -119,7 +119,7 @@ public final class TestFileSystemBugs {
      *  can't cope with this level of corruption
      */
     @Test
-    public void testCorruptedProperties() throws Exception {
+    void testCorruptedProperties() throws Exception {
         DirectoryNode root = openSample("unknown_properties.msg");
         assertEquals(42, root.getEntryCount());
     }
@@ -128,7 +128,7 @@ public final class TestFileSystemBugs {
      * With heavily nested documents, ensure we still re-write the same
      */
     @Test
-    public void testHeavilyNestedReWrite() throws Exception {
+    void testHeavilyNestedReWrite() throws Exception {
         DirectoryNode root = openSSSample("ex42570-20305.xls");
         // Record the structure
         Map<String,Integer> entries = new HashMap<>();

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestFilteringDirectoryNode.java Fri Jan  8 23:50:02 2021
@@ -58,7 +58,7 @@ public final class TestFilteringDirector
     }
 
     @Test
-    public void testNoFiltering() throws Exception {
+    void testNoFiltering() throws Exception {
         FilteringDirectoryNode d = new FilteringDirectoryNode(fs.getRoot(), new HashSet<>());
         assertEquals(3, d.getEntryCount());
         assertEquals(dirA.getName(), d.getEntry(dirA.getName()).getName());
@@ -80,7 +80,7 @@ public final class TestFilteringDirector
     }
 
     @Test
-    public void testChildFiltering() throws Exception {
+    void testChildFiltering() throws Exception {
         List<String> excl = Arrays.asList("NotThere", "AlsoNotThere", eRoot.getName());
         FilteringDirectoryNode d1 = new FilteringDirectoryNode(fs.getRoot(), excl);
 
@@ -132,7 +132,7 @@ public final class TestFilteringDirector
     }
 
     @Test
-    public void testNestedFiltering() throws Exception {
+    void testNestedFiltering() throws Exception {
         List<String> excl = Arrays.asList(dirA.getName() + "/" + "MadeUp",
             dirA.getName() + "/" + eA.getName(),
             dirA.getName() + "/" + dirAA.getName() + "/Test",
@@ -158,7 +158,7 @@ public final class TestFilteringDirector
     }
 
     @Test
-    public void testNullDirectory() {
+    void testNullDirectory() {
         assertThrows(IllegalArgumentException.class, () -> new FilteringDirectoryNode(null, null));
     }
 }
\ No newline at end of file

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestNotOLE2Exception.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestNotOLE2Exception.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestNotOLE2Exception.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestNotOLE2Exception.java Fri Jan  8 23:50:02 2021
@@ -42,7 +42,7 @@ public class TestNotOLE2Exception {
     }
 
     @Test
-	public void testRawXMLException() throws IOException {
+	void testRawXMLException() throws IOException {
         try (InputStream in = openXLSSampleStream("SampleSS.xml")) {
             NotOLE2FileException e = assertThrows(NotOLE2FileException.class, () -> new POIFSFileSystem(in));
             assertContains(e.getMessage(), "The supplied data appears to be a raw XML file");
@@ -51,7 +51,7 @@ public class TestNotOLE2Exception {
     }
 
     @Test
-    public void testMSWriteException() throws IOException {
+    void testMSWriteException() throws IOException {
         try (InputStream in = openDOCSampleStream("MSWriteOld.wri")) {
             NotOLE2FileException e = assertThrows(NotOLE2FileException.class, () -> new POIFSFileSystem(in));
             assertContains(e.getMessage(), "The supplied data appears to be in the old MS Write");
@@ -60,7 +60,7 @@ public class TestNotOLE2Exception {
     }
 
     @Test
-	public void testBiff3Exception() throws IOException {
+	void testBiff3Exception() throws IOException {
         try (InputStream in = openXLSSampleStream("testEXCEL_3.xls")) {
             OldExcelFormatException e = assertThrows(OldExcelFormatException.class, () -> new POIFSFileSystem(in));
             assertContains(e.getMessage(), "The supplied data appears to be in BIFF3 format");
@@ -69,7 +69,7 @@ public class TestNotOLE2Exception {
 	}
 
     @Test
-    public void testBiff4Exception() throws IOException {
+    void testBiff4Exception() throws IOException {
         try (InputStream in = openXLSSampleStream("testEXCEL_4.xls")) {
             OldExcelFormatException e = assertThrows(OldExcelFormatException.class, () -> new POIFSFileSystem(in));
             assertContains(e.getMessage(), "The supplied data appears to be in BIFF4 format");

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOfficeXMLException.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOfficeXMLException.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOfficeXMLException.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOfficeXMLException.java Fri Jan  8 23:50:02 2021
@@ -42,7 +42,7 @@ public class TestOfficeXMLException {
     }
 
     @Test
-    public void testOOXMLException() throws IOException {
+    void testOOXMLException() throws IOException {
         try (InputStream in = openSampleStream("sample.xlsx")) {
             OfficeXmlFileException ex = assertThrows(OfficeXmlFileException.class, () -> new POIFSFileSystem(in));
             assertTrue(ex.getMessage().contains("You are calling the part of POI that deals with OLE2 Office Documents"));
@@ -50,7 +50,7 @@ public class TestOfficeXMLException {
     }
 
     @Test
-    public void test2003XMLException() throws IOException {
+    void test2003XMLException() throws IOException {
         try (InputStream in = openSampleStream("SampleSS.xml")) {
             NotOLE2FileException ex = assertThrows(NotOLE2FileException.class, () -> new POIFSFileSystem(in));
             assertTrue(ex.getMessage().contains("The supplied data appears to be a raw XML file"));
@@ -58,7 +58,7 @@ public class TestOfficeXMLException {
     }
 
     @Test
-    public void testDetectAsPOIFS() throws IOException {
+    void testDetectAsPOIFS() throws IOException {
         // ooxml file isn't
         confirmIsPOIFS("SampleSS.xlsx", FileMagic.OOXML);
 
@@ -86,7 +86,7 @@ public class TestOfficeXMLException {
     }
 
     @Test
-    public void testFileCorruption() throws Exception {
+    void testFileCorruption() throws Exception {
 
         // create test InputStream
         byte[] testData = {1, 2, 3};
@@ -106,7 +106,7 @@ public class TestOfficeXMLException {
 
 
     @Test
-    public void testFileCorruptionOPOIFS() throws Exception {
+    void testFileCorruptionOPOIFS() throws Exception {
 
         // create test InputStream
         byte[] testData = {(byte) 1, (byte) 2, (byte) 3};

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOle10Native.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOle10Native.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOle10Native.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestOle10Native.java Fri Jan  8 23:50:02 2021
@@ -40,7 +40,7 @@ public class TestOle10Native {
     private static final POIDataSamples dataSamples = POIDataSamples.getPOIFSInstance();
 
     @Test
-    public void testOleNative() throws IOException, Ole10NativeException {
+    void testOleNative() throws IOException, Ole10NativeException {
         POIFSFileSystem fs = new POIFSFileSystem(dataSamples.openResourceAsStream("oleObject1.bin"));
 
         Ole10Native ole = Ole10Native.createFromEmbeddedOleObject(fs);
@@ -50,7 +50,7 @@ public class TestOle10Native {
     }
 
     @Test
-    public void testFiles() throws IOException, Ole10NativeException {
+    void testFiles() throws IOException, Ole10NativeException {
         File[] files = {
                 // bug 51891
                 POIDataSamples.getPOIFSInstance().getFile("multimedia.doc"),
@@ -98,7 +98,7 @@ public class TestOle10Native {
     }
 
     @Test
-    public void testOleNativeOOM() throws IOException {
+    void testOleNativeOOM() throws IOException {
         try (POIFSFileSystem fs = new POIFSFileSystem(dataSamples.openResourceAsStream("60256.bin"))) {
             RecordFormatException ex = assertThrows(
                 RecordFormatException.class,

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSDocumentPath.java Fri Jan  8 23:50:02 2021
@@ -38,7 +38,7 @@ public final class TestPOIFSDocumentPath
      * Test default constructor
      */
     @Test
-    public void testDefaultConstructor() {
+    void testDefaultConstructor() {
         POIFSDocumentPath path = new POIFSDocumentPath();
 
         assertEquals(0, path.length());
@@ -48,7 +48,7 @@ public final class TestPOIFSDocumentPath
      * Test full path constructor
      */
     @Test
-    public void testFullPathConstructor() {
+    void testFullPathConstructor() {
         String[] components = {"foo", "bar", "foobar", "fubar"};
 
         for (int j = 0; j < components.length; j++) {
@@ -82,7 +82,7 @@ public final class TestPOIFSDocumentPath
      * Test relative path constructor
      */
     @Test
-    public void testRelativePathConstructor() {
+    void testRelativePathConstructor() {
         String[] initialComponents = {"a", "b", "c"};
 
         for (int n = 0; n < initialComponents.length; n++) {
@@ -135,7 +135,7 @@ public final class TestPOIFSDocumentPath
      * test equality
      */
     @Test
-    public void testEquality() {
+    void testEquality() {
         POIFSDocumentPath   a1    = new POIFSDocumentPath();
         POIFSDocumentPath   a2    = new POIFSDocumentPath(null);
         POIFSDocumentPath   a3    = new POIFSDocumentPath(new String[ 0 ]);

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSFileSystem.java Fri Jan  8 23:50:02 2021
@@ -111,7 +111,7 @@ public final class TestPOIFSFileSystem {
 	 * POIFSFileSystem was not closing the input stream.
 	 */
 	@Test
-	public void testAlwaysClose() throws IOException {
+	void testAlwaysClose() throws IOException {
 		// Normal case - read until EOF and close
 		try (TestIS testIS = new TestIS(openSampleStream("13224.xls"), -1);
 			POIFSFileSystem ignored = new POIFSFileSystem(testIS)){
@@ -138,7 +138,7 @@ public final class TestPOIFSFileSystem {
 	 *  POIFS, since it seems to be slight wrong
 	 */
 	@Test
-	public void testShortLastBlock() throws Exception {
+	void testShortLastBlock() throws Exception {
 		String[] files = new String[] {
 			"ShortLastBlock.qwp", "ShortLastBlock.wps"
 		};
@@ -163,7 +163,7 @@ public final class TestPOIFSFileSystem {
 	 *  sectors that exist in the file.
 	 */
 	@Test
-	public void testFATandDIFATsectors() throws Exception {
+	void testFATandDIFATsectors() throws Exception {
 		try (InputStream stream = _samples.openResourceAsStream("ReferencesInvalidSectors.mpp")) {
 			IndexOutOfBoundsException ex = assertThrows(
 				IndexOutOfBoundsException.class,
@@ -181,7 +181,7 @@ public final class TestPOIFSFileSystem {
 	 *  to have an XBAT in it, we don't have a test one. So, generate it.
 	 */
 	@Test
-	public void testBATandXBAT() throws Exception {
+	void testBATandXBAT() throws Exception {
 	   byte[] hugeStream = new byte[8*1024*1024];
 	   POIFSFileSystem fs = new POIFSFileSystem();
 	   fs.getRoot().createDocument(
@@ -230,7 +230,7 @@ public final class TestPOIFSFileSystem {
 	 *  use 4k blocks. Check that we can open these.
 	 */
 	@Test
-	public void test4KBlocks() throws Exception {
+	void test4KBlocks() throws Exception {
         POIDataSamples _samples = POIDataSamples.getPOIFSInstance();
 		try (InputStream inp = _samples.openResourceAsStream("BlockSize4096.zvi")) {
 			// First up, check that we can process the header properly
@@ -291,7 +291,7 @@ public final class TestPOIFSFileSystem {
 	}
 
 	@Test
-	public void test64322() throws NoPropertySetStreamException, IOException {
+	void test64322() throws NoPropertySetStreamException, IOException {
 		try (POIFSFileSystem poiFS = new POIFSFileSystem(_samples.getFile("64322.ole2"))) {
 			int count = recurseDir(poiFS.getRoot());
 
@@ -300,7 +300,7 @@ public final class TestPOIFSFileSystem {
 	}
 
 	@Test
-	public void test64322a() throws NoPropertySetStreamException, IOException {
+	void test64322a() throws NoPropertySetStreamException, IOException {
 		try (POIFSFileSystem poiFS = new POIFSFileSystem(_samples.openResourceAsStream("64322.ole2"))) {
 			int count = recurseDir(poiFS.getRoot());
 

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSMiniStore.java Fri Jan  8 23:50:02 2021
@@ -46,7 +46,7 @@ public final class TestPOIFSMiniStore {
      * out what the next one is
      */
     @Test
-    public void testNextBlock() throws Exception {
+    void testNextBlock() throws Exception {
         // It's the same on 512 byte and 4096 byte block files!
         POIFSFileSystem fsA = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"));
         POIFSFileSystem fsB = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
@@ -124,7 +124,7 @@ public final class TestPOIFSMiniStore {
      * Check we get the right data back for each block
      */
     @Test
-    public void testGetBlock() throws Exception {
+    void testGetBlock() throws Exception {
         // It's the same on 512 byte and 4096 byte block files!
         POIFSFileSystem fsA = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"));
         POIFSFileSystem fsB = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
@@ -195,7 +195,7 @@ public final class TestPOIFSMiniStore {
      * to be had from the SFAT
      */
     @Test
-    public void testGetFreeBlockWithSpare() throws Exception {
+    void testGetFreeBlockWithSpare() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"));
         POIFSMiniStore ministore = fs.getMiniStore();
 
@@ -227,7 +227,7 @@ public final class TestPOIFSMiniStore {
      * stream needs to be extended and another SBAT added
      */
     @Test
-    public void testGetFreeBlockWithNoneSpare() throws Exception {
+    void testGetFreeBlockWithNoneSpare() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
         POIFSMiniStore ministore = fs.getMiniStore();
 
@@ -269,7 +269,7 @@ public final class TestPOIFSMiniStore {
      * big blocks that make up the ministream as needed
      */
     @Test
-    public void testCreateBlockIfNeeded() throws Exception {
+    void testCreateBlockIfNeeded() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
         POIFSMiniStore ministore = fs.getMiniStore();
 
@@ -344,7 +344,7 @@ public final class TestPOIFSMiniStore {
     }
 
     @Test
-    public void testCreateMiniStoreFirst() throws Exception {
+    void testCreateMiniStoreFirst() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem();
         POIFSMiniStore ministore = fs.getMiniStore();
         DocumentInputStream dis;
@@ -412,7 +412,7 @@ public final class TestPOIFSMiniStore {
     }
 
     @Test
-    public void testMultiBlockStream() throws Exception {
+    void testMultiBlockStream() throws Exception {
         byte[] data1B = new byte[63];
         byte[] data2B = new byte[64 + 14];
         for (int i = 0; i < data1B.length; i++) {

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPOIFSStream.java Fri Jan  8 23:50:02 2021
@@ -67,7 +67,7 @@ public final class TestPOIFSStream {
      * Read a single block stream
      */
     @Test
-    public void testReadTinyStream() throws Exception {
+    void testReadTinyStream() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"));
 
         // 98 is actually the last block in a two block stream...
@@ -94,7 +94,7 @@ public final class TestPOIFSStream {
      * Read a stream with only two blocks in it
      */
     @Test
-    public void testReadShortStream() throws Exception {
+    void testReadShortStream() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"));
 
         // 97 -> 98 -> end
@@ -133,7 +133,7 @@ public final class TestPOIFSStream {
      * Read a stream with many blocks
      */
     @Test
-    public void testReadLongerStream() throws Exception {
+    void testReadLongerStream() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"));
 
         ByteBuffer b0 = null;
@@ -193,7 +193,7 @@ public final class TestPOIFSStream {
      * Read a stream with several blocks in a 4096 byte block file
      */
     @Test
-    public void testReadStream4096() throws Exception {
+    void testReadStream4096() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.getFile("BlockSize4096.zvi"));
 
         // 0 -> 1 -> 2 -> end
@@ -244,7 +244,7 @@ public final class TestPOIFSStream {
      * Craft a nasty file with a loop, and ensure we don't get stuck
      */
     @Test
-    public void testReadFailsOnLoop() throws Exception {
+    void testReadFailsOnLoop() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"));
 
         // Hack the FAT so that it goes 0->1->2->0
@@ -281,7 +281,7 @@ public final class TestPOIFSStream {
      * stored in the mini stream.
      */
     @Test
-    public void testReadMiniStreams() throws Exception {
+    void testReadMiniStreams() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
         POIFSMiniStore ministore = fs.getMiniStore();
 
@@ -333,7 +333,7 @@ public final class TestPOIFSStream {
      * Writing the same amount of data as before
      */
     @Test
-    public void testReplaceStream() throws Exception {
+    void testReplaceStream() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
 
         byte[] data = new byte[512];
@@ -367,7 +367,7 @@ public final class TestPOIFSStream {
      * to be freed
      */
     @Test
-    public void testReplaceStreamWithLess() throws Exception {
+    void testReplaceStreamWithLess() throws Exception {
         try (InputStream is = _inst.openResourceAsStream("BlockSize512.zvi");
              POIFSFileSystem fs = new POIFSFileSystem(is)) {
 
@@ -408,7 +408,7 @@ public final class TestPOIFSStream {
      * Writes more data than before, new blocks will be needed
      */
     @Test
-    public void testReplaceStreamWithMore() throws Exception {
+    void testReplaceStreamWithMore() throws Exception {
         try (InputStream is = _inst.openResourceAsStream("BlockSize512.zvi");
              POIFSFileSystem fs = new POIFSFileSystem(is)) {
 
@@ -455,7 +455,7 @@ public final class TestPOIFSStream {
      * Writes to a new stream in the file
      */
     @Test
-    public void testWriteNewStream() throws Exception {
+    void testWriteNewStream() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
 
         // 100 is our first free one
@@ -550,7 +550,7 @@ public final class TestPOIFSStream {
      * to support this
      */
     @Test
-    public void testWriteNewStreamExtraFATs() throws Exception {
+    void testWriteNewStreamExtraFATs() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize512.zvi"));
 
         // Allocate almost all the blocks
@@ -592,7 +592,7 @@ public final class TestPOIFSStream {
      * more data than before, in a 4096 byte block file
      */
     @Test
-    public void testWriteStream4096() throws Exception {
+    void testWriteStream4096() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem(_inst.openResourceAsStream("BlockSize4096.zvi"));
 
         // 0 -> 1 -> 2 -> end
@@ -647,7 +647,7 @@ public final class TestPOIFSStream {
      * Tests that we can write into the mini stream
      */
     @Test
-    public void testWriteMiniStreams() throws Exception {
+    void testWriteMiniStreams() throws Exception {
         try (InputStream is = _inst.openResourceAsStream("BlockSize512.zvi");
              POIFSFileSystem fs = new POIFSFileSystem(is)) {
 
@@ -838,7 +838,7 @@ public final class TestPOIFSStream {
      * Craft a nasty file with a loop, and ensure we don't get stuck
      */
     @Test
-    public void testWriteFailsOnLoop() throws Exception {
+    void testWriteFailsOnLoop() throws Exception {
         try (POIFSFileSystem fs = new POIFSFileSystem(_inst.getFile("BlockSize512.zvi"))) {
 
             // Hack the FAT so that it goes 0->1->2->0
@@ -867,7 +867,7 @@ public final class TestPOIFSStream {
      * Tests adding a new stream, writing and reading it.
      */
     @Test
-    public void testReadWriteNewStream() throws Exception {
+    void testReadWriteNewStream() throws Exception {
         try (POIFSFileSystem fs = new POIFSFileSystem()) {
             POIFSStream stream = new POIFSStream(fs);
 
@@ -933,7 +933,7 @@ public final class TestPOIFSStream {
      * Writes a stream, then replaces it
      */
     @Test
-    public void testWriteThenReplace() throws Exception {
+    void testWriteThenReplace() throws Exception {
         POIFSFileSystem fs = new POIFSFileSystem();
 
         // Starts empty, other that Properties and BAT

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/filesystem/TestPropertySorter.java Fri Jan  8 23:50:02 2021
@@ -66,7 +66,7 @@ public final class TestPropertySorter {
      * Test sorting of properties in <code>DirectoryProperty</code>
      */
     @Test
-    public void testSortProperties() throws IOException {
+    void testSortProperties() throws IOException {
         POIFSFileSystem fs = openSampleFS();
         Property[] props = getVBAProperties(fs);
 
@@ -98,7 +98,7 @@ public final class TestPropertySorter {
      * Serialize file system and verify that the order of properties is the same as in the original file.
      */
     @Test
-    public void testSerialization() throws IOException {
+    void testSerialization() throws IOException {
         POIFSFileSystem fs = openSampleFS();
 
         ByteArrayOutputStream out = new ByteArrayOutputStream();

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/nio/TestDataSource.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/nio/TestDataSource.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/nio/TestDataSource.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/nio/TestDataSource.java Fri Jan  8 23:50:02 2021
@@ -44,7 +44,7 @@ public class TestDataSource {
     private static final POIDataSamples data = POIDataSamples.getPOIFSInstance();
 
     @Test
-    public void testFile() throws Exception {
+    void testFile() throws Exception {
         File f = data.getFile("Notes.ole2");
 
         try (FileBackedDataSource ds = new FileBackedDataSource(f)) {
@@ -58,7 +58,7 @@ public class TestDataSource {
     }
 
     @Test
-    public void testFileWritable() throws Exception {
+    void testFileWritable() throws Exception {
         File temp = TempFile.createTempFile("TestDataSource", ".test");
         try {
             writeDataToFile(temp);
@@ -81,7 +81,7 @@ public class TestDataSource {
 
 
     @Test
-    public void testRewritableFile() throws Exception {
+    void testRewritableFile() throws Exception {
         File temp = TempFile.createTempFile("TestDataSource", ".test");
         try {
             writeDataToFile(temp);
@@ -167,7 +167,7 @@ public class TestDataSource {
     }
 
     @Test
-    public void testByteArray() {
+    void testByteArray() {
         byte[] data = new byte[256];
         byte b;
         for (int i = 0; i < data.length; i++) {

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDirectoryProperty.java Fri Jan  8 23:50:02 2021
@@ -44,7 +44,7 @@ public final class TestDirectoryProperty
      * Test constructing DirectoryProperty
      */
     @Test
-    public void testConstructor() throws IOException {
+    void testConstructor() throws IOException {
         createBasicDirectoryProperty();
         verifyProperty();
     }
@@ -53,7 +53,7 @@ public final class TestDirectoryProperty
      * Test pre-write functionality
      */
     @Test
-    public void testPreWrite() throws IOException {
+    void testPreWrite() throws IOException {
         createBasicDirectoryProperty();
         _property.preWrite();
 
@@ -200,7 +200,7 @@ public final class TestDirectoryProperty
     }
 
     @Test
-    public void testAddChild() throws IOException {
+    void testAddChild() throws IOException {
         createBasicDirectoryProperty();
         _property.addChild(new LocalProperty(1));
         _property.addChild(new LocalProperty(2));
@@ -210,7 +210,7 @@ public final class TestDirectoryProperty
     }
 
     @Test
-    public void testDeleteChild() throws IOException {
+    void testDeleteChild() throws IOException {
         createBasicDirectoryProperty();
         Property p1 = new LocalProperty(1);
 
@@ -222,7 +222,7 @@ public final class TestDirectoryProperty
     }
 
     @Test
-    public void testChangeName() throws IOException {
+    void testChangeName() throws IOException {
         createBasicDirectoryProperty();
         Property p1           = new LocalProperty(1);
         String   originalName = p1.getName();
@@ -241,7 +241,7 @@ public final class TestDirectoryProperty
     }
 
     @Test
-    public void testReadingConstructor() {
+    void testReadingConstructor() {
         String[] input = {
             "42 00 6F 00 6F 00 74 00 20 00 45 00 6E 00 74 00 72 00 79 00 00 00 00 00 00 00 00 00 00 00 00 00",
             "00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00",

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/property/TestDocumentProperty.java Fri Jan  8 23:50:02 2021
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
 public final class TestDocumentProperty {
 
     @Test
-    public void testConstructor() throws IOException {
+    void testConstructor() throws IOException {
         // test with short name, small file
         verifyProperty("foo", 1234);
 
@@ -52,7 +52,7 @@ public final class TestDocumentProperty
     }
 
     @Test
-    public void testReadingConstructor() throws IOException {
+    void testReadingConstructor() throws IOException {
         String[] hexData = {
             "52 00 6F 00 6F 00 74 00 20 00 45 00 6E 00 74 00 72 00 79 00 00 00 00 00 00 00 00 00 00 00 00 00",
             "00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00",

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyFactory.java Fri Jan  8 23:50:02 2021
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.Test;
 public final class TestPropertyFactory {
 
     @Test
-    public void testConvertToProperties() throws IOException {
+    void testConvertToProperties() throws IOException {
 
 		// real data from a real file!
 		String hexData =

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/property/TestPropertyTable.java Fri Jan  8 23:50:02 2021
@@ -90,7 +90,7 @@ public final class TestPropertyTable {
 	 * extracted from a file known to be acceptable to Excel.
 	 */
 	@Test
-	public void testWriterPropertyTable() throws IOException {
+	void testWriterPropertyTable() throws IOException {
 
 		// create the PropertyTable
 	   HeaderBlock   headerBlock = new HeaderBlock(POIFSConstants.SMALLER_BIG_BLOCK_SIZE_DETAILS);
@@ -147,7 +147,7 @@ public final class TestPropertyTable {
 	}
 
 	@Test
-	public void testReadingConstructor() throws IOException {
+	void testReadingConstructor() throws IOException {
 
 		// first, we need the raw data blocks
 		String raw_data_array =

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/property/TestRootProperty.java Fri Jan  8 23:50:02 2021
@@ -39,7 +39,7 @@ public final class TestRootProperty {
 	private byte[] _testblock;
 
 	@Test
-	public void testConstructor() throws IOException {
+	void testConstructor() throws IOException {
 		createBasicRootProperty();
 		verifyProperty();
 	}
@@ -92,7 +92,7 @@ public final class TestRootProperty {
 	}
 
 	@Test
-	public void testSetSize() {
+	void testSetSize() {
 		for (int j = 0; j < 10; j++) {
 			createBasicRootProperty();
 			_property.setSize(j);
@@ -101,7 +101,7 @@ public final class TestRootProperty {
 	}
 
 	@Test
-	public void testReadingConstructor() {
+	void testReadingConstructor() {
 		String[] input = {
 			"52 00 6F 00 6F 00 74 00 20 00 45 00 6E 00 74 00 72 00 79 00 00 00 00 00 00 00 00 00 00 00 00 00",
 			"00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00",

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestBATBlock.java Fri Jan  8 23:50:02 2021
@@ -36,22 +36,22 @@ public final class TestBATBlock {
 
 
     @Test
-    public void testEntriesPerBlock() {
+    void testEntriesPerBlock() {
         assertEquals(128, POIFSConstants.SMALLER_BIG_BLOCK_SIZE_DETAILS.getBATEntriesPerBlock());
     }
 
     @Test
-    public void testEntriesPerXBATBlock() {
+    void testEntriesPerXBATBlock() {
         assertEquals(127, POIFSConstants.SMALLER_BIG_BLOCK_SIZE_DETAILS.getXBATEntriesPerBlock());
     }
 
     @Test
-    public void testGetXBATChainOffset() {
+    void testGetXBATChainOffset() {
         assertEquals(508, POIFSConstants.SMALLER_BIG_BLOCK_SIZE_DETAILS.getNextXBATChainOffset());
     }
 
     @Test
-    public void testCalculateMaximumSize() {
+    void testCalculateMaximumSize() {
         // Zero fat blocks isn't technically valid, but it'd be header only
         assertEquals(
                 512,
@@ -123,7 +123,7 @@ public final class TestBATBlock {
     }
 
     @Test
-    public void testUsedSectors() {
+    void testUsedSectors() {
         POIFSBigBlockSize b512 = POIFSConstants.SMALLER_BIG_BLOCK_SIZE_DETAILS;
         POIFSBigBlockSize b4096 = POIFSConstants.LARGER_BIG_BLOCK_SIZE_DETAILS;
 
@@ -177,7 +177,7 @@ public final class TestBATBlock {
     }
 
     @Test
-    public void testOccupiedSize() {
+    void testOccupiedSize() {
         POIFSBigBlockSize b512 = POIFSConstants.SMALLER_BIG_BLOCK_SIZE_DETAILS;
         POIFSBigBlockSize b4096 = POIFSConstants.LARGER_BIG_BLOCK_SIZE_DETAILS;
 
@@ -238,7 +238,7 @@ public final class TestBATBlock {
     }
 
     @Test
-    public void testGetBATBlockAndIndex() {
+    void testGetBATBlockAndIndex() {
         HeaderBlock header = new HeaderBlock(POIFSConstants.SMALLER_BIG_BLOCK_SIZE_DETAILS);
         List<BATBlock> blocks = new ArrayList<>();
         int offset;

Modified: poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestHeaderBlockReading.java Fri Jan  8 23:50:02 2021
@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
 public final class TestHeaderBlockReading {
 
 	@Test
-	public void testConstructors() throws IOException {
+	void testConstructors() throws IOException {
 		String[] hexData = {
 			"D0 CF 11 E0 A1 B1 1A E1 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 3B 00 03 00 FE FF 09 00",
 			"06 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 FE FF FF FF 00 00 00 00 00 10 00 00 FE FF FF FF",

Modified: poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestFormulaParser.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestFormulaParser.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestFormulaParser.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestFormulaParser.java Fri Jan  8 23:50:02 2021
@@ -29,7 +29,7 @@ import org.junit.jupiter.api.Test;
  */
 public class TestFormulaParser {
     @Test
-    public void testParse(){
+    void testParse(){
 
         Formula[] ops = {
             newGuide("adj1", "val 100"),

Modified: poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestPresetGeometries.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestPresetGeometries.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestPresetGeometries.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/sl/draw/geom/TestPresetGeometries.java Fri Jan  8 23:50:02 2021
@@ -32,7 +32,7 @@ import org.junit.jupiter.api.Test;
 
 public class TestPresetGeometries {
     @Test
-    public void testRead(){
+    void testRead(){
         PresetGeometries shapes = PresetGeometries.getInstance();
         assertEquals(187, shapes.size());
         assertEquals(0x4533584F, shapes.hashCode());
@@ -52,7 +52,7 @@ public class TestPresetGeometries {
 
     @Disabled("problem solved? Turn back on if this debugging is still in process.")
     @Test
-    public void testCheckXMLParser() throws Exception{
+    void testCheckXMLParser() throws Exception{
         // Gump reports a strange error because of an unavailable XML Parser, let's try to find out where
         // this comes from
         //

Modified: poi/trunk/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java?rev=1885281&r1=1885280&r2=1885281&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/TestSpreadsheetVersion.java Fri Jan  8 23:50:02 2021
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
 public final class TestSpreadsheetVersion {
 
     @Test
-    public void testExcel97(){
+    void testExcel97(){
         SpreadsheetVersion v = SpreadsheetVersion.EXCEL97;
         assertEquals(1 << 8, v.getMaxColumns());
         assertEquals(v.getMaxColumns() - 1, v.getLastColumnIndex());
@@ -39,7 +39,7 @@ public final class TestSpreadsheetVersio
     }
 
     @Test
-    public void testExcel2007(){
+    void testExcel2007(){
         SpreadsheetVersion v = SpreadsheetVersion.EXCEL2007;
         assertEquals(1 << 14, v.getMaxColumns());
         assertEquals(v.getMaxColumns() - 1, v.getLastColumnIndex());



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message