poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cen...@apache.org
Subject svn commit: r1885187 - in /poi/trunk/src: integrationtest/org/apache/poi/stress/SlideShowHandler.java ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java
Date Wed, 06 Jan 2021 09:10:22 GMT
Author: centic
Date: Wed Jan  6 09:10:21 2021
New Revision: 1885187

URL: http://svn.apache.org/viewvc?rev=1885187&view=rev
Log:
Adjust assumption for one specific font-related exception on Windows

Otherwise it triggers too much and hides actual regression bugs

Modified:
    poi/trunk/src/integrationtest/org/apache/poi/stress/SlideShowHandler.java
    poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java

Modified: poi/trunk/src/integrationtest/org/apache/poi/stress/SlideShowHandler.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/integrationtest/org/apache/poi/stress/SlideShowHandler.java?rev=1885187&r1=1885186&r2=1885187&view=diff
==============================================================================
--- poi/trunk/src/integrationtest/org/apache/poi/stress/SlideShowHandler.java (original)
+++ poi/trunk/src/integrationtest/org/apache/poi/stress/SlideShowHandler.java Wed Jan  6 09:10:21
2021
@@ -155,11 +155,13 @@ public abstract class SlideShowHandler e
                 // We saw exceptions with JDK 8 on Windows in the Jenkins CI which
                 // seem to only be triggered by some font (maybe Calibri?!)
                 // We cannot avoid this, so let's try to not make the tests fail in this
case
-                Assumptions.assumeTrue(
+                Assumptions.assumeFalse(
                         e.getMessage().equals("-1") &&
                         ExceptionUtils.readStackTrace(e).contains("ExtendedTextSourceLabel.getJustificationInfos"),
-                        "JDK sometimes fails at this point on some fonts on Windows machines,
but we" +
-                                "should not fail the build because of this");
+                        "JDK sometimes fails at this point on some fonts on Windows machines,
but we " +
+                                "should not fail the build because of this: " + ExceptionUtils.readStackTrace(e));
+
+                throw e;
             }
 
             graphics.dispose();

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java?rev=1885187&r1=1885186&r2=1885187&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ooxml/TestTriggerCoverage.java Wed Jan  6
09:10:21 2021
@@ -151,11 +151,13 @@ public class TestTriggerCoverage {
                 // We saw exceptions with JDK 8 on Windows in the Jenkins CI which
                 // seem to only be triggered by some font (maybe Calibri?!)
                 // We cannot avoid this, so let's try to not make the tests fail in this
case
-                Assumptions.assumeTrue(
+                Assumptions.assumeFalse(
                         e.getMessage().equals("-1") &&
                                 ExceptionUtils.readStackTrace(e).contains("ExtendedTextSourceLabel.getJustificationInfos"),
-                        "JDK sometimes fails at this point on some fonts on Windows machines,
but we" +
-                                "should not fail the build because of this");
+                        "JDK sometimes fails at this point on some fonts on Windows machines,
but we " +
+                                "should not fail the build because of this: " + ExceptionUtils.readStackTrace(e));
+
+                throw e;
             }
 
             graphics.dispose();



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message