poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiwiwi...@apache.org
Subject svn commit: r1847438 - in /poi/trunk: ./ src/ooxml/java/org/apache/poi/openxml4j/util/ZipInputStreamZipEntrySource.java
Date Sun, 25 Nov 2018 22:05:02 GMT
Author: kiwiwings
Date: Sun Nov 25 22:05:02 2018
New Revision: 1847438

URL: http://svn.apache.org/viewvc?rev=1847438&view=rev
Log:
#60713 - (S)XSSFWorkbook/POIXMLDocument.write(OutputStream) closes the OutputStream

regression

Modified:
    poi/trunk/   (props changed)
    poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipInputStreamZipEntrySource.java

Propchange: poi/trunk/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sun Nov 25 22:05:02 2018
@@ -1,6 +1,7 @@
 /poi/branches/common_sl:1661320-1691849
 /poi/branches/excelant:1069732-1073692
 /poi/branches/gsoc2012:1341450-1371650
+/poi/branches/hemf:1843341
 /poi/branches/hssf_cryptoapi:1753906-1762715
 /poi/branches/ss_border_property_template:1747847-1748074
 /poi/branches/xml_signature:1617139-1628347

Modified: poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipInputStreamZipEntrySource.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipInputStreamZipEntrySource.java?rev=1847438&r1=1847437&r2=1847438&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipInputStreamZipEntrySource.java
(original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipInputStreamZipEntrySource.java
Sun Nov 25 22:05:02 2018
@@ -38,7 +38,7 @@ public class ZipInputStreamZipEntrySourc
 	
 	/**
 	 * Reads all the entries from the ZipInputStream 
-	 *  into memory, and closes the source stream.
+	 *  into memory, and don't close (since POI 4.0.1) the source stream.
 	 * We'll then eat lots of memory, but be able to
 	 *  work with the entries at-will.
 	 */
@@ -50,7 +50,6 @@ public class ZipInputStreamZipEntrySourc
 			}
 			zipEntries.put(zipEntry.getName(), new ZipArchiveFakeEntry(zipEntry, inp));
 		}
-		inp.close();
 	}
 
 	@Override



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message