poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r1831572 - /poi/trunk/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java
Date Mon, 14 May 2018 14:25:00 GMT
Author: nick
Date: Mon May 14 14:25:00 2018
New Revision: 1831572

URL: http://svn.apache.org/viewvc?rev=1831572&view=rev
Log:
List a few more missing functions as inline-comments, based on definitions from functionMetadata.txt

Modified:
    poi/trunk/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java?rev=1831572&r1=1831571&r2=1831572&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java Mon May 14 14:25:00
2018
@@ -138,7 +138,6 @@ public final class FunctionEval {
         retval[72] = CalendarFieldFunction.MINUTE;
         retval[73] = CalendarFieldFunction.SECOND;
         retval[74] = new Now();
-        // 75: AREAS
         retval[75] = new Areas();
         retval[76] = new Rows();
         retval[77] = new Columns();
@@ -173,12 +172,19 @@ public final class FunctionEval {
         retval[121] = new Code();
 
         retval[124] = TextFunction.FIND;
+        // 125: CELL
 
         retval[126] = LogicalFunction.ISERR;
         retval[127] = LogicalFunction.ISTEXT;
         retval[128] = LogicalFunction.ISNUMBER;
         retval[129] = LogicalFunction.ISBLANK;
         retval[130] = new T();
+        // 131: N
+        // 140: DATEVALUE
+        // 141: TIMEVALUE
+        // 142: SLN
+        // 143: SYD
+        // 144: DDB
 
         retval[FunctionID.INDIRECT] = null; // Indirect.evaluate has different signature
 
@@ -195,12 +201,15 @@ public final class FunctionEval {
         retval[183] = AggregateFunction.PRODUCT;
         retval[184] = NumericFunction.FACT;
 
+        // 189: DPRODUCT
         retval[190] = LogicalFunction.ISNONTEXT;
 
         retval[194] = AggregateFunction.VARP;
-
+        // 195: DSTDEVP
+        // 196: DVARP
         retval[197] = NumericFunction.TRUNC;
         retval[198] = LogicalFunction.ISLOGICAL;
+        // 199: DCOUNTA
 
         //204: USDOLLAR (YEN in BIFF3)
         //205: FINDB
@@ -233,6 +242,7 @@ public final class FunctionEval {
         // 244: INFO
 
         // 247: DB
+        // 252: FEQUENCY
         
         retval[FunctionID.EXTERNAL_FUNC] = null; // ExternalFunction is a FreeRefFunction,
nominally 255
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message