poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r1791108 - in /poi/trunk/src/ooxml: java/org/apache/poi/xdgf/usermodel/section/geometry/GeometryRowFactory.java testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java
Date Wed, 12 Apr 2017 11:11:56 GMT
Author: nick
Date: Wed Apr 12 11:11:56 2017
New Revision: 1791108

URL: http://svn.apache.org/viewvc?rev=1791108&view=rev
Log:
#60973 XDGF Support for "PolylineTo" as well as existing alternate spelling "PolyLineTo"

Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/GeometryRowFactory.java
    poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/GeometryRowFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/GeometryRowFactory.java?rev=1791108&r1=1791107&r2=1791108&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/GeometryRowFactory.java
(original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/GeometryRowFactory.java
Wed Apr 12 11:11:56 2017
@@ -37,6 +37,8 @@ public class GeometryRowFactory {
             _rowTypes.put("LineTo", LineTo.class, RowType.class);
             _rowTypes.put("MoveTo", MoveTo.class, RowType.class);
             _rowTypes.put("NURBSTo", NURBSTo.class, RowType.class);
+            // Note - two different spellings depending on version used...!
+            _rowTypes.put("PolylineTo", PolyLineTo.class, RowType.class);
             _rowTypes.put("PolyLineTo", PolyLineTo.class, RowType.class);
             _rowTypes.put("RelCubBezTo", RelCubBezTo.class, RowType.class);
             _rowTypes.put("RelEllipticalArcTo", RelEllipticalArcTo.class,

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java?rev=1791108&r1=1791107&r2=1791108&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java
(original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xdgf/extractor/TestXDGFVisioExtractor.java
Wed Apr 12 11:11:56 2017
@@ -16,9 +16,8 @@
 ==================================================================== */
 package org.apache.poi.xdgf.extractor;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
 import static org.apache.poi.POITestCase.assertContains;
+import static org.junit.Assert.assertEquals;
 
 import java.io.IOException;
 import java.io.InputStream;
@@ -28,7 +27,6 @@ import org.apache.poi.openxml4j.opc.OPCP
 import org.apache.poi.xdgf.usermodel.XmlVisioDocument;
 import org.junit.After;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 
 public class TestXDGFVisioExtractor {
@@ -79,13 +77,13 @@ public class TestXDGFVisioExtractor {
     }
     
     /**
-     * Currently failing with:
+     * Some confusion on PolylineTo vs PolyLineTo, both should be handled.
+     * Previously failed with:
      * org.apache.poi.POIXMLException: Invalid 'Row_Type' name 'PolylineTo'
      *  at org.apache.poi.xdgf.util.ObjectFactory.load
      *  at org.apache.poi.xdgf.usermodel.section.geometry.GeometryRowFactory.load
      */
     @Test
-    @Ignore("TODO Fix bug #60973")
     public void testPolylineTo() throws IOException {
         InputStream is = SAMPLES.openResourceAsStream("60973.vsdx");
         XmlVisioDocument document = new XmlVisioDocument(is);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message