poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From one...@apache.org
Subject svn commit: r1765544 - in /poi/trunk/src: ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java testcases/org/apache/poi/hssf/usermodel/TestBugs.java
Date Wed, 19 Oct 2016 07:37:47 GMT
Author: onealj
Date: Wed Oct 19 07:37:47 2016
New Revision: 1765544

URL: http://svn.apache.org/viewvc?rev=1765544&view=rev
Log:
disabled unit tests are now passing for bug 48703

Modified:
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
    poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java?rev=1765544&r1=1765543&r2=1765544&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java Wed Oct
19 07:37:47 2016
@@ -1354,9 +1354,7 @@ public final class TestXSSFBugs extends
     /**
      * Sum across multiple workbooks
      *  eg =SUM($Sheet1.C1:$Sheet4.C1)
-     * DISABLED As we can't currently evaluate these
      */
-    @Ignore
     @Test
     public void bug48703() throws IOException {
         XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook("48703.xlsx");

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java?rev=1765544&r1=1765543&r2=1765544&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java Wed Oct 19 07:37:47
2016
@@ -2373,9 +2373,8 @@ public final class TestBugs extends Base
     /**
      * Sum across multiple workbooks
      *  eg =SUM($Sheet2.A1:$Sheet3.A1)
-     * DISABLED - We currently get the formula wrong, and mis-evaluate
      */
-    @Ignore
+    @Test
     public void test48703() throws Exception {
         HSSFWorkbook wb = openSample("48703.xls");
         assertEquals(3, wb.getNumberOfSheets());
@@ -2385,7 +2384,7 @@ public final class TestBugs extends Base
         Row r = sheet.getRow(0);
         Cell c = r.getCell(0);
 
-        assertEquals("SUM(Sheet2!A1:Sheet3!A1)", c.getCellFormula());
+        assertEquals("SUM(Sheet2:Sheet3!A1)", c.getCellFormula());
         assertEquals(4.0, c.getNumericCellValue(), 0);
 
         // Check the evaluated result



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message