Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 28C59200B45 for ; Fri, 15 Jul 2016 09:41:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 27841160A6C; Fri, 15 Jul 2016 07:41:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6F3DF160A61 for ; Fri, 15 Jul 2016 09:41:31 +0200 (CEST) Received: (qmail 51636 invoked by uid 500); 15 Jul 2016 07:41:30 -0000 Mailing-List: contact commits-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@poi.apache.org Delivered-To: mailing list commits@poi.apache.org Received: (qmail 51627 invoked by uid 99); 15 Jul 2016 07:41:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2016 07:41:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 08B0FC0B66 for ; Fri, 15 Jul 2016 07:41:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.426 X-Spam-Level: X-Spam-Status: No, score=-0.426 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id TrphGnsG8Hkb for ; Fri, 15 Jul 2016 07:41:29 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTP id CB96E5F3FC for ; Fri, 15 Jul 2016 07:41:28 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B110FE0220 for ; Fri, 15 Jul 2016 07:41:27 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 23CAB3A0A8D for ; Fri, 15 Jul 2016 07:41:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1752788 - /poi/trunk/src/java/org/apache/poi/ss/formula/functions/TextFunction.java Date: Fri, 15 Jul 2016 07:41:26 -0000 To: commits@poi.apache.org From: onealj@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20160715074127.23CAB3A0A8D@svn01-us-west.apache.org> archived-at: Fri, 15 Jul 2016 07:41:32 -0000 Author: onealj Date: Fri Jul 15 07:41:26 2016 New Revision: 1752788 URL: http://svn.apache.org/viewvc?rev=1752788&view=rev Log: replace for-loop over index with for-each loop Modified: poi/trunk/src/java/org/apache/poi/ss/formula/functions/TextFunction.java Modified: poi/trunk/src/java/org/apache/poi/ss/formula/functions/TextFunction.java URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/functions/TextFunction.java?rev=1752788&r1=1752787&r2=1752788&view=diff ============================================================================== --- poi/trunk/src/java/org/apache/poi/ss/formula/functions/TextFunction.java (original) +++ poi/trunk/src/java/org/apache/poi/ss/formula/functions/TextFunction.java Fri Jul 15 07:41:26 2016 @@ -157,8 +157,7 @@ public abstract class TextFunction imple public static final Function CLEAN = new SingleArgTextFunc() { protected ValueEval evaluate(String arg) { StringBuilder result = new StringBuilder(); - for (int i = 0; i < arg.length(); i++) { - char c = arg.charAt(i); + for (final char c : arg.toCharArray()) { if (isPrintable(c)) { result.append(c); } @@ -178,7 +177,7 @@ public abstract class TextFunction imple * @return whether the character is printable */ private boolean isPrintable(char c){ - return (int) c >= 32; + return c >= 32; } }; --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org For additional commands, e-mail: commits-help@poi.apache.org