poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From one...@apache.org
Subject svn commit: r1748658 - in /poi/trunk/src: java/org/apache/poi/hssf/usermodel/HSSFFont.java java/org/apache/poi/ss/usermodel/Font.java ooxml/java/org/apache/poi/xssf/usermodel/XSSFFont.java ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java
Date Thu, 16 Jun 2016 06:51:54 GMT
Author: onealj
Date: Thu Jun 16 06:51:53 2016
New Revision: 1748658

URL: http://svn.apache.org/viewvc?rev=1748658&view=rev
Log:
bug 55385: deprecate Font.getBoldweight and Font.setBoldweight

Modified:
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFFont.java
    poi/trunk/src/java/org/apache/poi/ss/usermodel/Font.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFFont.java
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFFont.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFFont.java?rev=1748658&r1=1748657&r2=1748658&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFFont.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFFont.java Thu Jun 16 06:51:53 2016
@@ -205,6 +205,7 @@ public final class HSSFFont implements F
      * @param boldweight
      * @see #BOLDWEIGHT_NORMAL
      * @see #BOLDWEIGHT_BOLD
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17. Use {@link #setBold(boolean)}
instead.
      */
     public void setBoldweight(short boldweight)
     {
@@ -227,6 +228,7 @@ public final class HSSFFont implements F
      * @return boldweight
      * @see #BOLDWEIGHT_NORMAL
      * @see #BOLDWEIGHT_BOLD
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17. Use {@link #getBold} instead.
      */
     public short getBoldweight()
     {

Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/Font.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/Font.java?rev=1748658&r1=1748657&r2=1748658&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/Font.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/Font.java Thu Jun 16 06:51:53 2016
@@ -21,14 +21,16 @@ package org.apache.poi.ss.usermodel;
 public interface Font {
     /**
      * Normal boldness (not bold)
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17.
+     * Boldweight constants no longer needed due to {@link #getBold} and {@link #setBold(boolean)}
      */
-
     public final static short BOLDWEIGHT_NORMAL = 0x190;
 
     /**
      * Bold boldness (bold)
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17.
+     * Boldweight constants no longer needed due to {@link #getBold} and {@link #setBold(boolean)}
      */
-
     public final static short BOLDWEIGHT_BOLD = 0x2bc;
 
     /**
@@ -281,9 +283,15 @@ public interface Font {
      */
     public short getIndex();
 
+    /**
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17. Use {@link #setBold(boolean)}.
+     */
     public void setBoldweight(short boldweight);
     public void setBold(boolean bold);
 
+    /**
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17. Use {@link #getBold()}.
+     */
     public short getBoldweight();
     public boolean getBold();
-}
\ No newline at end of file
+}

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFFont.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFFont.java?rev=1748658&r1=1748657&r2=1748658&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFFont.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFFont.java Thu Jun 16 06:51:53
2016
@@ -297,6 +297,9 @@ public class XSSFFont implements Font {
         }
     }
 
+    /**
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17. Use {@link #setBold(boolean)}
instead.
+     */
     public void setBoldweight(short boldweight)
     {
         setBold(boldweight == BOLDWEIGHT_BOLD);
@@ -307,8 +310,8 @@ public class XSSFFont implements Font {
      * @return boldweight
      * @see #BOLDWEIGHT_NORMAL
      * @see #BOLDWEIGHT_BOLD
+     * @deprecated 3.15 beta 2. Scheduled for removal in 3.17. Use {@link #getBold} instead.
      */
-
     public short getBoldweight()
     {
         return getBold() ? BOLDWEIGHT_BOLD : BOLDWEIGHT_NORMAL;

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java?rev=1748658&r1=1748657&r2=1748658&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFont.java Thu Jun
16 06:51:53 2016
@@ -69,7 +69,7 @@ public final class TestXSSFFont extends
 	}
 
 	@Test
-	public void testBoldweight() {
+	public void testBold() {
 		CTFont ctFont=CTFont.Factory.newInstance();
 		CTBooleanProperty bool=ctFont.addNewB();
 		bool.setVal(false);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message