poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From one...@apache.org
Subject svn commit: r1748090 - in /poi/trunk/src: java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java java/org/apache/poi/ss/util/AreaReference.java ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
Date Mon, 13 Jun 2016 06:38:53 GMT
Author: onealj
Date: Mon Jun 13 06:38:53 2016
New Revision: 1748090

URL: http://svn.apache.org/viewvc?rev=1748090&view=rev
Log:
findbugs: fix SF_SWITCH_NO_DEFAULT warnings

Modified:
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java
    poi/trunk/src/java/org/apache/poi/ss/util/AreaReference.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java?rev=1748090&r1=1748089&r2=1748090&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFHyperlink.java Mon Jun 13 06:38:53
2016
@@ -78,6 +78,8 @@ public class HSSFHyperlink implements Hy
             case LINK_DOCUMENT:
                 record.newDocumentLink();
                 break;
+            default:
+                throw new IllegalArgumentException("Invalid type: " + type);
         }
     }
 

Modified: poi/trunk/src/java/org/apache/poi/ss/util/AreaReference.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/AreaReference.java?rev=1748090&r1=1748089&r2=1748090&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/util/AreaReference.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/util/AreaReference.java Mon Jun 13 06:38:53 2016
@@ -355,10 +355,11 @@ public class AreaReference {
                         }
                         delimiterPos = i;
                     }
+                    // fall through
                 default:
-                    continue;
+                    continue; //continue the for-loop
                 case SPECIAL_NAME_DELIMITER:
-                    // fall through
+                    break;
             }
             if(!insideDelimitedName) {
                 insideDelimitedName = true;

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java?rev=1748090&r1=1748089&r2=1748090&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFCell.java Mon Jun 13 06:38:53
2016
@@ -779,6 +779,10 @@ public class SXSSFCell implements Cell {
                     current=new HyperlinkProperty(value);
                     break;
                 }
+                default:
+                {
+                    throw new IllegalArgumentException("Invalid type: " + type);
+                }
             }
             if(previous!=null)
             {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message