poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From one...@apache.org
Subject svn commit: r1747878 - in /poi/trunk: src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java test-data/spreadsheet/StructuredRefs-lots-with-lookups.xlsx
Date Sat, 11 Jun 2016 11:28:55 GMT
Author: onealj
Date: Sat Jun 11 11:28:55 2016
New Revision: 1747878

URL: http://svn.apache.org/viewvc?rev=1747878&view=rev
Log:
bug 57840: add disabled unit test with large number of structured reference formulas
patch and spreadsheet contributed by Mark Woolsey

Added:
    poi/trunk/test-data/spreadsheet/StructuredRefs-lots-with-lookups.xlsx   (with props)
Modified:
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java?rev=1747878&r1=1747877&r2=1747878&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java
(original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFFormulaEvaluation.java
Sat Jun 11 11:28:55 2016
@@ -609,10 +609,20 @@ public final class TestXSSFFormulaEvalua
     // bug 57721
     @Test
     public void structuredReferences() throws IOException {
-        XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook("evaluate_formula_with_structured_table_references.xlsx");
-        
-        XSSFFormulaEvaluator.evaluateAllFormulaCells(wb);
+        verifyAllFormulasInWorkbookCanBeEvaluated("evaluate_formula_with_structured_table_references.xlsx");
+    }
+    
+    // bug 57840
+    @Ignore("Takes over a minute to evaluate all formulas in this large workbook. Run this
test when profiling for formula evaluation speed.")
+    @Test
+    public void testLotsOfFormulasWithStructuredReferencesToCalculatedTableColumns() throws
IOException {
+        verifyAllFormulasInWorkbookCanBeEvaluated("StructuredRefs-lots-with-lookups.xlsx");
+    }
 
+    // FIXME: use junit4 parameterization
+    private static void verifyAllFormulasInWorkbookCanBeEvaluated(String sampleWorkbook)
throws IOException {
+        XSSFWorkbook wb = XSSFTestDataSamples.openSampleWorkbook(sampleWorkbook);
+        XSSFFormulaEvaluator.evaluateAllFormulaCells(wb);
         wb.close();
     }
 

Added: poi/trunk/test-data/spreadsheet/StructuredRefs-lots-with-lookups.xlsx
URL: http://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/StructuredRefs-lots-with-lookups.xlsx?rev=1747878&view=auto
==============================================================================
Binary file - no diff available.

Propchange: poi/trunk/test-data/spreadsheet/StructuredRefs-lots-with-lookups.xlsx
------------------------------------------------------------------------------
    svn:mime-type = application/octet-stream



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message