Mailing-List: contact commits-help@poi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@poi.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1737923 -
 /poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java
Date: Wed, 06 Apr 2016 06:01:26 -0000
To: commits@poi.apache.org
From: onealj@apache.org
Message-Id: <20160406060127.1D94F3A0220@svn01-us-west.apache.org>

Author: onealj
Date: Wed Apr  6 06:01:26 2016
New Revision: 1737923

URL: http://svn.apache.org/viewvc?rev=1737923&view=rev
Log:
add test coverage for TestSXSSFCell.toString() on blank and date cells

Modified:
    poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java

Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java?rev=1737923&r1=1737922&r2=1737923&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/BaseTestCell.java Wed Apr  6 06:01:26 2016
@@ -294,12 +294,28 @@ public abstract class BaseTestCell {
         r.createCell(2).setCellValue(factory.createRichTextString("Astring"));
         r.createCell(3).setCellErrorValue(FormulaError.DIV0.getCode());
         r.createCell(4).setCellFormula("A1+B1");
+        r.createCell(5); // blank
+
+        // create date-formatted cell
+        Calendar c = LocaleUtil.getLocaleCalendar();
+        c.set(2010, 01, 02, 00, 00, 00);
+        r.createCell(6).setCellValue(c);
+        CellStyle dateStyle = wb1.createCellStyle();
+        short formatId = wb1.getCreationHelper().createDataFormat().getFormat("m/d/yy h:mm"); // any date format will do
+        dateStyle.setDataFormat(formatId);
+        r.getCell(6).setCellStyle(dateStyle);
 
         assertEquals("Boolean", "TRUE", r.getCell(0).toString());
         assertEquals("Numeric", "1.5", r.getCell(1).toString());
         assertEquals("String", "Astring", r.getCell(2).toString());
         assertEquals("Error", "#DIV/0!", r.getCell(3).toString());
         assertEquals("Formula", "A1+B1", r.getCell(4).toString());
+        assertEquals("Blank", "", r.getCell(5).toString());
+        // toString on a date-formatted cell displays dates as dd-MMM-yyyy, which has locale problems with the month
+        String dateCell1 = r.getCell(6).toString();
+        assertTrue("Date (Day)", dateCell1.startsWith("02-"));
+        assertTrue("Date (Year)", dateCell1.endsWith("-2010"));
+
 
         //Write out the file, read it in, and then check cell values
         Workbook wb2 = _testDataProvider.writeOutAndReadBack(wb1);
@@ -311,6 +327,9 @@ public abstract class BaseTestCell {
         assertEquals("String", "Astring", r.getCell(2).toString());
         assertEquals("Error", "#DIV/0!", r.getCell(3).toString());
         assertEquals("Formula", "A1+B1", r.getCell(4).toString());
+        assertEquals("Blank", "", r.getCell(5).toString());
+        String dateCell2 = r.getCell(6).toString();
+        assertEquals("Date", dateCell1, dateCell2);
         wb2.close();
     }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org