poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cen...@apache.org
Subject svn commit: r1732235 - in /poi/trunk: src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java test-data/spreadsheet/47245_test.xls
Date Wed, 24 Feb 2016 22:39:11 GMT
Author: centic
Date: Wed Feb 24 22:39:11 2016
New Revision: 1732235

URL: http://svn.apache.org/viewvc?rev=1732235&view=rev
Log:
Bug 47245: Comment out check and exception in case row-records are missing for some cells
as it seems POI is handling this gracefully and LibreOffice/Excel are as well

Added:
    poi/trunk/test-data/spreadsheet/47245_test.xls
Modified:
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java?rev=1732235&r1=1732234&r2=1732235&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFSheet.java Wed Feb 24 22:39:11 2016
@@ -209,12 +209,14 @@ public final class HSSFSheet implements
                 hrow = getRow(cval.getRow());
                 lastrow = hrow;
                 if (hrow == null) {
+                    /* we removed this check, see bug 47245 for the discussion around this
                     // Some tools (like Perl module Spreadsheet::WriteExcel - bug 41187)
skip the RowRecords
                     // Excel, OpenOffice.org and GoogleDocs are all OK with this, so POI
should be too.
                     if (rowRecordsAlreadyPresent) {
                         // if at least one row record is present, all should be present.
                         throw new RuntimeException("Unexpected missing row when some rows
already present");
-                    }
+                    }*/
+
                     // create the row record on the fly now.
                     RowRecord rowRec = new RowRecord(cval.getRow());
                     sheet.addRow(rowRec);

Added: poi/trunk/test-data/spreadsheet/47245_test.xls
URL: http://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/47245_test.xls?rev=1732235&view=auto
==============================================================================
Binary files poi/trunk/test-data/spreadsheet/47245_test.xls (added) and poi/trunk/test-data/spreadsheet/47245_test.xls
Wed Feb 24 22:39:11 2016 differ



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message