Return-Path: X-Original-To: apmail-poi-commits-archive@minotaur.apache.org Delivered-To: apmail-poi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 755F518DEF for ; Sat, 16 Jan 2016 22:23:08 +0000 (UTC) Received: (qmail 41598 invoked by uid 500); 16 Jan 2016 22:23:08 -0000 Delivered-To: apmail-poi-commits-archive@poi.apache.org Received: (qmail 41561 invoked by uid 500); 16 Jan 2016 22:23:08 -0000 Mailing-List: contact commits-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@poi.apache.org Delivered-To: mailing list commits@poi.apache.org Received: (qmail 41552 invoked by uid 99); 16 Jan 2016 22:23:08 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Jan 2016 22:23:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D90FBC023A for ; Sat, 16 Jan 2016 22:23:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.446 X-Spam-Level: X-Spam-Status: No, score=0.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.554] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Sx6w6R8W0mO7 for ; Sat, 16 Jan 2016 22:23:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id F384C2051D for ; Sat, 16 Jan 2016 22:23:06 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6BF74E0239 for ; Sat, 16 Jan 2016 22:23:06 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 426263A027B for ; Sat, 16 Jan 2016 22:23:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1725042 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java Date: Sat, 16 Jan 2016 22:23:06 -0000 To: commits@poi.apache.org From: onealj@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20160116222306.426263A027B@svn01-us-west.apache.org> Author: onealj Date: Sat Jan 16 22:23:05 2016 New Revision: 1725042 URL: http://svn.apache.org/viewvc?rev=1725042&view=rev Log: fix questionable List.remove(int) in SXSSFITestDataProvider Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java?rev=1725042&r1=1725041&r2=1725042&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java Sat Jan 16 22:23:05 2016 @@ -24,7 +24,7 @@ import java.io.ByteArrayOutputStream; import java.io.IOException; import java.io.InputStream; import java.util.ArrayList; -import java.util.List; +import java.util.Collection; import org.apache.poi.POIDataSamples; import org.apache.poi.ss.ITestDataProvider; @@ -43,7 +43,7 @@ public final class SXSSFITestDataProvide // an instance of all SXSSFWorkbooks opened by this TestDataProvider, // so that the temporary files created can be disposed up by cleanup() - private final List instances = new ArrayList(); + private final Collection instances = new ArrayList(); private SXSSFITestDataProvider() { // enforce singleton @@ -107,11 +107,10 @@ public final class SXSSFITestDataProvide public synchronized boolean cleanup(){ boolean ok = true; - for(int i = 0; i < instances.size(); i++){ - SXSSFWorkbook wb = instances.get(i); + for(final SXSSFWorkbook wb : instances) { ok = ok && wb.dispose(); - instances.remove(i); } + instances.clear(); return ok; } } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org For additional commands, e-mail: commits-help@poi.apache.org