Return-Path: X-Original-To: apmail-poi-commits-archive@minotaur.apache.org Delivered-To: apmail-poi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F6091868B for ; Tue, 29 Dec 2015 10:42:46 +0000 (UTC) Received: (qmail 42045 invoked by uid 500); 29 Dec 2015 10:42:46 -0000 Delivered-To: apmail-poi-commits-archive@poi.apache.org Received: (qmail 42009 invoked by uid 500); 29 Dec 2015 10:42:46 -0000 Mailing-List: contact commits-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@poi.apache.org Delivered-To: mailing list commits@poi.apache.org Received: (qmail 41999 invoked by uid 99); 29 Dec 2015 10:42:46 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Dec 2015 10:42:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A6C5AC040D for ; Tue, 29 Dec 2015 10:42:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.999 X-Spam-Level: X-Spam-Status: No, score=0.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5bbj-fxejJSm for ; Tue, 29 Dec 2015 10:42:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id 246FD20265 for ; Tue, 29 Dec 2015 10:42:45 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B2DDDE0479 for ; Tue, 29 Dec 2015 10:42:44 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 981323A0A9F for ; Tue, 29 Dec 2015 10:43:40 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1722093 - /poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java Date: Tue, 29 Dec 2015 10:43:40 -0000 To: commits@poi.apache.org From: onealj@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20151229104340.981323A0A9F@svn01-us-west.apache.org> Author: onealj Date: Tue Dec 29 10:43:40 2015 New Revision: 1722093 URL: http://svn.apache.org/viewvc?rev=1722093&view=rev Log: move comment Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java?rev=1722093&r1=1722092&r2=1722093&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java Tue Dec 29 10:43:40 2015 @@ -73,7 +73,6 @@ public final class TestWorkbookFactory { * @param wb the workbook to close or revert */ private static void closeOrRevert(Workbook wb) throws IOException { - // TODO: close() re-writes the sample-file?! Resort to revert() for now to close file handle... if (wb instanceof HSSFWorkbook) { wb.close(); } @@ -83,6 +82,7 @@ public final class TestWorkbookFactory { xwb.close(); } else { + // TODO: close() re-writes the sample-file?! Resort to revert() for now to close file handle... LOGGER.log(POILogger.WARN, "reverting XSSFWorkbook rather than closing it to avoid close() modifying the file on disk. " + "Refer to bug 58779."); --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org For additional commands, e-mail: commits-help@poi.apache.org