Return-Path: X-Original-To: apmail-poi-commits-archive@minotaur.apache.org Delivered-To: apmail-poi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 759EE18CBC for ; Sun, 27 Dec 2015 23:16:44 +0000 (UTC) Received: (qmail 41449 invoked by uid 500); 27 Dec 2015 23:16:44 -0000 Delivered-To: apmail-poi-commits-archive@poi.apache.org Received: (qmail 41408 invoked by uid 500); 27 Dec 2015 23:16:44 -0000 Mailing-List: contact commits-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@poi.apache.org Delivered-To: mailing list commits@poi.apache.org Received: (qmail 41399 invoked by uid 99); 27 Dec 2015 23:16:44 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Dec 2015 23:16:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ACD74C1563 for ; Sun, 27 Dec 2015 23:16:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.999 X-Spam-Level: X-Spam-Status: No, score=0.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id cWSeSoYNkbkP for ; Sun, 27 Dec 2015 23:16:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTP id 727D9210B2 for ; Sun, 27 Dec 2015 23:16:42 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6BAF0E05E0 for ; Sun, 27 Dec 2015 23:16:41 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 4C4BF3A023C for ; Sun, 27 Dec 2015 23:17:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1721857 - /poi/trunk/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java Date: Sun, 27 Dec 2015 23:17:34 -0000 To: commits@poi.apache.org From: onealj@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20151227231734.4C4BF3A023C@svn01-us-west.apache.org> Author: onealj Date: Sun Dec 27 23:17:33 2015 New Revision: 1721857 URL: http://svn.apache.org/viewvc?rev=1721857&view=rev Log: bug 58740: return unmodifiable list/map when exposing internal data structures patch from Archie Cobbs Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java?rev=1721857&r1=1721856&r2=1721857&view=diff ============================================================================== --- poi/trunk/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java (original) +++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/model/StylesTable.java Sun Dec 27 23:17:33 2015 @@ -24,6 +24,7 @@ import java.io.InputStream; import java.io.OutputStream; import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -301,19 +302,19 @@ public class StylesTable extends POIXMLD } public List getBorders(){ - return borders; + return Collections.unmodifiableList(borders); } public List getFills(){ - return fills; + return Collections.unmodifiableList(fills); } public List getFonts(){ - return fonts; + return Collections.unmodifiableList(fonts); } public Map getNumberFormats(){ - return numberFormats; + return Collections.unmodifiableMap(numberFormats); } public int putFill(XSSFCellFill fill) { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org For additional commands, e-mail: commits-help@poi.apache.org