poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From one...@apache.org
Subject svn commit: r1722073 - /poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java
Date Tue, 29 Dec 2015 08:53:47 GMT
Author: onealj
Date: Tue Dec 29 08:53:46 2015
New Revision: 1722073

URL: http://svn.apache.org/viewvc?rev=1722073&view=rev
Log:
make spreadsheet file names static final rather than initializing them with setUp()

Modified:
    poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java?rev=1722073&r1=1722072&r2=1722073&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/TestWorkbookFactory.java Tue Dec 29 08:53:46
2015
@@ -36,19 +36,11 @@ import org.apache.poi.openxml4j.opc.OPCP
 import junit.framework.TestCase;
 
 public final class TestWorkbookFactory extends TestCase {
-    private String xls;
-    private String xlsx;
-    private String[] xls_prot;
-    private String[] xlsx_prot;
-    private String txt;
-
-    protected void setUp() {
-        xls = "SampleSS.xls";
-        xlsx = "SampleSS.xlsx";
-        xls_prot = new String[] {"password.xls", "password"};
-        xlsx_prot = new String[]{"protected_passtika.xlsx", "tika"};
-        txt = "SampleSS.txt";
-    }
+    private static final String xls = "SampleSS.xls";
+    private static final String xlsx = "SampleSS.xlsx";
+    private static final String[] xls_prot = new String[] {"password.xls", "password"};
+    private static final String[] xlsx_prot = new String[]{"protected_passtika.xlsx", "tika"};
+    private static final String txt = "SampleSS.txt";
 
     public void testCreateNative() throws Exception {
         Workbook wb;



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message