poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From one...@apache.org
Subject svn commit: r1717079 - in /poi/trunk/src: java/org/apache/poi/util/NotImplemented.java ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
Date Sun, 29 Nov 2015 15:31:58 GMT
Author: onealj
Date: Sun Nov 29 15:31:57 2015
New Revision: 1717079

URL: http://svn.apache.org/viewvc?rev=1717079&view=rev
Log:
bug 57844: add NotImplemented annotation to SXSSFSheet.shiftRows

Added:
    poi/trunk/src/java/org/apache/poi/util/NotImplemented.java
      - copied, changed from r1717070, poi/trunk/src/java/org/apache/poi/util/Internal.java
Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java

Copied: poi/trunk/src/java/org/apache/poi/util/NotImplemented.java (from r1717070, poi/trunk/src/java/org/apache/poi/util/Internal.java)
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/NotImplemented.java?p2=poi/trunk/src/java/org/apache/poi/util/NotImplemented.java&p1=poi/trunk/src/java/org/apache/poi/util/Internal.java&r1=1717070&r2=1717079&rev=1717079&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/Internal.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/NotImplemented.java Sun Nov 29 15:31:57 2015
@@ -23,16 +23,14 @@ import java.lang.annotation.Documented;
 
 
 /**
- * Program elements annotated @Internal are intended for
- * POI internal use only. Such elements are not public by design
- * and likely to be removed in future versions of POI  or access
- * to such elements will be changed from 'public' to 'default' or less.
+ * This feature has not been implemented yet.
+ * Calling this method will result in a raised Exception
+ * at runtime.
  *
- * @author Yegor Kozlov
- * @since POI-3.6
+ * @since POI-3.14beta1
  */
 @Documented
 @Retention(RetentionPolicy.RUNTIME)
-public @interface Internal {
-    String value() default "";    
+public @interface NotImplemented {
+    String value() default "";
 }

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java?rev=1717079&r1=1717078&r2=1717079&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java Sun Nov 29 15:31:57
2015
@@ -44,6 +44,7 @@ import org.apache.poi.ss.util.CellAddres
 import org.apache.poi.ss.util.CellRangeAddress;
 import org.apache.poi.ss.util.SheetUtil;
 import org.apache.poi.util.Internal;
+import org.apache.poi.util.NotImplemented;
 import org.apache.poi.xssf.usermodel.XSSFComment;
 import org.apache.poi.xssf.usermodel.XSSFDataValidation;
 import org.apache.poi.xssf.usermodel.XSSFHyperlink;
@@ -933,6 +934,7 @@ public class SXSSFSheet implements Sheet
      * @param endRow the row to end shifting
      * @param n the number of rows to shift
      */
+    @NotImplemented
     @Override
     public void shiftRows(int startRow, int endRow, int n)
     {
@@ -956,6 +958,7 @@ public class SXSSFSheet implements Sheet
      * @param copyRowHeight whether to copy the row height during the shift
      * @param resetOriginalRowHeight whether to set the original row's height to the default
      */
+    @NotImplemented
     @Override
     public void shiftRows(int startRow, int endRow, int n, boolean copyRowHeight, boolean
resetOriginalRowHeight)
     {
@@ -1306,7 +1309,7 @@ public class SXSSFSheet implements Sheet
             collapseRow(row);
         } else {
             //expandRow(rowIndex);
-            throw new RuntimeException("Not Implemented");
+            throw new RuntimeException("Unable to expand row: Not Implemented");
         }
     }
     



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message