poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From one...@apache.org
Subject svn commit: r1711920 - in /poi/trunk/src: ooxml/testcases/org/apache/poi/ss/formula/TestFormulaParser.java testcases/org/apache/poi/hssf/model/TestFormulaParser.java
Date Mon, 02 Nov 2015 09:23:12 GMT
Author: onealj
Date: Mon Nov  2 09:23:12 2015
New Revision: 1711920

URL: http://svn.apache.org/viewvc?rev=1711920&view=rev
Log:
don't leave behind files when running unit tests. In the future this should be revisited to
verify POI isn't writing workbooks that are unopenable/corrupt by applications that read POI's
formats (MS Office, OpenOffice, LibreOffice, etc)

Modified:
    poi/trunk/src/ooxml/testcases/org/apache/poi/ss/formula/TestFormulaParser.java
    poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/ss/formula/TestFormulaParser.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/ss/formula/TestFormulaParser.java?rev=1711920&r1=1711919&r2=1711920&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/ss/formula/TestFormulaParser.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/ss/formula/TestFormulaParser.java Mon Nov
 2 09:23:12 2015
@@ -114,11 +114,15 @@ public class TestFormulaParser extends T
             XSSFTestDataSamples.writeOutAndReadBack(wb).close();
             
             // Manually check to make sure file isn't corrupted
+            // TODO: develop a process for occasionally manually reviewing workbooks
+            // to verify workbooks are not corrupted
+            /*
             final File fileIn = XSSFTestDataSamples.getSampleFile(testFile);
             final File reSavedFile = new File(fileIn.getParentFile(), fileIn.getName().replace(".xlsm",
"-saved.xlsm"));
             final FileOutputStream fos = new FileOutputStream(reSavedFile);
             wb.write(fos);
             fos.close();
+            */
         } finally {
             wb.close();
         }

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java?rev=1711920&r1=1711919&r2=1711920&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/model/TestFormulaParser.java Mon Nov  2 09:23:12
2015
@@ -161,11 +161,15 @@ public final class TestFormulaParser ext
 				assertEqualsIgnoreCase("yourFunc", wb2.getName("yourFunc").getNameName());
 
 				// Manually check to make sure file isn't corrupted
+				// TODO: develop a process for occasionally manually reviewing workbooks
+				// to verify workbooks are not corrupted
+				/*
 				final File fileIn = HSSFTestDataSamples.getSampleFile(testFile);
 				final File reSavedFile = new File(fileIn.getParentFile(), fileIn.getName().replace(".xls",
"-saved.xls"));
 				FileOutputStream fos = new FileOutputStream(reSavedFile);
 				wb2.write(fos);
 				fos.close();
+				*/
 			} finally {
 				wb2.close();
 			}



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message