Return-Path: X-Original-To: apmail-poi-commits-archive@minotaur.apache.org Delivered-To: apmail-poi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2157A18F56 for ; Sat, 31 Oct 2015 23:13:39 +0000 (UTC) Received: (qmail 72166 invoked by uid 500); 31 Oct 2015 23:13:38 -0000 Delivered-To: apmail-poi-commits-archive@poi.apache.org Received: (qmail 72129 invoked by uid 500); 31 Oct 2015 23:13:38 -0000 Mailing-List: contact commits-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@poi.apache.org Delivered-To: mailing list commits@poi.apache.org Received: (qmail 72119 invoked by uid 99); 31 Oct 2015 23:13:38 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Oct 2015 23:13:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2C4E3C0C6F for ; Sat, 31 Oct 2015 23:13:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.79 X-Spam-Level: * X-Spam-Status: No, score=1.79 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nrWc-EI0BlMG for ; Sat, 31 Oct 2015 23:13:37 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTP id A50032074C for ; Sat, 31 Oct 2015 23:13:36 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D73BCE010F for ; Sat, 31 Oct 2015 23:13:35 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id AE8A73A027C for ; Sat, 31 Oct 2015 23:13:35 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1711708 - in /poi/trunk/src/java/org/apache/poi: hpsf/MutableSection.java ss/formula/CollaboratingWorkbooksEnvironment.java Date: Sat, 31 Oct 2015 23:13:35 -0000 To: commits@poi.apache.org From: kiwiwings@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20151031231335.AE8A73A027C@svn01-us-west.apache.org> Author: kiwiwings Date: Sat Oct 31 23:13:35 2015 New Revision: 1711708 URL: http://svn.apache.org/viewvc?rev=1711708&view=rev Log: FindBugs fixes Modified: poi/trunk/src/java/org/apache/poi/hpsf/MutableSection.java poi/trunk/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java Modified: poi/trunk/src/java/org/apache/poi/hpsf/MutableSection.java URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hpsf/MutableSection.java?rev=1711708&r1=1711707&r2=1711708&view=diff ============================================================================== --- poi/trunk/src/java/org/apache/poi/hpsf/MutableSection.java (original) +++ poi/trunk/src/java/org/apache/poi/hpsf/MutableSection.java Sat Oct 31 23:13:35 2015 @@ -505,10 +505,9 @@ public class MutableSection extends Sect throws IOException { int length = TypeWriter.writeUIntToStream(out, dictionary.size()); - for (final Iterator i = dictionary.keySet().iterator(); i.hasNext();) - { - final Long key = i.next(); - final String value = dictionary.get(key); + for (Map.Entry ls : dictionary.entrySet()) { + final Long key = ls.getKey(); + final String value = ls.getValue(); if (codepage == CodePageUtil.CP_UNICODE) { Modified: poi/trunk/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java?rev=1711708&r1=1711707&r2=1711708&view=diff ============================================================================== --- poi/trunk/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java (original) +++ poi/trunk/src/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java Sat Oct 31 23:13:35 2015 @@ -76,8 +76,9 @@ public final class CollaboratingWorkbook } public static void setupFormulaEvaluator(Map evaluators) { Map evaluatorsByName = new HashMap(evaluators.size()); - for (String wbName : evaluators.keySet()) { - FormulaEvaluator eval = evaluators.get(wbName); + for (Map.Entry swb : evaluators.entrySet()) { + String wbName = swb.getKey(); + FormulaEvaluator eval = swb.getValue(); if (eval instanceof WorkbookEvaluatorProvider) { evaluatorsByName.put(wbName, ((WorkbookEvaluatorProvider)eval)._getWorkbookEvaluator()); } else { --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org For additional commands, e-mail: commits-help@poi.apache.org