poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r1695595 - /poi/trunk/src/java/org/apache/poi/ss/formula/functions/IfFunc.java
Date Wed, 12 Aug 2015 18:38:30 GMT
Author: nick
Date: Wed Aug 12 18:38:30 2015
New Revision: 1695595

URL: http://svn.apache.org/r1695595
Log:
Note on arguments

Modified:
    poi/trunk/src/java/org/apache/poi/ss/formula/functions/IfFunc.java

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/functions/IfFunc.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/functions/IfFunc.java?rev=1695595&r1=1695594&r2=1695595&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/functions/IfFunc.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/functions/IfFunc.java Wed Aug 12 18:38:30
2015
@@ -23,11 +23,18 @@ import org.apache.poi.ss.formula.eval.Ev
 import org.apache.poi.ss.formula.eval.MissingArgEval;
 import org.apache.poi.ss.formula.eval.OperandResolver;
 import org.apache.poi.ss.formula.eval.ValueEval;
+import org.apache.poi.ss.formula.ptg.Ptg;
+import org.apache.poi.ss.formula.ptg.RefPtg;
 
 /**
  * Implementation for the Excel function IF
- *
- * @author Amol S. Deshmukh < amolweb at ya hoo dot com >
+ * <p>
+ * Note that Excel is a bit picky about the arguments to this function,
+ *  when serialised into {@link Ptg}s in a HSSF file. While most cases are
+ *  pretty chilled about the R vs V state of {@link RefPtg} arguments,
+ *  for IF special care is needed to avoid Excel showing #VALUE.
+ * See bug numbers #55324 and #55747 for the full details on this.
+ * TODO Fix this...
  */
 public final class IfFunc extends Var2or3ArgFunction {
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message