poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiwiwi...@apache.org
Subject svn commit: r1693984 - in /poi/trunk/src: java/org/apache/poi/poifs/crypt/ java/org/apache/poi/sl/draw/ ooxml/java/org/apache/poi/xssf/util/ scratchpad/src/org/apache/poi/hslf/usermodel/
Date Mon, 03 Aug 2015 23:36:29 GMT
Author: kiwiwings
Date: Mon Aug  3 23:36:28 2015
New Revision: 1693984

URL: http://svn.apache.org/r1693984
Log:
FindBugs fixes - MS_SHOULD_BE_FINAL

Modified:
    poi/trunk/src/java/org/apache/poi/poifs/crypt/EncryptionInfo.java
    poi/trunk/src/java/org/apache/poi/sl/draw/DrawFactory.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/util/NumericRanges.java
    poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFNotes.java
    poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java

Modified: poi/trunk/src/java/org/apache/poi/poifs/crypt/EncryptionInfo.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/crypt/EncryptionInfo.java?rev=1693984&r1=1693983&r2=1693984&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/crypt/EncryptionInfo.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/crypt/EncryptionInfo.java Mon Aug  3 23:36:28
2015
@@ -48,25 +48,25 @@ public class EncryptionInfo {
      * A flag that specifies whether CryptoAPI RC4 or ECMA-376 encryption
      * ECMA-376 is used. It MUST be 1 unless flagExternal is 1. If flagExternal is 1, it
MUST be 0.
      */
-    public static BitField flagCryptoAPI = BitFieldFactory.getInstance(0x04);
+    public static final BitField flagCryptoAPI = BitFieldFactory.getInstance(0x04);
 
     /**
      * A value that MUST be 0 if document properties are encrypted.
      * The encryption of document properties is specified in section 2.3.5.4.
      */
-    public static BitField flagDocProps = BitFieldFactory.getInstance(0x08);
+    public static final BitField flagDocProps = BitFieldFactory.getInstance(0x08);
     
     /**
      * A value that MUST be 1 if extensible encryption is used. If this value is 1,
      * the value of every other field in this structure MUST be 0.
      */
-    public static BitField flagExternal = BitFieldFactory.getInstance(0x10);
+    public static final BitField flagExternal = BitFieldFactory.getInstance(0x10);
     
     /**
      * A value that MUST be 1 if the protected content is an ECMA-376 document
      * ECMA-376. If the fAES bit is 1, the fCryptoAPI bit MUST also be 1.
      */
-    public static BitField flagAES = BitFieldFactory.getInstance(0x20);
+    public static final BitField flagAES = BitFieldFactory.getInstance(0x20);
     
     
     /**

Modified: poi/trunk/src/java/org/apache/poi/sl/draw/DrawFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/sl/draw/DrawFactory.java?rev=1693984&r1=1693983&r2=1693984&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/sl/draw/DrawFactory.java (original)
+++ poi/trunk/src/java/org/apache/poi/sl/draw/DrawFactory.java Mon Aug  3 23:36:28 2015
@@ -42,7 +42,7 @@ import org.apache.poi.sl.usermodel.TextR
 import org.apache.poi.sl.usermodel.TextShape;
 
 public class DrawFactory {
-    protected static ThreadLocal<DrawFactory> defaultFactory = new ThreadLocal<DrawFactory>();
+    protected static final ThreadLocal<DrawFactory> defaultFactory = new ThreadLocal<DrawFactory>();
 
     /**
      * Set a custom draw factory for the current thread.

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/util/NumericRanges.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/util/NumericRanges.java?rev=1693984&r1=1693983&r2=1693984&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/util/NumericRanges.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/util/NumericRanges.java Mon Aug  3 23:36:28
2015
@@ -19,11 +19,11 @@ package org.apache.poi.xssf.util;
 
 public class NumericRanges {
 
-    public static int NO_OVERLAPS = -1;
-    public static int OVERLAPS_1_MINOR = 0;
-    public static int OVERLAPS_2_MINOR = 1;
-    public static int OVERLAPS_1_WRAPS = 2;
-    public static int OVERLAPS_2_WRAPS = 3;
+    public static final int NO_OVERLAPS = -1;
+    public static final int OVERLAPS_1_MINOR = 0;
+    public static final int OVERLAPS_2_MINOR = 1;
+    public static final int OVERLAPS_1_WRAPS = 2;
+    public static final int OVERLAPS_2_WRAPS = 3;
     
     public static long[] getOverlappingRange(long[] range1, long[] range2) {
         int overlappingType = getOverlappingType(range1, range2);

Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFNotes.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFNotes.java?rev=1693984&r1=1693983&r2=1693984&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFNotes.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFNotes.java Mon Aug  3 23:36:28
2015
@@ -33,7 +33,7 @@ import org.apache.poi.util.POILogger;
  */
 
 public final class HSLFNotes extends HSLFSheet implements Notes<HSLFShape, HSLFSlideShow>
{
-    protected static POILogger logger = POILogFactory.getLogger(HSLFNotes.class);
+    protected static final POILogger logger = POILogFactory.getLogger(HSLFNotes.class);
     
     private List<List<HSLFTextParagraph>> _paragraphs = new ArrayList<List<HSLFTextParagraph>>();
 

Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java?rev=1693984&r1=1693983&r2=1693984&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java Mon
Aug  3 23:36:28 2015
@@ -40,7 +40,7 @@ import org.apache.poi.util.*;
  */
 
 public final class HSLFTextParagraph implements TextParagraph<HSLFTextRun> {
-    protected static POILogger logger = POILogFactory.getLogger(HSLFTextParagraph.class);
+    protected static final POILogger logger = POILogFactory.getLogger(HSLFTextParagraph.class);
 
     /**
      * How to align the text



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message