poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r1651451 - in /poi/trunk: src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java test-data/spreadsheet/testEXCEL_3.xls
Date Tue, 13 Jan 2015 19:32:51 GMT
Author: nick
Date: Tue Jan 13 19:32:50 2015
New Revision: 1651451

URL: http://svn.apache.org/r1651451
Log:
Add a sample Excel 3 file from TIKA-1515, and a disabled unit test for it

Added:
    poi/trunk/test-data/spreadsheet/testEXCEL_3.xls   (with props)
Modified:
    poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java
    poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java?rev=1651451&r1=1651450&r2=1651451&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/dev/TestBiffViewer.java Tue Jan 13 19:32:50
2015
@@ -38,6 +38,8 @@ public class TestBiffViewer extends Base
 		SILENT_EXCLUDED.add("46904.xls");
         SILENT_EXCLUDED.add("35897-type4.xls"); // unsupported crypto api header 
 		SILENT_EXCLUDED.add("xor-encryption-abc.xls"); // unsupported XOR-encryption
+        SILENT_EXCLUDED.add("testEXCEL_2.xls");  // Biff 2 / Excel 2, pre-OLE2
+        SILENT_EXCLUDED.add("testEXCEL_3.xls");  // Biff 3 / Excel 3, pre-OLE2
         SILENT_EXCLUDED.add("testEXCEL_4.xls");  // Biff 4 / Excel 4, pre-OLE2
         SILENT_EXCLUDED.add("testEXCEL_5.xls");  // Biff 5 / Excel 5
         SILENT_EXCLUDED.add("testEXCEL_95.xls"); // Biff 5 / Excel 95

Modified: poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java?rev=1651451&r1=1651450&r2=1651451&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/extractor/TestOldExcelExtractor.java Tue Jan
13 19:32:50 2015
@@ -38,6 +38,27 @@ public final class TestOldExcelExtractor
         }
     }
     
+    public void DISABLEDtestSimpleExcel3() {
+        OldExcelExtractor extractor = createExtractor("testEXCEL_3.xls");
+
+        // Check we can call getText without error
+        String text = extractor.getText();
+
+        // Check we find a few words we expect in there
+        assertContains(text, "Season beginning August");
+        assertContains(text, "USDA");
+        
+        // Check we find a few numbers we expect in there
+        assertContains(text, "347");
+        assertContains(text, "228");
+        
+        // Check we find a few string-literal dates in there
+        assertContains(text, "1981/82");
+        
+        // Check the type
+        assertEquals(3, extractor.getBiffVersion());
+        assertEquals(0x10, extractor.getFileType());
+    }
     public void testSimpleExcel4() {
         OldExcelExtractor extractor = createExtractor("testEXCEL_4.xls");
 

Added: poi/trunk/test-data/spreadsheet/testEXCEL_3.xls
URL: http://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/testEXCEL_3.xls?rev=1651451&view=auto
==============================================================================
Binary file - no diff available.

Propchange: poi/trunk/test-data/spreadsheet/testEXCEL_3.xls
------------------------------------------------------------------------------
    svn:mime-type = application/octet-stream



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message