poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r1642567 - /poi/trunk/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java
Date Sun, 30 Nov 2014 17:07:45 GMT
Author: nick
Date: Sun Nov 30 17:07:45 2014
New Revision: 1642567

URL: http://svn.apache.org/r1642567
Log:
Update TODOs for what remains

Modified:
    poi/trunk/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java

Modified: poi/trunk/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java?rev=1642567&r1=1642566&r2=1642567&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/extractor/OldExcelExtractor.java Sun Nov 30 17:07:45
2014
@@ -135,7 +135,9 @@ public class OldExcelExtractor {
         
         // To track formats and encodings
         CodepageRecord codepage = null;
+        // TODO track the XFs and Format Strings
 
+        // Process each record in turn, looking for interesting ones
         while (ris.hasNextRecord()) {
             int sid = ris.getNextSid();
             ris.nextRecord();
@@ -150,7 +152,6 @@ public class OldExcelExtractor {
                     text.append('\n');
                     break;
             
-                // label - 5.63 - TODO Needs codepages
                 case OldLabelRecord.biff2_sid:
                 case OldLabelRecord.biff345_sid:
                     OldLabelRecord lr = new OldLabelRecord(ris);
@@ -158,7 +159,6 @@ public class OldExcelExtractor {
                     text.append(lr.getValue());
                     text.append('\n');
                     break;
-                // string - 5.102 - TODO Needs codepages
                 case OldStringRecord.biff2_sid:
                 case OldStringRecord.biff345_sid:
                     OldStringRecord sr = new OldStringRecord(ris);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message