poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r950117 - in /poi/trunk/src: documentation/content/xdocs/status.xml java/org/apache/poi/ss/usermodel/DataFormatter.java testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java
Date Tue, 01 Jun 2010 15:31:52 GMT
Author: nick
Date: Tue Jun  1 15:31:51 2010
New Revision: 950117

URL: http://svn.apache.org/viewvc?rev=950117&view=rev
Log:
Fix inspired by bug #48872 - allow DateFormatter.formatRawCellContents to handle 1904 as well
as 1900 dates

Modified:
    poi/trunk/src/documentation/content/xdocs/status.xml
    poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java
    poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java

Modified: poi/trunk/src/documentation/content/xdocs/status.xml
URL: http://svn.apache.org/viewvc/poi/trunk/src/documentation/content/xdocs/status.xml?rev=950117&r1=950116&r2=950117&view=diff
==============================================================================
--- poi/trunk/src/documentation/content/xdocs/status.xml (original)
+++ poi/trunk/src/documentation/content/xdocs/status.xml Tue Jun  1 15:31:51 2010
@@ -34,6 +34,7 @@
 
     <changes>
         <release version="3.7-SNAPSHOT" date="2010-??-??">
+           <action dev="POI-DEVELOPERS" type="fix">48872 - allow DateFormatter.formatRawCellContents
to handle 1904 as well as 1900 dates</action>
            <action dev="POI-DEVELOPERS" type="fix">48872 - handle MMMMM and elapsed
time formatting rules in DataFormatter</action>
            <action dev="POI-DEVELOPERS" type="fix">48872 - handle zero formatting rules,
and better color detection in DataFormatter</action>
            <action dev="POI-DEVELOPERS" type="fix">48872 - support for more kinds of
formatting in DataFormatter</action>

Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java?rev=950117&r1=950116&r2=950117&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java Tue Jun  1 15:31:51
2010
@@ -511,6 +511,14 @@ public class DataFormatter {
      * @see #formatCellValue(Cell)
      */
     public String formatRawCellContents(double value, int formatIndex, String formatString)
{
+       return formatRawCellContents(value, formatIndex, formatString, false);
+    }
+    /**
+     * Formats the given raw cell value, based on the supplied
+     *  format index and string, according to excel style rules.
+     * @see #formatCellValue(Cell)
+     */
+    public String formatRawCellContents(double value, int formatIndex, String formatString,
boolean use1904Windowing) {
         // Is it a date?
         if(DateUtil.isADateFormat(formatIndex,formatString) &&
                 DateUtil.isValidExcelDate(value)) {
@@ -519,7 +527,7 @@ public class DataFormatter {
                // Hint about the raw excel value
                ((ExcelStyleDateFormatter)dateFormat).setDateToBeFormatted(value);
             }
-            Date d = DateUtil.getJavaDate(value);
+            Date d = DateUtil.getJavaDate(value, use1904Windowing);
             return performDateFormatting(d, dateFormat);
         }
         // else Number

Modified: poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java?rev=950117&r1=950116&r2=950117&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/usermodel/TestDataFormatter.java Tue Jun  1
15:31:51 2010
@@ -18,13 +18,12 @@
 package org.apache.poi.ss.usermodel;
 
 import java.util.Calendar;
-import java.util.Date;
 import java.util.Locale;
 
-import org.apache.poi.hssf.usermodel.TestHSSFDataFormatter;
-
 import junit.framework.TestCase;
 
+import org.apache.poi.hssf.usermodel.TestHSSFDataFormatter;
+
 /**
  * Tests of {@link DataFormatter}
  *
@@ -189,4 +188,12 @@ public class TestDataFormatter extends T
        assertEquals("60:00", dfUS.formatRawCellContents(1*hour, -1, "[mm]:ss"));
        assertEquals("120:00", dfUS.formatRawCellContents(2*hour, -1, "[mm]:ss"));
     }
+    
+    public void testDateWindowing() {
+       DataFormatter dfUS = new DataFormatter(Locale.US);
+       
+       assertEquals("1899-12-31 00:00:00", dfUS.formatRawCellContents(0.0, -1, "yyyy-mm-dd
hh:mm:ss"));
+       assertEquals("1899-12-31 00:00:00", dfUS.formatRawCellContents(0.0, -1, "yyyy-mm-dd
hh:mm:ss", false));
+       assertEquals("1904-01-01 00:00:00", dfUS.formatRawCellContents(0.0, -1, "yyyy-mm-dd
hh:mm:ss", true));
+    }
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message