poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j...@apache.org
Subject svn commit: r816006 - in /poi/trunk/src: documentation/content/xdocs/ java/org/apache/poi/hssf/record/formula/eval/ java/org/apache/poi/hssf/usermodel/ java/org/apache/poi/ss/formula/ java/org/apache/poi/ss/usermodel/ ooxml/java/org/apache/poi/xssf/use...
Date Wed, 16 Sep 2009 23:20:52 GMT
Author: josh
Date: Wed Sep 16 23:20:51 2009
New Revision: 816006

URL: http://svn.apache.org/viewvc?rev=816006&view=rev
Log:
Reverted initial application of patches 47848(r815935) and 47849(r815942). Some details need
clarification.

Modified:
    poi/trunk/src/documentation/content/xdocs/status.xml
    poi/trunk/src/java/org/apache/poi/hssf/record/formula/eval/RefEval.java
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFCreationHelper.java
    poi/trunk/src/java/org/apache/poi/ss/formula/LazyRefEval.java
    poi/trunk/src/java/org/apache/poi/ss/formula/SheetRefEvaluator.java
    poi/trunk/src/java/org/apache/poi/ss/usermodel/CreationHelper.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCreationHelper.java

Modified: poi/trunk/src/documentation/content/xdocs/status.xml
URL: http://svn.apache.org/viewvc/poi/trunk/src/documentation/content/xdocs/status.xml?rev=816006&r1=816005&r2=816006&view=diff
==============================================================================
--- poi/trunk/src/documentation/content/xdocs/status.xml (original)
+++ poi/trunk/src/documentation/content/xdocs/status.xml Wed Sep 16 23:20:51 2009
@@ -32,9 +32,7 @@
     </developers>
 
     <changes>
-      <release version="3.5-beta7" date="2009-??-??">
-           <action dev="POI-DEVELOPERS" type="add">47849 - Added possibility to get
EvaluationCell from RefEval</action>
-           <action dev="POI-DEVELOPERS" type="add">47848 - Added method createEvaluationWorkbook()
to CreationHelper</action>
+        <release version="3.5-beta7" date="2009-??-??">
            <action dev="POI-DEVELOPERS" type="add">47809 - Improved work with user-defined
functions</action>
            <action dev="POI-DEVELOPERS" type="fix">47581 - fixed  XSSFSheet.setColumnWidth
to produce XML compatible with Mac Excel 2008</action>
            <action dev="POI-DEVELOPERS" type="fix">47734 - removed unnecessary svn:executable
flag from files in SVN trunk</action>

Modified: poi/trunk/src/java/org/apache/poi/hssf/record/formula/eval/RefEval.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/formula/eval/RefEval.java?rev=816006&r1=816005&r2=816006&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/formula/eval/RefEval.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/formula/eval/RefEval.java Wed Sep 16 23:20:51
2009
@@ -17,19 +17,15 @@
 
 package org.apache.poi.hssf.record.formula.eval;
 
-import org.apache.poi.ss.formula.EvaluationCell;
-
 /**
  * @author Amol S Deshmukh &lt; amolweb at ya hoo dot com &gt;
- * 
+ *
  * RefEval is the super interface for Ref2D and Ref3DEval. Basically a RefEval
  * impl should contain reference to the original ReferencePtg or Ref3DPtg as
  * well as the final "value" resulting from the evaluation of the cell
  * reference. Thus if the HSSFCell has type CELL_TYPE_NUMERIC, the contained
  * value object should be of type NumberEval; if cell type is CELL_TYPE_STRING,
  * contained value object should be of type StringEval
- * 
- * Modified 09/07/09 by Petr Udalau - added method getEvaluationCell().
  */
 public interface RefEval extends ValueEval {
 
@@ -52,9 +48,4 @@
      * Creates an {@link AreaEval} offset by a relative amount from this RefEval
      */
     AreaEval offset(int relFirstRowIx, int relLastRowIx, int relFirstColIx, int relLastColIx);
-    
-    /**
-     * @return EvaluationCell referred to by this RefEval
-     */
-    EvaluationCell getEvaluationCell();
 }

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFCreationHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFCreationHelper.java?rev=816006&r1=816005&r2=816006&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFCreationHelper.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFCreationHelper.java Wed Sep 16 23:20:51
2009
@@ -42,10 +42,6 @@
 		return new HSSFHyperlink(type);
 	}
 
-    public HSSFEvaluationWorkbook createEvaluationWorkbook() {
-        return HSSFEvaluationWorkbook.create(workbook);
-    }
-
 	/**
 	 * Creates a HSSFFormulaEvaluator, the object that evaluates formula cells.
 	 *

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/LazyRefEval.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/LazyRefEval.java?rev=816006&r1=816005&r2=816006&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/LazyRefEval.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/LazyRefEval.java Wed Sep 16 23:20:51 2009
@@ -52,10 +52,6 @@
 		return _evaluator.getEvalForCell(getRow(), getColumn());
 	}
 
-    public EvaluationCell getEvaluationCell() {
-        return _evaluator.getEvaluationCell(getRow(), getColumn());
-    }
-    
 	public AreaEval offset(int relFirstRowIx, int relLastRowIx, int relFirstColIx, int relLastColIx)
{
 
 		AreaI area = new OffsetArea(getRow(), getColumn(),

Modified: poi/trunk/src/java/org/apache/poi/ss/formula/SheetRefEvaluator.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/SheetRefEvaluator.java?rev=816006&r1=816005&r2=816006&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/SheetRefEvaluator.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/SheetRefEvaluator.java Wed Sep 16 23:20:51
2009
@@ -22,10 +22,6 @@
  *
  *
  * @author Josh Micich
- * 
- * June 4, 2009: Added method setCellValue for setting values in cells.
- * 
- * Modified 09/07/09 by Petr Udalau - added method getEvaluationCell(int rowIndex, int columnIndex).
  */
 final class SheetRefEvaluator {
 
@@ -57,13 +53,4 @@
 		}
 		return _sheet;
 	}
-	
-    /**
-     * @param rowIndex Row index.
-     * @param columnIndex Column index.
-     * @return EvaluationCell by row and column.
-     */
-	public EvaluationCell getEvaluationCell(int rowIndex, int columnIndex){
-        return getSheet().getCell(rowIndex, columnIndex);
-    }
 }

Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/CreationHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/CreationHelper.java?rev=816006&r1=816005&r2=816006&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/CreationHelper.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/CreationHelper.java Wed Sep 16 23:20:51
2009
@@ -16,11 +16,9 @@
 ==================================================================== */
 package org.apache.poi.ss.usermodel;
 
-import org.apache.poi.ss.formula.EvaluationWorkbook;
-
 /**
  * An object that handles instantiating concrete
- *  classes of the various instances one needs for 
+ *  classes of the various instances one needs for
  *  HSSF and XSSF.
  * Works around a major shortcoming in Java, where we
  *  can't have static methods on interfaces or abstract
@@ -29,40 +27,30 @@
  *  a given interface, without you having to worry
  *  about if you're dealing with HSSF or XSSF, despite
  *  Java being quite rubbish.
- * 
- * Modified 09/07/09 by Petr Udalau - added method createEvaluationWorkbook().
- * 
  */
 public interface CreationHelper {
     /**
-     * Creates a new RichTextString instance 
+     * Creates a new RichTextString instance
      * @param text The text to initialise the RichTextString with
      */
     RichTextString createRichTextString(String text);
-    
+
     /**
      * Creates a new DataFormat instance
      */
     DataFormat createDataFormat();
-    
+
     /**
      * Creates a new Hyperlink, of the given type
      */
     Hyperlink createHyperlink(int type);
 
     /**
-     * Creates EvaluationWorkbook.
-     *
-     * @return a EvaluationWorkbook instance
-     */
-    EvaluationWorkbook createEvaluationWorkbook();
-
-    /**
      * Creates FormulaEvaluator - an object that evaluates formula cells.
      *
      * @return a FormulaEvaluator instance
      */
     FormulaEvaluator createFormulaEvaluator();
-    
+
     ClientAnchor createClientAnchor();
-}
\ No newline at end of file
+}

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCreationHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCreationHelper.java?rev=816006&r1=816005&r2=816006&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCreationHelper.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFCreationHelper.java Wed Sep
16 23:20:51 2009
@@ -42,10 +42,6 @@
 		return new XSSFHyperlink(type);
 	}
 
-    public XSSFEvaluationWorkbook createEvaluationWorkbook() {
-        return XSSFEvaluationWorkbook.create(workbook);
-    }
-
 	/**
 	 * Creates a XSSFFormulaEvaluator, the object that evaluates formula cells.
 	 *



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message