Return-Path: Delivered-To: apmail-poi-commits-archive@minotaur.apache.org Received: (qmail 66023 invoked from network); 22 Feb 2009 16:08:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Feb 2009 16:08:28 -0000 Received: (qmail 70232 invoked by uid 500); 22 Feb 2009 16:08:28 -0000 Delivered-To: apmail-poi-commits-archive@poi.apache.org Received: (qmail 70194 invoked by uid 500); 22 Feb 2009 16:08:28 -0000 Mailing-List: contact commits-help@poi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@poi.apache.org Delivered-To: mailing list commits@poi.apache.org Received: (qmail 70185 invoked by uid 99); 22 Feb 2009 16:08:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Feb 2009 08:08:28 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Feb 2009 16:08:27 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 2D525238889F; Sun, 22 Feb 2009 16:08:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r746746 - /poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java Date: Sun, 22 Feb 2009 16:08:07 -0000 To: commits@poi.apache.org From: yegor@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090222160807.2D525238889F@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: yegor Date: Sun Feb 22 16:08:06 2009 New Revision: 746746 URL: http://svn.apache.org/viewvc?rev=746746&view=rev Log: fixed platform-dependent unit test Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java?rev=746746&r1=746745&r2=746746&view=diff ============================================================================== --- poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java (original) +++ poi/trunk/src/ooxml/testcases/org/apache/poi/openxml4j/opc/TestFileHelper.java Sun Feb 22 16:08:06 2009 @@ -33,13 +33,23 @@ public void testGetDirectory() { TreeMap expectedValue = new TreeMap(); - expectedValue.put("c:\\test\\test.doc", "c:\\test"); - expectedValue.put("d:\\test\\test2\\test.doc.xml", "d:\\test\\test2"); + expectedValue.put("/dir1/test.doc", "/dir1"); + expectedValue.put("/dir1/dir2/test.doc.xml", "/dir1/dir2"); for (String filename : expectedValue.keySet()) { - assertTrue(expectedValue.get(filename).equalsIgnoreCase( - FileHelper.getDirectory(new File(filename)) - .getAbsolutePath())); + File f1 = new File(expectedValue.get(filename)); + File f2 = FileHelper.getDirectory(new File(filename)); + + /* + * YK: The original version asserted expected values against File#getAbsolutePath(): + * assertTrue(expectedValue.get(filename).equalsIgnoreCase( + * FileHelper.getDirectory(new File(filename)) + * .getAbsolutePath())); + * + * This comparison is platform dependent and resulted in build errors in Gump since 21/02/2009. + * Assertion via File#equals(File otherFile) is a better approach. + */ + assertTrue(f1.equals(f2)); } } } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org For additional commands, e-mail: commits-help@poi.apache.org