poi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From n...@apache.org
Subject svn commit: r603538 - in /poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula: eval/TestEverything.java functions/TestEverything.java
Date Wed, 12 Dec 2007 10:30:22 GMT
Author: nick
Date: Wed Dec 12 02:30:22 2007
New Revision: 603538

URL: http://svn.apache.org/viewvc?rev=603538&view=rev
Log:
Add comments on which formula related things should go in which of the two test suites

Modified:
    poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
    poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java

Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java?rev=603538&r1=603537&r2=603538&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
(original)
+++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/eval/TestEverything.java
Wed Dec 12 02:30:22 2007
@@ -23,8 +23,13 @@
 import junit.framework.TestSuite;
 
 /**
- * @author Amol S. Deshmukh < amolweb at ya hoo dot com >
+ * This is a test of all the Eval functions we have implemented.
+ * Add newly implemented Eval functions in here to have them
+ *  tested.
+ * For newly implemented functions, 
+ *  @see org.apache.poi.hssf.record.formula.functions.TestEverything
  *
+ * @author Amol S. Deshmukh < amolweb at ya hoo dot com >
  */
 public class TestEverything extends TestSuite {
 
@@ -45,12 +50,9 @@
         suite.addTest(new GenericFormulaTestCase("D71")); // UnaryMinusEval
         suite.addTest(new GenericFormulaTestCase("D75")); // UnaryPlusEval
         
-        suite.addTest(new GenericFormulaTestCase("D249")); // Concatenate
-        suite.addTest(new GenericFormulaTestCase("D741")); // Int
-        suite.addTest(new GenericFormulaTestCase("D1393")); // Trim
-        suite.addTest(new GenericFormulaTestCase("D1421")); // Upper
-        
-        // Add newly implemented formula functions here 
+		// Add newly implemented Eval functions here
+		// (Formula functions go in 
+ 		//  @see org.apache.poi.hssf.record.formula.functions.TestEverything )
         
         return suite;
     }

Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java?rev=603538&r1=603537&r2=603538&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java
(original)
+++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hssf/record/formula/functions/TestEverything.java
Wed Dec 12 02:30:22 2007
@@ -25,11 +25,16 @@
 import junit.framework.TestSuite;
 
 /**
- * @author Amol S. Deshmukh < amolweb at ya hoo dot com >
+ * This is a test of all the normal formula functions we have implemented.
+ * It should pick up newly implemented functions which are correctly added
+ *  to the test formula excel file, but tweak the rows below if you
+ *  add any past the end of what's currently checked.
+ * For newly implemented eval functions, 
+ *  @see org.apache.poi.hssf.record.formula.eval.TestEverything
  *
+ * @author Amol S. Deshmukh < amolweb at ya hoo dot com >
  */
 public class TestEverything extends TestSuite {
-
     public static TestSuite suite() throws Exception {
         TestSuite suite = new TestSuite("Tests for individual function classes");
         String s;



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org


Mime
View raw message