plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Feinauer <j.feina...@pragmaticminds.de>
Subject AW: [DISCUSSION] Release 0.4
Date Mon, 06 May 2019 17:59:30 GMT
Nah, not so important just wanted to note it.

Von meinem Mobiltelefon gesendet

-------- Ursprüngliche Nachricht --------
Betreff: Re: [DISCUSSION] Release 0.4
Von: Christofer Dutz
An: dev@plc4x.apache.org
Cc:

HI Julian,

I had another look ... I could perhaps manually have the build delete some of the classes
sources and hope that reduces the build time.
Not quite sure that this is really worth it. How long does it take for you to compile the
thrift compiler?

Chris

Am 06.05.19, 17:41 schrieb "Christofer Dutz" <christofer.dutz@c-ware.de>:

    Hi Julian,

    The build already disables the libraries we don't need.
    Ok, if you build with all profiles enabled it builds c++ and python, but if you just have
with-proxies enabled it should only build the compiler. The compiler itself is always built
with all outputs and I haven't found a way to avoid this. But it doesn't really take long,
so it didn't bother me.

    Chris

    Outlook für Android<https://aka.ms/ghei36> herunterladen



    Von: Julian Feinauer
    Gesendet: Montag, 6. Mai, 16:48
    Betreff: Re: [DISCUSSION] Release 0.4
    An: dev@plc4x.apache.org


    Hi Chris,

    thanks for the update.
    With the recent commit (d7598ad2fdcbd8730926776e0316cf5d13976183) it now works with the
command

    ` mvn clean install -Pwith-cpp,with-python,with-dotnet,with-proxies,with-sandbox -DskipTests`

    Just one thing I noticed.. we build thrift with all code generators from which we do not
use many.
    Is there a possibility to disable most of them, this would really increase the build time
drastically, I think.

    Julian

    Am 06.05.19, 15:56 schrieb "Christofer Dutz" <christofer.dutz@c-ware.de>:

        Hi Julian,

        so it seems that the thrift build successfully built the compiler, but seems to have
failed generating the python library.
        There must be some error message or it even logged that it's not going to build the
python library because one of the dependencies were missing.

        The problem is that if I enable python, the C++ build checks if all prerequisites
are available and simply disables the python output if not all python prerequisites are met.
Then the build succeeds but it didn't generate any python stuff, so when we try to package
it, the assembly plugin fails ...

        What's the output if you execute "python --version" on your commandline?

        Chris



        Am 06.05.19, 15:39 schrieb "Julian Feinauer" <j.feinauer@pragmaticminds.de>:

            Hi,

            I have some issues with the build.
            I did:

            * Check out the latest develop (3e712a66470bef07f8650106553333ea68d8904c) and
clean all non-versioned files from the project
            * one build using `mvn clean install -DskipTests`
            * one build using `mvn clean install -Pwith-cpp,with-python,with-dotnet,with-proxies,with-sandbox`

            The first one works fine on my Mac with OS X Mojave (10.14.4), Java 8 (Hotspot
1.8.0_66-ea).
            The second one fails with

            [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.1.1:single
(package-thrift-python) on project plc4x-tools-thrift: Failed to create assembly: Error creating
assembly archive python: archive cannot be empty -> [Help 1]
            [ERROR]
            [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
            [ERROR] Re-run Maven using the -X switch to enable full debug logging.
            [ERROR]
            [ERROR] For more information about the errors and possible solutions, please read
the following articles:
            [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
            [ERROR]
            [ERROR] After correcting the problems, you can resume the build with the command
            [ERROR]   mvn <goals> -rf :plc4x-tools-thrift

            Julian

            Am 06.05.19, 08:51 schrieb "Julian Feinauer" <j.feinauer@pragmaticminds.de>:

                Hi all,

                Good idea Chris, I'll do it later in the office and post my result here.

                And thanks Tim for stepping back, I agree that Chris should have the honor
and also had the experience to fix all the incubaror stuff which still is in some templates
and so.

                So I suggest that we all state the work in progress which should go to the
release, if there is any.
                I only am aware of the scraper and S7 types would be great.

                Any other opinions?

                Julian

                Von meinem Mobiltelefon gesendet


                -------- Ursprüngliche Nachricht --------
                Betreff: Re: [DISCUSSION] Release 0.4
                Von: Christofer Dutz
                An: dev@plc4x.apache.org
                Cc:

                One good preparation would be for all to do full builds: with-cpp,with-python,with-dotnet,with-proxies,with-sandbox
... One person did report having problems. Would like to find out why.

                Chris

                Outlook für Android<https://aka.ms/ghei36> herunterladen

                ________________________________
                From: Tim Mitsch <t.mitsch@pragmaticindustries.de>
                Sent: Monday, May 6, 2019 12:31:43 AM
                To: dev@plc4x.apache.org
                Subject: Re: [DISCUSSION] Release 0.4

                Hey everybody,

                full ack ... a soon release shall be done, as we have enough stuff that could
be released.

                I can do the release as i got a great introduction of how to do it with 0.3.1
by Julian, thanks for that btw.
                But i think Chris has the honor to decide if he wants to do the first Release
of PLC4X matured to TLP - would love to support

                I think end of this or beginning of next week could be a good date for a 0.4.0-RC1

                Best
                Tim



                Am 05.05.19, 21:04 schrieb "Christofer Dutz" <christofer.dutz@c-ware.de>:

                    Hi all,

                    I also think we should do a release soon. Especially for making a first
tlp release.

                    Regarding the RM, I would like to actually perform the technical release
this time. I'm quite sure I changed the graduation related stuff correctly, but with all this
super special additional stuff (CPP, C#, Python, Thrift) I am sorry of expecting bumps on
the road.

                    I'm fine with Tim doing the paperwork, if he wants to ;-)

                    Chris

                    Outlook für Android<https://aka.ms/ghei36> herunterladen

                    ________________________________
                    From: Julian Feinauer <j.feinauer@pragmaticminds.de>
                    Sent: Sunday, May 5, 2019 7:52:31 PM
                    To: dev@plc4x.apache.org
                    Subject: [DISCUSSION] Release 0.4

                    Hi all,

                    we also had a short discussion about the next release of PLC4X but I guess
the best place is the list.
                    So I think we should start very soon with the preparation of a new release.
                    I also think we should include some of the very recent things (Python,
CPP) but explicitly flag them as experimental feature.
                    So we can give them out to others but with a clear disclaimer that this
is more a “play around” thing.

                    And we are free to target the next release “soon” to add some more
things.
                    I see that there are a lot of “small” improvements which we really
should get out, and I would also love to start collecting feedback for the “experimental”
stuff.

                    Another question that came up was who will be RM.
                    Tim already volunteered for that, and I absolutely support that to further
diversify the RMs.
                    But as the build recently changed it could be a bit complicated so Chris
offered to do it this time.
                    I cannot say what is the best solution but leave it up to everybody.

                    Perhaps a solution would be to have Tim “manage” it and prepare everything
and then do the maven related stuff with supervision from chris or by chris. By doing this
he gets at least a good knowledge of the process around (branching strat, vote preparation
and so).

                    What are your opinions?
                    I think we could target something like the end of next week for an RC.

                    Julian












Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message