From dev-return-1650-archive-asf-public=cust-asf.ponee.io@plc4x.apache.org Wed Mar 6 09:12:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A596A18067E for ; Wed, 6 Mar 2019 10:12:52 +0100 (CET) Received: (qmail 31157 invoked by uid 500); 6 Mar 2019 09:12:51 -0000 Mailing-List: contact dev-help@plc4x.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@plc4x.apache.org Delivered-To: mailing list dev@plc4x.apache.org Received: (qmail 30955 invoked by uid 99); 6 Mar 2019 09:12:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Mar 2019 09:12:51 +0000 From: GitBox To: dev@plc4x.apache.org Subject: [GitHub] [incubator-plc4x] JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper Message-ID: <155186357078.29590.16737526405339661184.gitbox@gitbox.apache.org> Date: Wed, 06 Mar 2019 09:12:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit JulianFeinauer commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r262822320 ########## File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/config/ScraperConfiguration.java ########## @@ -26,24 +26,32 @@ import com.fasterxml.jackson.databind.exc.MismatchedInputException; import com.fasterxml.jackson.dataformat.yaml.YAMLFactory; import org.apache.plc4x.java.scraper.ScrapeJob; -import org.apache.plc4x.java.scraper.Scraper; +import org.apache.plc4x.java.scraper.ScrapeJobImpl; +import org.apache.plc4x.java.scraper.exception.ScraperConfigurationException; +import org.apache.plc4x.java.scraper.exception.ScraperException; +import org.apache.plc4x.java.scraper.ScraperImpl; +import org.apache.plc4x.java.scraper.config.triggeredscraper.TriggeredJobConfiguration; +import org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScrapeJobImpl; import java.io.File; import java.io.FileNotFoundException; import java.io.IOException; +import java.util.ArrayList; import java.util.List; import java.util.Map; import java.util.Set; import java.util.function.Function; import java.util.stream.Collectors; /** - * Configuration class for {@link Scraper}. + * Configuration class for {@link ScraperImpl}. + * Scraper is deprecated please use {@link org.apache.plc4x.java.scraper.config.triggeredscraper.TriggeredScraperConfiguration} instead all functions are supplied as well see java-doc of {@link org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScraperImpl} Review comment: @deprecated ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services