plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christofer Dutz <christofer.d...@c-ware.de>
Subject Re: [GitHub] [incubator-plc4x] timbo2k edited a comment on issue #46: PLC4X-88:
Date Tue, 05 Mar 2019 22:34:49 GMT
Hi Tim,

I'll have a look, but maybe not before tomorrow evening or Thursday as I will probably not
be at my computer most of the day tomorrow.

Looking forward to checking it out.

Chris

Outlook für Android<https://aka.ms/ghei36> herunterladen

________________________________
From: GitBox <git@apache.org>
Sent: Tuesday, March 5, 2019 9:55:51 PM
To: dev@plc4x.apache.org
Subject: [GitHub] [incubator-plc4x] timbo2k edited a comment on issue #46: PLC4X-88:

timbo2k edited a comment on issue #46: PLC4X-88:
URL: https://github.com/apache/incubator-plc4x/pull/46#issuecomment-469853081


   Hi everybody

   I had worked on the triggered scraper as stated on the list.
   The pushed branch is the current version to retrieve your opinion ... so handle it as working
state.
   I will also add relevant tests for the new triggered scraper.
   mvn verify went fine except i commented out one test --> ScraperConfigurationBuilderTest
maybe @JulianFeinauer can have a look on that, test was written by you

   Furthermore i declared the "old" scraper as deprecated because triggered one can supply
everything what old scraper could do; only for compatability-reasons

   I'm looking forward for your comments ... please do not merge until i added the tests i
planned to implement.

   Best
   Tim

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message