plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christofer Dutz <christofer.d...@c-ware.de>
Subject Re: [GitHub] [incubator-plc4x] JulianFeinauer commented on issue #47: Extend field with type information
Date Thu, 14 Mar 2019 23:16:52 GMT
Just had a look at the latest changes in the API.

Would be good if the other drivers would also receive an implementation of the "parse" method
or the scraper will still only work with the s7 protocol.
The way I see it, this way it will fire a PlcRuntimeException for every other driver.

Chris

Am 10.03.19, 18:56 schrieb "GitBox" <git@apache.org>:

    JulianFeinauer commented on issue #47: Extend field with type information
    URL: https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471328401
     
     
       +1 (I even heard the original pr author is a very good looking guy...).
       
       Go merge it
       
       Julian
       
       Von meinem Mobiltelefon gesendet
       
       
       -------- Ursprüngliche Nachricht --------
       Betreff: Re: [apache/incubator-plc4x] Extend field with type information (#47)
       Von: Christofer Dutz
       An: apache/incubator-plc4x
       Cc: Julian Feinauer ,Author
       
       If it works, … merge it 😉 (my opinion)
       
       Chris
       
       Von: timbo2k <notifications@github.com>
       Antworten an: apache/incubator-plc4x <reply@reply.github.com>
       Datum: Sonntag, 10. März 2019 um 16:29
       An: apache/incubator-plc4x <incubator-plc4x@noreply.github.com>
       Cc: Christofer Dutz <christofer.dutz@c-ware.de>, Review requested <review_requested@noreply.github.com>
       Betreff: Re: [apache/incubator-plc4x] Extend field with type information (#47)
       
       
       Hey ... i made a few changes so that Scraper isn't dependent on S7 and added a scraper
yml and test for Modbus that has been working fine ... so i think that could be mergt ...
what do the others think?!
       
       —
       You are receiving this because your review was requested.
       Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471316217>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/AAnvYU4REKkNb4vDrbRGaCJOQmiYCcEYks5vVSTogaJpZM4bixxc>.
       
       —
       You are receiving this because you authored the thread.
       Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-plc4x/pull/47#issuecomment-471326798>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/AQToCjpLLm1hnpXZ3XYOLiN39BPYvD2Gks5vVUKNgaJpZM4bixxc>.
       
    
    ----------------------------------------------------------------
    This is an automated message from the Apache Git Service.
    To respond to the message, please log on to GitHub and use the
    URL above to go to the specific comment.
     
    For queries about this service, please contact Infrastructure at:
    users@infra.apache.org
    
    
    With regards,
    Apache Git Services
    

Mime
View raw message