plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-plc4x] JulianFeinauer opened a new pull request #57: Feature/plc4 x 108 ping method
Date Fri, 29 Mar 2019 09:54:22 GMT
JulianFeinauer opened a new pull request #57: Feature/plc4 x 108 ping method
URL: https://github.com/apache/incubator-plc4x/pull/57
 
 
   I implemented a ping() method based on Gunters code (in fact it is Gunters code) and "redirected"
the isConnected method there. 
   I extended the NettyPlcConnection and the ConnectionFactory to use the ping based approach
*if and only if* the protocol has ip adress and port.
   But for all these, it should work out of the box now.
   
   A manual test was performed by @timbo2k and me with S7 and Modbus-TCP and both worked excellent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message