plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-plc4x] timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper
Date Wed, 06 Mar 2019 17:50:07 GMT
timbo2k commented on a change in pull request #46: PLC4X-88: Add Triggering to PLC Scraper
URL: https://github.com/apache/incubator-plc4x/pull/46#discussion_r263058883
 
 

 ##########
 File path: plc4j/utils/scraper/src/main/java/org/apache/plc4x/java/scraper/triggeredscraper/triggerhandler/TriggerHandler.java
 ##########
 @@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.plc4x.java.scraper.triggeredscraper.triggerhandler;
+
+import org.apache.plc4x.java.api.PlcConnection;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+import org.apache.plc4x.java.api.exceptions.PlcRuntimeException;
+import org.apache.plc4x.java.api.messages.PlcReadRequest;
+import org.apache.plc4x.java.api.messages.PlcReadResponse;
+import org.apache.plc4x.java.scraper.exception.ScraperException;
+import org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScrapeJobImpl;
+import org.apache.plc4x.java.scraper.triggeredscraper.TriggeredScraperTask;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * holds the handler for the regarding trigger-scraper on rising-trigger edge
+ */
+public class TriggerHandler {
+    private static final Logger logger = LoggerFactory.getLogger(TriggerHandler.class);
+    private static final String TRIGGER = "trigger";
+
+    private final TriggerConfiguration triggerConfiguration;
+    private final TriggeredScraperTask parentScraperTask;
+
+    //used to enable trigger only on rising edge
+    private boolean lastTriggerState;
+
+    public TriggerHandler(String triggerStrategy, TriggeredScrapeJobImpl triggeredScrapeJob,TriggeredScraperTask
parentScraperTask) throws ScraperException {
+        this.triggerConfiguration = TriggerConfiguration.createConfiguration(triggerStrategy,triggeredScrapeJob);
+        this.parentScraperTask = parentScraperTask;
+        this.lastTriggerState = false;
+    }
+
+    /**
+     * checks rising edge of trigger event
+     * @return true on detection of rising edge, false otherwise
+     */
+    public boolean checkTrigger(){
+        switch (this.triggerConfiguration.getTriggerType()){
+            case SCHEDULED:
+                //used base scheduling -> trigger is always true
+                return true;
+            case S7_TRIGGER_VAR:
+                return checkS7TriggerVariable();
+            default:
+                //should not happen
+                return false;
+        }
+    }
+
+    /**
+     * acquires the given S7Field from S7 and evaluates if trigger is released
+     * @return true if rising-edge of trigger is detected, false otherwise
+     */
+    private boolean checkS7TriggerVariable(){
 
 Review comment:
   nope ... because this is the explicit check for S7 trigger ... could be improved within
https://issues.apache.org/jira/browse/PLC4X-89

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message