plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] chrisdutz commented on issue #44: S7: changed byteLength and blockNumber from short to int
Date Wed, 16 Jan 2019 20:40:55 GMT
chrisdutz commented on issue #44: S7: changed byteLength and blockNumber from short to int
URL: https://github.com/apache/incubator-plc4x/pull/44#issuecomment-454932417
 
 
   Ok .. so I double-checked the Protocol implementaton ... on the writing side, we're safe
as "writeShort(int)" works like a charm and we currently don't parse "AnyItems", so no way
we could parse it wrong. Guess we can merge this.
   
   Thanks for contributing :-)
   
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message