plc4x-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] chrisdutz commented on issue #44: S7: changed byteLength and blockNumber from short to int
Date Wed, 16 Jan 2019 20:32:11 GMT
chrisdutz commented on issue #44: S7: changed byteLength and blockNumber from short to int
URL: https://github.com/apache/incubator-plc4x/pull/44#issuecomment-454929448
 
 
   Argh ... dammit ... you are right. The protocol only transfers 2 bytes (1 short). However
you are correct that Java shorts are signed and the protocol uses unsigned, so you are correct
that we should change this to int ... however we now have to check if the protocol code is
correct everywhere.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message