Return-Path: X-Original-To: apmail-pivot-user-archive@www.apache.org Delivered-To: apmail-pivot-user-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ECF3819A93 for ; Fri, 22 Apr 2016 15:13:19 +0000 (UTC) Received: (qmail 91576 invoked by uid 500); 22 Apr 2016 15:13:19 -0000 Delivered-To: apmail-pivot-user-archive@pivot.apache.org Received: (qmail 91549 invoked by uid 500); 22 Apr 2016 15:13:19 -0000 Mailing-List: contact user-help@pivot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@pivot.apache.org Delivered-To: mailing list user@pivot.apache.org Received: (qmail 91539 invoked by uid 99); 22 Apr 2016 15:13:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Apr 2016 15:13:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2DF0818023C for ; Fri, 22 Apr 2016 15:13:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.981 X-Spam-Level: ** X-Spam-Status: No, score=2.981 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, MIME_QP_LONG_LINE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MOW-8kJqsz-F for ; Fri, 22 Apr 2016 15:13:17 +0000 (UTC) Received: from p3plsmtpa06-06.prod.phx3.secureserver.net (p3plsmtpa06-06.prod.phx3.secureserver.net [173.201.192.107]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 06BC55F1EB for ; Fri, 22 Apr 2016 15:13:16 +0000 (UTC) Received: from [10.0.0.100] ([24.6.166.18]) by p3plsmtpa06-06.prod.phx3.secureserver.net with id lTD91s00H0Q8UT401TDANp; Fri, 22 Apr 2016 08:13:10 -0700 Subject: Re: BXMLSerializer: different handling of script return values References: <76BA9121-629A-4438-93C1-84B3F9334BEB@rbwhitcomb.com> From: Roger Whitcomb Content-Type: multipart/alternative; boundary=Apple-Mail-0B26CE1C-AE0B-443A-8A2E-4296FB287D41 X-Mailer: iPhone Mail (13E238) In-Reply-To: <76BA9121-629A-4438-93C1-84B3F9334BEB@rbwhitcomb.com> Message-Id: Date: Fri, 22 Apr 2016 08:13:09 -0700 To: user@pivot.apache.org Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (1.0) --Apple-Mail-0B26CE1C-AE0B-443A-8A2E-4296FB287D41 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Oh, okay, I just read an announcement that there was a SPAM attack on the AS= F JIRA instance and they had to change permissions across the board to only a= llow committers to create issues. At least for now. So, I guess I have to create the issue. But can you send me your idea of the= issue description, etc. and I will create it for you.=20 Sorry about this. I'll see what I can do to fix this for you.=20 Thanks, ~Roger Whitcomb Sent from my iPhone > On Apr 22, 2016, at 8:01 AM, Roger Whitcomb w= rote: >=20 > I just tried it and going in from pivot.apache.org if I click on the red "= Create" button, Pivot shows up at the top but doesn't show up later in "All P= rojects". So just try again.=20 >=20 > Or I can create the issue and you can comment on it.=20 >=20 > ~Roger Whitcomb >=20 > Sent from my iPhone >=20 >> On Apr 22, 2016, at 7:16 AM, Josh Highley wrote: >>=20 >> I must be missing something: I've submitted Pivot issues on JIRA before (= ex: PIVOT-980), but now when I go to Create Issue, Pivot isn't in the list o= f Projects. >> >>=20 >>=20 >>=20 >>=20 >>=20 >>=20 >>> On Thu, Apr 21, 2016 at 2:54 PM, Roger Whitcomb wrote: >>> Hi Josh, >>>=20 >>> That just looks like a bug to me. Can you file a JIRA a= nd provide a patch along with, and I will commit the change=E2=80=A6 >>>=20 >>> =20 >>>=20 >>> Thank you! >>>=20 >>> ~Roger >>>=20 >>> =20 >>>=20 >>> From: Josh Highley [mailto:joshhighley@gmail.com]=20 >>> Sent: Thursday, April 21, 2016 12:15 PM >>> To: user@pivot.apache.org >>> Subject: >>>=20 >>> =20 >>>=20 >>> In my bxml, I defined a TextInputContentListener method for previewInser= tText in script. The method was getting invoked, but my returned Vote seeme= d to get ignored. Stepping through the code, I found that BXMLSerializer ne= ver assigns the result variable and ignores the returned value when the meth= od is specified as an attribute but not when it's a child element. Is there= a reason for this, or is this a bug?=20 >>>=20 >>> =20 >>>=20 >>> I'm using 2.0.4, but the same code is in trunk >>>=20 >>> =20 >>>=20 >>> BXMLSerializer: >>>=20 >>> =20 >>>=20 >>> inner class AttributeInvocationHandler, method invoke(Object proxy, Meth= od method, Object[] args) >>> .... >>> // If the function didn't return a value, return the default >>> Class returnType =3D method.getReturnType(); >>> if (returnType =3D=3D Vote.class) { >>> result =3D Vote.APPROVE; >>> } else if (returnType =3D=3D Boolean.TYPE) { >>> result =3D false; >>> } >>> =20 >>> return result; >>> =20 >>> inner class ElementInvocationHandler, method invoke(Object proxy, Method= method, Object[] args) >>> ..... >>> // If the function didn't return a value, return the default >>> if (result =3D=3D null) { >>> Class returnType =3D method.getReturnType(); >>> if (returnType =3D=3D Vote.class) { >>> result =3D Vote.APPROVE; >>> } else if (returnType =3D=3D Boolean.TYPE) { >>> result =3D false; >>> } >>> } >>> =20 >>> return result; >>> =20 >>> Thanks, >>> Josh >>=20 --Apple-Mail-0B26CE1C-AE0B-443A-8A2E-4296FB287D41 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Oh, okay, I just read an announcement t= hat there was a SPAM attack on the ASF JIRA instance and they had to change p= ermissions across the board to only allow committers to create issues. At le= ast for now.

So, I guess I have to create the issue. But can you send me yo= ur idea of the issue description, etc. and I will create it for you. 

= Sorry about this. I'll see what I can do to fix this for you. 

Thanks,=
~Roger Whitcomb

Sent from my iPhone
<= br>On Apr 22, 2016, at 8:01 AM, Roger Whitcomb <RogerandBeth@rbwhitcomb.com> wrote:

I just tried it and going in from pivot.apache.org if I click on the red "Create= " button, Pivot shows up at the top but doesn't show up later in "All Projec= ts". So just try again. 

=
Or I can create the issue and you can comment= on it. 

~Roger Whitcomb

Sent from my i= Phone

On Apr 22, 2016, at 7:16 AM, Josh Highley <joshhighley@gmail.com> wrote:

<= /div>
I must be missing s= omething:  I've submitted Pivot issues on JIRA before (ex: PIVOT-980), b= ut now when I go to Create Issue, Pivot isn't in the list of Projects.
=
<image.png>






On Thu, Apr 21, 2016 at 2:54 PM, Roger Whitcomb <Roger.Whitcomb@actian.com> wrote:

Hi Josh,

       &nbs= p;        That just looks like a bug to m= e.  Can you file a JIRA and provide a patch along with, and I will comm= it the change=E2=80=A6

 

Thank you!

~Roger

 

From: Josh Highley [mailto:joshhighley@gmail.com]
Sent: Thursday, April 21, 2016 12:15 PM
To: user@p= ivot.apache.org
Subject:

 

In my bxml, I defined a TextInputContentListener meth= od for previewInsertText in script.  The method was getting invoked, but= my returned Vote seemed to get ignored.  Stepping through the code, I f= ound that BXMLSerializer never assigns the result variable and ignores the r= eturned value when the method is specified as an attribute but not when it's a child element.  Is there= a reason for this, or is this a bug? 

 

I'm usin= g 2.0.4, but the same code is in trunk

 

BXMLSeri= alizer:

 

inner class AttributeInvocationHandler, method invoke(Ob=
ject proxy, Method method, Object[] args)
....
   // If the function didn't return a value, return the d=
efault
   Class<?> returnType =3D m=
ethod.getReturnType();
   if (returnType =3D=3D Vote.cla=
ss) {
       result=
 =3D Vote.APPROVE;
   } else if (returnType =3D=3D B=
oolean.TYPE) {
       result=
 =3D false;
   }
 
   return result;
 
inner class ElementInvocationHandler, method invoke(Obje=
ct proxy, Method method, Object[] args)
.....
   // If the function didn't return a value, return the d=
efault
   if (result =3D=3D=
 null) {
      Class<?&g=
t; returnType =3D method.getReturnType();
      if (returnTy=
pe =3D=3D Vote.class) {
       &=
nbsp; result =3D Vote.APPROVE;
      } else if (r=
eturnType =3D=3D Boolean.TYPE) {
       &=
nbsp; result =3D false;
      }<=
/u>
   }
 
   return result;
 
Thanks,
Josh

= --Apple-Mail-0B26CE1C-AE0B-443A-8A2E-4296FB287D41--